From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Laight <david.laight.linux@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] lib/vsprintf: Fixes size check
Date: Fri, 20 Mar 2026 12:56:43 +0900 [thread overview]
Message-ID: <20260320125643.8200cf7334ae92c3e381442e@kernel.org> (raw)
In-Reply-To: <177397873418.32202.13853628019974387241.stgit@devnote2>
Sorry, I made a mistake on sending series. See v2.
On Fri, 20 Mar 2026 12:52:14 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> Hi,
>
> Here is a pair of patches to fix vsnprintf().
>
> - Fix to limit the size of width and precision.
> - Warn if the return size is over INT_MAX.
>
> Recently we discussed snprintf() usage in bootconfig and found snprintf()
> design has a problem[1]. It returns the required or printed size in 'int'
> but the maxlen is passed by 'size_t'. The maxlen is already limited by
> INT_MAX, but if the expected print size becomes bigger than INT_MAX,
> it can return negative value. We also found width and precision size check
> does not work.
>
> [1] https://lore.kernel.org/all/20260317121507.30735331@gandalf.local.home/
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (Google) (2):
> lib/vsprintf: Fix to check field_width and precision
> lib/vsprintf: Limit the returning size to INT_MAX
>
>
> lib/vsprintf.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2026-03-20 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 3:52 [PATCH 0/1] lib/vsprintf: Fixes size check Masami Hiramatsu (Google)
2026-03-20 3:56 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320125643.8200cf7334ae92c3e381442e@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox