From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554C83E122C for ; Fri, 20 Mar 2026 18:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030248; cv=none; b=PwYA6t1OswD8jo1rzkTeeAWhUI/YFWUbzkwDLB31HjDUPnjuAAykTqgCYfWmDGb/MJRcNUtQuJJ4IIIObm1/PqCwcpTf5gjXgqaIw93CsUf9iOB7JrGhBKFY24G58VW13jPffBrP3zfa9AiH0zI+OVi638D92y3IO9YVS4rMCNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030248; c=relaxed/simple; bh=bUiSWNCV/q5GUTFEbO+pksJYyRD9RwJfg6d89NZyVP8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ssGfrKVj+ZzeIDjdu0khtanVFKsGPuIzOyrqH/Ic2K6GK0q/adJ1M9YD2i2QxFxn8DvPZEy3RDqr+F8/pk8OM8Tnj2ZcKvjtE9+RC9DfcJsl6beWbGfu5pmWycpMzTQaHQzyD9AmhrPGanQj7b+HfbKbgF/iJHzvayTX2uNSNN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KZ0ZoYD6; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KZ0ZoYD6" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3591cc98871so962480a91.3 for ; Fri, 20 Mar 2026 11:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030243; x=1774635043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nlLjQPOmeaFila1aoTGt7mA4cxCj5RPLrmoLbYLboac=; b=KZ0ZoYD61cxyevsY8aNSJncPBT+8tw1VX2NXfdSFeaKpy05cnXzIfSbpg8lV1bnpnp wRPTa3B5AWIaBiwRlEnmfQu2vkjlKofsZyEatzVeup8A1VpjT1EAtGeJM78PagAMhHsv 5+qryXzH3U+Xc9a2veZoPQph6g6csC7WxVGWcV1lFxv/H8W5Zi+3dNhnVW+bVA9051Mu Cz+oKWO3bsM2h94QNl52VIl9KA1EdfZAqyLCk6cqfi2CZ2PvoDYDHyG+Vlj3eKfDmh0b 02YZnVW11RybGH16jnOsbv7jWAhzAVPIqs6XJfBQmHroB+LH48wU63OFe47kDbqYko/8 ySmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030243; x=1774635043; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nlLjQPOmeaFila1aoTGt7mA4cxCj5RPLrmoLbYLboac=; b=YDp2KvaAQnjEbjrBaxWkud3KFMTwW8Qq8SfOlqjUvek0XKQFdujGagsuHoRTRwNzBu 3volZDmCD75YgAnoksIlAMjeVXv+g8+hsVCKOw7fxlCHD8AxezTlMa8XPRDMwNg+jBcH 0NQGYUnWaw0gV3RX8vyFeVjeJF4KzRO5KU/fJP5ytwTybJvr1XDqOZxMuDGxGQvjupQe vXGinB2ICExG2dtymgk/2kNNev965fGeLGo4FoAb9/S9/FgH1CEI32sd+jXNUXXjiqbR SMlV2FofmqPUJ8tUsEI+f19gMkM1L0bOvkS61CDpcckv8jH/5SB6qjjx+7k9QGOSk2B3 Dziw== X-Forwarded-Encrypted: i=1; AJvYcCWZq2GQN3vE9nSngP1TjQ9SrOlqbchFnp//k1FGFOFZgLPp9mMT2xbclmXTm4M11BOXhLB8PFNuAPN7bUs=@vger.kernel.org X-Gm-Message-State: AOJu0YyGiCdkC78hAekonlAek4a7rUJqzd39S6QrAaUdCo6JLx1pj71V 94KoZRJvI1PU3m6VblWUBS7hfF3T+ig9apEXJH9T7IDkJzvGX52YbCT5 X-Gm-Gg: ATEYQzxjIkvIneNQm3ofRdT1iUbfBBQXu1SGz9HX9S7hyrYCJT8K6YB1MuAjooHzl+W PqIvjIhHGqaXlnp70UjWEYdchmvDRnp5fsetTp2B+2AjC3XeszWamSUX1gL1Ikv44NeM1XeY7YQ pi8oxeyeBTib82B3HMMMrhIZwldy760G8GiOMMq2qEznau1zyND4amnXa+9+exIwPLC6GFWzul+ DEyWs0PAZa8GrJRUYILHZXbPcTQH+1BpXgn+TaHOavcQ7k9ZE98pVDJBC1R8okWmjmzrqwZTVc7 8tQ8UKEC/W5XiYcVy3NJ2YvCcO37OZWG6UyBenYmBC3iLKx4Ob0I9srVkDKXZzSxrrtK6jO5w6A 8qvjDIpT4O9GcG+RU9vU47OzJ9PraUfVjqJQn0S+UvCObTrkgUOEJoXcDN36WSIcQxrnYR/qP/H vKVYOQYjrkCRfswbOhzpWaJDKfgEC4P3RLbmHxtNJE52g98jLEQTlpkMkP0ez9p4v31xet63U+k 5Z2XMFoIw== X-Received: by 2002:a17:90b:17ca:b0:35b:98d7:a67 with SMTP id 98e67ed59e1d1-35bd2d0860bmr3278434a91.31.1774030241779; Fri, 20 Mar 2026 11:10:41 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:41 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 0/5] sunrpc/nfs: cleanup redundant debug checks and refactor macros Date: Sat, 21 Mar 2026 02:09:50 +0800 Message-Id: <20260320180955.150696-1-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards across sunrpc, nfsd, and lockd, as these checks are already handled within the dprintk macros. Additionally, it refactors the nfs_errorf() macros into a safer do-while(0) pattern and removes unused nfs_warnf() macros to improve code maintainability. v4: - Add a missing patch to include/linux/sunrpc/debug.h to ensure dprintk() properly handles variable referencing via no_printk(). - Remove obsolete __maybe_unused from fs/nfsd/export.c (revert ebae102897e7) as suggested by Andy Shevchenko. - Add Reviewed-by and Tested-by tags from Andy Shevchenko. v3: - Added nfs_errorf refactoring and removed unused nfs_warnf macros. - Split sunrpc and nfsd changes for better clarity. v2: - Follow reversed xmas tree order for variables in svc_rdma_transport.c as requested by Andy Shevchenko. - Polish commit message: use dprintk() and remove redundant file list. - Correct the technical claim about dprintk() type checking. Sean Chang (5): sunrpc: Fix dprintk type mismatch using do-while(0) nfsd/lockd: Remove redundant debug checks svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards nfs: refactor nfs_errorf macros and remove unused ones nfsd: remove obsolete __maybe_unused from variables fs/lockd/svclock.c | 7 ------ fs/nfs/internal.h | 28 +++++++++++------------- fs/nfsd/export.c | 2 +- fs/nfsd/nfsfh.c | 8 +++---- include/linux/sunrpc/debug.h | 8 ++----- net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 ++++++++++----------- 6 files changed, 30 insertions(+), 48 deletions(-) -- 2.34.1