From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55B2C21E087 for ; Sat, 21 Mar 2026 06:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774073696; cv=none; b=XOrqfcXu5PdoAW9ZA6v87/NanhcwqJHcAEr/3Ocbk5bXtLJgC86cyuFAxiWIAbyQxKeMItxahnGYSnTzdbkDR7CYYBwQ/bdMkQUnqEmjEv3ZRDpvyS8wAGOrVBQBS983iJp3glHb4qH57YNyDjoynUB4YsT+OfKhqD6wg8n/Zj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774073696; c=relaxed/simple; bh=2Bib7wgHxSMJgG7dHD7S9FAf/Hs2BvL35JFJwF61oA0=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=g3Y3wKPIxUltOWnbUDxl7Vvt6fZ5XqFVjd2WcKC0167wb17RpZjj93SGyWCEoLE8q+ZayOYdcH9ZfLLRE/8SySuo4p4CvCmzOwUn9ZBRrVohrsSXgCeqTL2cvIta9YuZ87aZ2dYIUCOtfSddvr620v3zjECi6mnNv++4DJEudY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ii3xail8; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ii3xail8" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2c0ffce2570so45649371eec.1 for ; Fri, 20 Mar 2026 23:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774073693; x=1774678493; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=8PACYQbbmNhHgKdqEmTpeBymBEr9h1nJcy7rekDFmHk=; b=Ii3xail8pmyMoltkt0msegQDa33rRcdmOkfQH75YOP1zLKQfEc7lWTrFoafR509IQh rE4lCEfiFx9WVNbAX54ocDzIdt3ycMi7bMx5TdYy/dIkzUG36V5+k1lE15SlUNLRScYx 9+Y0qO+M9/RTY0E6GBH7gHpoj3tRb6O9tj0uRSrSxhkjtwKRgT4Z8ecagPnn/RiRQV8k +8koAC8ZqEMxdADMR3KsNuqeGeaptsCwaZb7HDfxZ0P6xQXQd4bvD/TGebg2BTUqA1GB OlyNB7wvjw7bJMf4QIOLJUJvWGHVLebgPr8gHQ7o48bSJugn3LVQbFRHHkAEgCqOcMT8 ZkCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774073693; x=1774678493; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8PACYQbbmNhHgKdqEmTpeBymBEr9h1nJcy7rekDFmHk=; b=R/6ucU/lfgfX2ryGfGhL1YxXhMXxTMtunHmjbOQD4CzOQbomxUdZfFoyXAF5wvWhdq vZqXbcXxjTikDP+xyNaUL+9ye+rj4hWWgoEi7ChaztzYWcG9EjLA51HKmS9siorTWtc4 kBjgRx9HKxyoDB6kbxwONtKgwEYZA5BcTI8s9rbg7rVToru9JI8H2iZz2ZoA1tRw8i9P ZkMaxlNXlkvK6YLRbS1F0IF10DxOTQfJJoEqND4d3V7BkkU7wzgoM4aok7nm4EnQB2Zl b6D0rflffbZWGyTWvEv6iL2A1ENo12t70B/7COpF9CK35Pc+jiSEp74w/U68sAfEXQW3 5uWA== X-Forwarded-Encrypted: i=1; AJvYcCUU+VnYxCzDSRr1iUUul5KNamyeVN6ZIDapJD67530d1/q4yaihoXkDvcbLne7NzmLpUn2LpVUd7qtsuzE=@vger.kernel.org X-Gm-Message-State: AOJu0Yziv6kiWbqo9gR/jykaEV4aFl0gVriNUTVMzgC/yTSCkFA16ik1 Ob+4psHUk8T38XuKmO0/ccx3Wo3IcZafxV0HVQpOBBAS+9UT4PPs1vBE9a9ljFa7CTBn/BaVJZO aHJRXxJ0K5w== X-Received: from dycmq1.prod.google.com ([2002:a05:7301:781:b0:2c0:d73f:8519]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:e785:b0:2be:2f58:2ef5 with SMTP id 5a478bee46e88-2c1095d7861mr3213370eec.1.1774073693178; Fri, 20 Mar 2026 23:14:53 -0700 (PDT) Date: Fri, 20 Mar 2026 23:14:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog Message-ID: <20260321061448.810525-1-irogers@google.com> Subject: [PATCH v1 1/2] perf sched: Avoid segv if tp_handler not set From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Swapnil Sapkal , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Doing a `perf sched record` then `perf sched stats report` crashes as the tp_handler isn't set. Add extra checks that tp_handler is set before accessing through it. Signed-off-by: Ian Rogers --- tools/perf/builtin-sched.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index d083e2bb7703..196f263ff667 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -1525,7 +1525,7 @@ static int process_sched_wakeup_event(const struct perf_tool *tool, { struct perf_sched *sched = container_of(tool, struct perf_sched, tool); - if (sched->tp_handler->wakeup_event) + if (sched->tp_handler && sched->tp_handler->wakeup_event) return sched->tp_handler->wakeup_event(sched, evsel, sample, machine); return 0; @@ -1809,7 +1809,7 @@ static int process_sched_switch_event(const struct perf_tool *tool, sched->nr_context_switch_bugs++; } - if (sched->tp_handler->switch_event) + if (sched->tp_handler && sched->tp_handler->switch_event) err = sched->tp_handler->switch_event(sched, evsel, sample, machine); sched->curr_pid[this_cpu] = next_pid; @@ -1823,7 +1823,7 @@ static int process_sched_runtime_event(const struct perf_tool *tool, { struct perf_sched *sched = container_of(tool, struct perf_sched, tool); - if (sched->tp_handler->runtime_event) + if (sched->tp_handler && sched->tp_handler->runtime_event) return sched->tp_handler->runtime_event(sched, evsel, sample, machine); return 0; @@ -1840,7 +1840,7 @@ static int perf_sched__process_fork_event(const struct perf_tool *tool, perf_event__process_fork(tool, event, sample, machine); /* and then run additional processing needed for this command */ - if (sched->tp_handler->fork_event) + if (sched->tp_handler && sched->tp_handler->fork_event) return sched->tp_handler->fork_event(sched, event, machine); return 0; @@ -1853,7 +1853,7 @@ static int process_sched_migrate_task_event(const struct perf_tool *tool, { struct perf_sched *sched = container_of(tool, struct perf_sched, tool); - if (sched->tp_handler->migrate_task_event) + if (sched->tp_handler && sched->tp_handler->migrate_task_event) return sched->tp_handler->migrate_task_event(sched, evsel, sample, machine); return 0; -- 2.53.0.959.g497ff81fa9-goog