From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5EC334404A for ; Sat, 21 Mar 2026 18:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774117659; cv=none; b=N98bIPv9gnKVnTKpnubisSJdlbyrkb9CBj6zZMAcsYHvR+bLsqtOc1frfkvzG057RH/h2SrHZdACD/lckph8ChQiyXcScwZTJ5sGE5s6zWnP0KJYls7zOuUSUlzqeEQBjt+seCKy3Az1muc4vWcnBYK01bUE0tZXpf5rUNQhd2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774117659; c=relaxed/simple; bh=xfpVEqh4tpOX1TMNZSpvWKdSH0k1FG4qg8EgMc3F+H4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XFmYvGHR5SsNv9zTB36VoziRZBPwx7fHEJG/dtseSSjwDUJrCXK1feZRueHFScyrMazoioBxFizQh8r6Rdv5KKgxexxRLp3acPo82f8Wrbq1Vw6qe2+WHU14hBbTR7cBPdVajX98ZCdLmCFelmyd2llovyUKkUz032h9GTB4atk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=La6VeX+F; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="La6VeX+F" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-66970715adbso496889a12.3 for ; Sat, 21 Mar 2026 11:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774117656; x=1774722456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=428qb3x4DZY6oAXBg5EWFqFtCk3r33e9i4fSNfvggJE=; b=La6VeX+FZT578p6iS8oAmwajQa/6lUZ/qX6utqgT30gVf74oRvIJkHWj+xa00rKfPc ij61fLiIOp8lqsdHjH/YzVWMxsgjrJwcpvp7VMSJqHOtQXbo2howJbo+fZgS4Xe4KkN8 5aAElyuSz1fKTY+AyhKm0lGL8E1awthclrn45eOco8fG513SXxkKHiq6/0Yjt9fAmD/A ZjytAX3Vvwlvp2G96Mjvht+uq0DBif3XULaVNUu7IIo4cqgyyLMpks4piomNyUPEBNK+ vklrH9tXJ3YeFeDqrmdX7PmXZWogCyv+TJjrde4a9/AYBkyYcWjQYxgHwaG20+QiB3Is zpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774117656; x=1774722456; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=428qb3x4DZY6oAXBg5EWFqFtCk3r33e9i4fSNfvggJE=; b=REHwvegycqf2FiE3v/87cBL9d4FHiw5XSU5mS8xHKGnl7CIPjFVcGQHXad8pTw9t30 S0Tdg5XX5/kPtm9BpDHVPaTNCcRjTNG4478AIo0bjYVkjGGY4Vh1JHM/5sjz1j1AvYG/ bFQi4Ade/D2v3S/s2c9pFyY0b7xRdA+o5cF+WsQJpCfZwFZ6zUjfdfrQcuFPtf/sDaHj rjssCr5a+BsjMNMDOPJ0Abo1TScnjaHKzuluR6KbkrljRLsnW5WBlENv2Ucay853Drgd 0maulDT9WtbhNkbDRd4BZFY1aJ03xA/sDk7B+u8IXNP1KfzoYiILn6hnPGBsUqediVAA NUtw== X-Forwarded-Encrypted: i=1; AJvYcCW+kKWJqsAsX0B+VGyfVVgS2ljntAcCU14sdO/KdKoBfFdFAT9lqInTW6cJpIeSceNDsU3gWq3deh9gtN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6B/IaDntDTfDaJUzZN+S6Ise0V0waNJv2qU6PkOSh9cAzpZR0 PvfaPVLnTAeWwa2UZOcQhFxkmaq3MuvrSyF7G71bS1KughQXh2MBGZKJ X-Gm-Gg: ATEYQzxZtoMOSpzpRPqa3Y4yJmc65HHCDKwqhpE1kF1tz3jR5EmweuY7udup4kFmWaj /TGwOzG2/bd/hbUyV8mwZtpjMqmfQokg71NTjS7ZHqEYWfVKklghJLIsEkTIF5EonLDkV3BQohQ wDd9bxg+8X0B2UfOgHFQ+fdjWspsFkHlqpMtsye1QrSlMTNzx+43xRomph852qujqT2RVzBSQ/c yPrVZHh9/k1lRK2cR9huDMQEXQsV5yYnG3U28W3nrz8S0HRdxnpTlWG7C5hDbIvzTYQkONGbynQ HkLG29pHu0nnAQ+4WTWEaG7EHnwQXQDu1twJ10hv158IeTT23cmpUAo2mlNN5hKQ+Wirmx5kJZ2 3Sek3BwZfEa00zSXkZMlWTcNRvACND2m8wazl7km/pL6s9GUgzkikh9kf/n6NVLMo/QO6+BT2Lw Zt+SkU/qcqPyxEBb3qYsFYDSSNMx/jgFdVogHG4HzZC1eEbQ== X-Received: by 2002:a17:907:6b0e:b0:b98:1129:51 with SMTP id a640c23a62f3a-b982f244be4mr544317866b.17.1774117655894; Sat, 21 Mar 2026 11:27:35 -0700 (PDT) Received: from localhost.localdomain ([2a00:f41:18ce:4346:2c4b:1eff:fec9:fe24]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983388070csm285097866b.60.2026.03.21.11.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 11:27:35 -0700 (PDT) From: "Jose A. Perez de Azpillaga" To: linux-staging@lists.linux.dev Cc: Greg Kroah-Hartman , Michael Straube , Hans de Goede , Khushal Chitturi , Dan Carpenter , Luka Gejak , Vivek BalachandharTN , Artur Stupa , Zhuoheng Li , Nino Zhang , linux-kernel@vger.kernel.org Subject: [PATCH v4 0/2] staging: rtl8723bs: clean up rtw_joinbss_event_prehandle Date: Sat, 21 Mar 2026 19:26:58 +0100 Message-ID: <20260321182713.665872-1-azpijr@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series cleans up the rtw_joinbss_event_prehandle function in the rtl8723bs staging driver. The first patch removes dead code guarded by the REJOIN macro, which is never defined in the kernel. This simplifies the function before the subsequent refactor. The second patch refactors the function using guard clauses and early returns to reduce deep indentation, improving overall readability. v4: - Removed redundant return at the end of the void function. - Fixed typo in v3 cover letter. ("Rmoed" -> "Removed") - Picked up Reviewed-by tag from Luka Gejak. v3: - Removed the 'retry' variable which became dead after REJOIN removal. - Removed the 'ignore_joinbss_callback' label and use direct returns. - Preserve the original comment for the join_res <= 0 case. - Keep the original newline for the netdev_dbg call. - Moved the 's5' comment after the spin_unlock_bh call to match original placement. v2: - Split the original patch into a two-patch series. - Changed the subject line. - Removed all REJOIN-related dead code. - Fixed a typo in the ptarget_sta comment. - Avoided unnecessary changes. Jose A. Perez de Azpillaga (2): staging: rtl8723bs: remove dead REJOIN code staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce indentation drivers/staging/rtl8723bs/core/rtw_mlme.c | 155 ++++++++++------------ 1 file changed, 68 insertions(+), 87 deletions(-) -- 2.53.0