From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E16F235A3A0 for ; Sun, 22 Mar 2026 03:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774148974; cv=none; b=GThjmDoezwNen1KrcyzEsqeOJltBOHf3GuSLlHnmQ+PQJLcY2yh3631CBzkjBdOiYgnnX1hdVlvalYFaDowjnn114goP/5O0TXkYGkmQbRATh5Ddl7Jy+jC1tjxD4AqBE7AVXDYlQL41xN+AppCWUSHADbhH0FMe8ErIXUDWCdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774148974; c=relaxed/simple; bh=Y0vJ04qnrIj0JjEPZkiv+HOg9hCIM3QRi+mv9JwVktA=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Ldqac3KHQaEkYWc97yUIYBf/U2N8CqucBmp7VqY9+5li5xizA30EpR2KUz9obnfTKcThxZfQA6gUsO7SCIjVdpdhCdY306f0Ym3M90TWR12oDixZAhLeS9a9+0FXF3bSM1Y31DrbL6myv1fenagE91ObCciLskto4JSzAN53lNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SN/sFpCs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SN/sFpCs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C423C2BC87; Sun, 22 Mar 2026 03:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774148973; bh=Y0vJ04qnrIj0JjEPZkiv+HOg9hCIM3QRi+mv9JwVktA=; h=Date:From:To:Cc:Subject:References:From; b=SN/sFpCs4AAJMyvdxtM+J2e4LaVIr9u4CutnVKk+6sDGw2W6qZJUorkkgtEGWuAfI zmKhbwaETvisuubqukiGXk2affC+hP2F2pCl5WR3yVzo8F1/5D51ane0ByYuXKqP6i godxws6HF9/s/nKbJMp8nLdG+1j6VWdY79Aq81tyM7qoO8ouSHPoeF8SYUPNlYl1sB 6cY0vkrBLjH9mML7POHZaa34Xa+Wxk6X7wozkPTFAD4M+Vx+Qi4mBMCkPQwWt5pqYj AaVgCNXKgCJG23kyL+CcURpLGguusEr1vB8yvyQxs3F9eXsLxB6CE+owBAFNc83CJV LiuJe34SCcobg== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w49Cc-0000000B7jI-0iSU; Sat, 21 Mar 2026 23:10:10 -0400 Message-ID: <20260322031010.014220602@kernel.org> User-Agent: quilt/0.69 Date: Sat, 21 Mar 2026 23:09:55 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , , , Guohua Yan , Xuewen Yan Subject: [for-linus][PATCH 1/5] tracing: Revert "tracing: Remove pid in task_rename tracing output" References: <20260322030954.198361547@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Xuewen Yan This reverts commit e3f6a42272e028c46695acc83fc7d7c42f2750ad. The commit says that the tracepoint only deals with the current task, however the following case is not current task: comm_write() { p = get_proc_task(inode); if (!p) return -ESRCH; if (same_thread_group(current, p)) set_task_comm(p, buffer); } where set_task_comm() calls __set_task_comm() which records the update of p and not current. So revert the patch to show pid. Cc: Cc: Cc: Cc: Link: https://patch.msgid.link/20260306075954.4533-1-xuewen.yan@unisoc.com Fixes: e3f6a42272e0 ("tracing: Remove pid in task_rename tracing output") Reported-by: Guohua Yan Signed-off-by: Xuewen Yan Reviewed-by: Steven Rostedt (Google) Signed-off-by: Steven Rostedt (Google) --- include/trace/events/task.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/trace/events/task.h b/include/trace/events/task.h index 4f0759634306..b9a129eb54d9 100644 --- a/include/trace/events/task.h +++ b/include/trace/events/task.h @@ -38,19 +38,22 @@ TRACE_EVENT(task_rename, TP_ARGS(task, comm), TP_STRUCT__entry( + __field( pid_t, pid) __array( char, oldcomm, TASK_COMM_LEN) __array( char, newcomm, TASK_COMM_LEN) __field( short, oom_score_adj) ), TP_fast_assign( + __entry->pid = task->pid; memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN); strscpy(entry->newcomm, comm, TASK_COMM_LEN); __entry->oom_score_adj = task->signal->oom_score_adj; ), - TP_printk("oldcomm=%s newcomm=%s oom_score_adj=%hd", - __entry->oldcomm, __entry->newcomm, __entry->oom_score_adj) + TP_printk("pid=%d oldcomm=%s newcomm=%s oom_score_adj=%hd", + __entry->pid, __entry->oldcomm, + __entry->newcomm, __entry->oom_score_adj) ); /** -- 2.51.0