From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBB6635E957 for ; Mon, 23 Mar 2026 08:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774254076; cv=none; b=QI+t0bNsX+RP0qcbd7+sVIrxMHaMNlKuVVC0wTe/4+buDe1zfAWW3+2q7IhO/Xzfh52g3OQax+xG023zZmVVwM3lq2yGlVgwfzPC59MR3XtHiFeRhB68qtLZK9n1a2NT5sgR8P6EBRkZP3lzlapR57TiRBOcSInjJRcYbBi9NX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774254076; c=relaxed/simple; bh=GM8x3oyUxbRyQWgmKCxtMi8x5dV7Q4tnuubuBpQekp0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dSdjciijYSDYmkqmwryPg8hkALXiiVSPsbo0uElvX7N8XvEwbv4XaY7faCDNIlxhfjDFJvMoAeTW1Rsysb+M7FpwGlgXZev1IeebkAm9nJq4utCcvGBer+qrst3Ny2A2f1vlsRJgHP56A1E9Wci0m+Rx1bnjS9x5UndG0ImcGPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yKjCKdsy; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yKjCKdsy" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43b49819938so1469998f8f.0 for ; Mon, 23 Mar 2026 01:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774254073; x=1774858873; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=UY+UoW+/BMSdhh0KdbnqTpPp259N8c4v9xdTx5HyxAc=; b=yKjCKdsyHSvF5mr0Vi5qFjwv97qK6NF/61Oemo7zGd7Y0IYpYgNTWNrw2laMp8b2r0 ZAPZKpbHo3DbKxu7txC1aVfQp8nqI3BCY0GYBhYo3h0mHdl8a7y5+g0oJ5/vqpLWe26r zmFUokOEeehaGkzkKmt2pk8CfjCyM3NJ2w90y0APdNhLEfhk6B9+sKJmTOTJ7R4VtNXb Majg67429PSX6YCYtH3jibxs0vk+3PJ3iTmDO+xSNuHgn9FThaK5qakjt/DUCS4yTtqJ f9z1jbIL3uVRPRNdWVUGIL/0RualitToHDgsZZ3dlCMHFC2LB9JcGpkbm4xk65rjumJn a2ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774254073; x=1774858873; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UY+UoW+/BMSdhh0KdbnqTpPp259N8c4v9xdTx5HyxAc=; b=ByQTkolvKw+aZui0vitpcmJon7IrQ0j5uLpdvSTMaIBN5L5vKtEZJ0O+4Dl9uQUR7h 85tK6S0I24a7Aw+L1pCyjDsRC2LihunsoXqvqxBfkjxoIwvNnLF2d2JL6VBuX7UKFwe4 vcVNV8XtWt8zSp3BLrY+BUQSzE7cVNwzerWtfZ/O6sq8U7jbuDEu/pvV9oTtjt03cwho P9vlMTZDNWPrXVJPEU+R/0Jw/dBhZ8QJ/TUdLWRU+HiuTJslKyeHVfWZdG02EvQRAVdv eR6IhXBeC5mmgOnqa8ZkcXh/uZjb2E+8EOtWGiB31wl8fd5rolOwoiCaw+bIU6MKW1ls Ruuw== X-Forwarded-Encrypted: i=1; AJvYcCWmFiiYZ0uEjAkz5mzKjm+blPfYf6ehPx0DzU/MyPM3nUKfbt4jab/rKYSzrDypK80kU7OhkuzjdE139hU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/dLyXLSHpP9N2fk5YC7MjKgcd1oyJwRfBIMH2GBVLk3jEI+VP ef2vUAsPKeI7suykr0Lti/F2xUYNbD292bmUpeRqNhmA5bDgtFqEeDN1uCA7kR14sOI= X-Gm-Gg: ATEYQzwGEMePEYoXn6ozFOkLca3UEaxYtvlZMyDRA8C3eCOg5ZRKio1ZY4cKKpi1ZY0 gnibd+/z8L8W/Gfr/Cu+HFH953SY6CDrNWPM2iI7wd1VEasRdANBxb4gwbGCxlvAtixke4QIrMR eVyTLum5nIHIStq3CbaBT+f7YhZS+CYxElnRYJRaQXcn06HC+c9QraZmJ9TLq0d4ZgTA4h8MhAZ HbqSNuzJ3JaCCkAPn8H2pPm1SaN3+piTS8MWws5FerigxK5pdDzI0qqOouQq6gF9iZRlfmcLiMv aZkkhdgKhdpeDOLQdlfpes+YCPH5M2aiYoBoayQlqZL9+jHbdQqeF6rHm5kVetJMveitbDp5JLA Tgi7SL210rIwroBE+Gh6tKNdKwMvJLs2ArskkCvx0IC2XMNJDeYR0cF530wZQFcvHt1J/VpBIHF u+irZtDZxHGhcOXlPPIkBSxz3f9J8H X-Received: by 2002:a05:6000:2f84:b0:43b:4273:a6ce with SMTP id ffacd0b85a97d-43b6423ebe4mr15440452f8f.3.1774254073135; Mon, 23 Mar 2026 01:21:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd38bsm27723091f8f.10.2026.03.23.01.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 01:21:12 -0700 (PDT) Date: Mon, 23 Mar 2026 11:21:09 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Anna Schumaker Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Trond Myklebust , Benjamin Coddington Subject: net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR' Message-ID: <202603230618.haJICSqp-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline [ Zero day bot is going through old warnings and resending. It looks like a valid issue to me? -dan ] tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ec69c9e88315c4be70c283f18c2ff130da6320b5 commit: df210d9b0951d714c1668c511ca5c8ff38cf6916 sunrpc: Add a sysfs file for adding a new xprt config: x86_64-randconfig-161-20260322 (https://download.01.org/0day-ci/archive/20260323/202603230618.haJICSqp-lkp@intel.com/config) compiler: gcc-12 (Debian 12.4.0-5) 12.4.0 smatch: v0.5.0-9004-gb810ac53 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202603230618.haJICSqp-lkp@intel.com/ New smatch warnings: net/sunrpc/sysfs.c:343 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +343 net/sunrpc/sysfs.c df210d9b0951d7 Anna Schumaker 2025-02-07 315 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj, df210d9b0951d7 Anna Schumaker 2025-02-07 316 struct kobj_attribute *attr, df210d9b0951d7 Anna Schumaker 2025-02-07 317 const char *buf, size_t count) df210d9b0951d7 Anna Schumaker 2025-02-07 318 { df210d9b0951d7 Anna Schumaker 2025-02-07 319 struct rpc_xprt_switch *xprt_switch = df210d9b0951d7 Anna Schumaker 2025-02-07 320 rpc_sysfs_xprt_switch_kobj_get_xprt(kobj); df210d9b0951d7 Anna Schumaker 2025-02-07 321 struct xprt_create xprt_create_args; df210d9b0951d7 Anna Schumaker 2025-02-07 322 struct rpc_xprt *xprt, *new; df210d9b0951d7 Anna Schumaker 2025-02-07 323 df210d9b0951d7 Anna Schumaker 2025-02-07 324 if (!xprt_switch) df210d9b0951d7 Anna Schumaker 2025-02-07 325 return 0; df210d9b0951d7 Anna Schumaker 2025-02-07 326 df210d9b0951d7 Anna Schumaker 2025-02-07 327 xprt = rpc_xprt_switch_get_main_xprt(xprt_switch); df210d9b0951d7 Anna Schumaker 2025-02-07 328 if (!xprt) df210d9b0951d7 Anna Schumaker 2025-02-07 329 goto out; Shouldn't we set "count = -EINVAL;" or something here? df210d9b0951d7 Anna Schumaker 2025-02-07 330 df210d9b0951d7 Anna Schumaker 2025-02-07 331 xprt_create_args.ident = xprt->xprt_class->ident; df210d9b0951d7 Anna Schumaker 2025-02-07 332 xprt_create_args.net = xprt->xprt_net; df210d9b0951d7 Anna Schumaker 2025-02-07 333 xprt_create_args.dstaddr = (struct sockaddr *)&xprt->addr; df210d9b0951d7 Anna Schumaker 2025-02-07 334 xprt_create_args.addrlen = xprt->addrlen; df210d9b0951d7 Anna Schumaker 2025-02-07 335 xprt_create_args.servername = xprt->servername; df210d9b0951d7 Anna Schumaker 2025-02-07 336 xprt_create_args.bc_xprt = xprt->bc_xprt; df210d9b0951d7 Anna Schumaker 2025-02-07 337 xprt_create_args.xprtsec = xprt->xprtsec; df210d9b0951d7 Anna Schumaker 2025-02-07 338 xprt_create_args.connect_timeout = xprt->connect_timeout; df210d9b0951d7 Anna Schumaker 2025-02-07 339 xprt_create_args.reconnect_timeout = xprt->max_reconnect_timeout; df210d9b0951d7 Anna Schumaker 2025-02-07 340 df210d9b0951d7 Anna Schumaker 2025-02-07 341 new = xprt_create_transport(&xprt_create_args); df210d9b0951d7 Anna Schumaker 2025-02-07 342 if (IS_ERR_OR_NULL(new)) { This should just be if (IS_ERR(new)) { since xprt_create_transport() can't return NULL. Returning count = 0 indicates EOF which would be strange. https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/ df210d9b0951d7 Anna Schumaker 2025-02-07 @343 count = PTR_ERR(new); df210d9b0951d7 Anna Schumaker 2025-02-07 344 goto out_put_xprt; df210d9b0951d7 Anna Schumaker 2025-02-07 345 } df210d9b0951d7 Anna Schumaker 2025-02-07 346 df210d9b0951d7 Anna Schumaker 2025-02-07 347 rpc_xprt_switch_add_xprt(xprt_switch, new); df210d9b0951d7 Anna Schumaker 2025-02-07 348 xprt_put(new); df210d9b0951d7 Anna Schumaker 2025-02-07 349 df210d9b0951d7 Anna Schumaker 2025-02-07 350 out_put_xprt: df210d9b0951d7 Anna Schumaker 2025-02-07 351 xprt_put(xprt); df210d9b0951d7 Anna Schumaker 2025-02-07 352 out: df210d9b0951d7 Anna Schumaker 2025-02-07 353 xprt_switch_put(xprt_switch); df210d9b0951d7 Anna Schumaker 2025-02-07 354 return count; df210d9b0951d7 Anna Schumaker 2025-02-07 355 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki