From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5ED381AE7 for ; Mon, 23 Mar 2026 08:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255121; cv=none; b=cWcRG3+GcBEdnB/YnEX+LWhGpKUsdc0HRLepQHvQSXYPt00cUgLvGY43WiAuOUVRa6joOTYUz3ZR3kWyoQM7O2Ubj8+MBpiLlXpIqba14F22JnC5gs24qCmwoMgqtBnlwpMwqZgF07V5h+buPF41/ByqhXH4GW2fL7SxKy/YfnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255121; c=relaxed/simple; bh=QwZEFeorxpwCaeP5jW8KMO6XgxyYHA/q67+XPWrH+zY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ea1zZE1QxG+aLaqf2zqI99JeSgoYi+HROzn0GwvfOsGUL+6dKuyFn7mfZyYYNgc70loMk5UJq+LTcU/CWBQG4mwd0CcgIr3l+MRUrbknwbap4VPoNA9VGoQMWV32qzMNW/G9klPwE8IKre6qUPrMPlkioIyR9aQxIN5WuOvH3ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sgcbhy+a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sgcbhy+a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3BFC4CEF7; Mon, 23 Mar 2026 08:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774255120; bh=QwZEFeorxpwCaeP5jW8KMO6XgxyYHA/q67+XPWrH+zY=; h=From:To:Cc:Subject:Date:From; b=Sgcbhy+awME8QoAXZtV+/1Rn6iADBlR5tLh+8y6jTh+02ZxgUzJ9GcSzArjM1bxlb y12BxJF3wvPs9qMXZ6iEIWopmNLJQqDGfo+CDwQxvOinGBrwkiWSLQOjjYJUY/Qisn SBTPxor60ETYjAdpcmyB4Du763sqgzbd4jL42OjFWdPE43zvzmd2h7J1lKIxr7OKsx ccaO7FGV2KvgRJQ6xa1AbTtE+Rnik4/GpR5qMHZEDPDEnsXtm4wGXWO8P74VaaBVhm 5AGC0uGjnZEF506FcOcVgmAkDkPbxmm3PIxwy6RBnWnzchWzX4ojeHiZeqmcp5UzyB H1fLtKFMVMj5Q== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH v3 1/2] f2fs: call f2fs_handle_critical_error() to set cp_error flag Date: Mon, 23 Mar 2026 16:38:32 +0800 Message-ID: <20260323083834.156393-1-chao@kernel.org> X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit f2fs_handle_page_eio() is the only left place we set CP_ERROR_FLAG directly, it missed to update superblock.s_stop_reason, let's call f2fs_handle_critical_error() instead to fix that. Introduce STOP_CP_REASON_READ_{META,NODE,DATA} stop_cp_reason enum variable to indicate which kind of data we failed to read. Signed-off-by: Chao Yu --- v3: - No changes. fs/f2fs/f2fs.h | 21 +++++++++++++++++++-- include/linux/f2fs_fs.h | 3 +++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 660bf88a376f..94cf1e78d892 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -5073,8 +5073,25 @@ static inline void f2fs_handle_page_eio(struct f2fs_sb_info *sbi, return; if (ofs == sbi->page_eio_ofs[type]) { - if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) - set_ckpt_flags(sbi, CP_ERROR_FLAG); + if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) { + enum stop_cp_reason stop_reason; + + switch (type) { + case META: + stop_reason = STOP_CP_REASON_READ_META; + break; + case NODE: + stop_reason = STOP_CP_REASON_READ_NODE; + break; + case DATA: + stop_reason = STOP_CP_REASON_READ_DATA; + break; + default: + f2fs_bug_on(sbi, 1); + return; + } + f2fs_handle_critical_error(sbi, stop_reason); + } } else { sbi->page_eio_ofs[type] = ofs; sbi->page_eio_cnt[type] = 0; diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index dc41722fcc9d..829a59399dac 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -80,6 +80,9 @@ enum stop_cp_reason { STOP_CP_REASON_NO_SEGMENT, STOP_CP_REASON_CORRUPTED_FREE_BITMAP, STOP_CP_REASON_CORRUPTED_NID, + STOP_CP_REASON_READ_META, + STOP_CP_REASON_READ_NODE, + STOP_CP_REASON_READ_DATA, STOP_CP_REASON_MAX, }; -- 2.49.0