From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E73843AB27F for ; Mon, 23 Mar 2026 13:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774273794; cv=none; b=esvetJSYtKwLt0hi3C1lerHc0R6fXySGwRqvQ5DiQaMit3Q2OrZrtOBPiGjHpYOFCCyVCic9xoJmb5dC4CXOyaS9wyD/JRLfb0CyQXwxyQ+Uo/7yGhlQo13xSS8rebI++8aj+RWf58/eUJNA9YJdHWf8iUDyFA0iX0pxffcqWdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774273794; c=relaxed/simple; bh=K/zqNg7ZfqxUgF2+3atTvNB9JA6m+F4WhZdtIUYXXEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Re/GHBLRk1ePGLWE+2cQwnKfVcDTqPiSRGsf7Xs1Nrp4W/hP3f3Sey88eht9W6VMQA+wnUeJgZwl6h3nhfrkFTbsBN8+29i0XSIK+9mBi994XZPjuOzosdcy9iNACZX/snUeW/X0QWWy811LrpWeoBMjrJY6ndaXXoSNnwQMlkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=t5aeOrCs; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t5aeOrCs" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4AF53874; Mon, 23 Mar 2026 14:48:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774273714; bh=K/zqNg7ZfqxUgF2+3atTvNB9JA6m+F4WhZdtIUYXXEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t5aeOrCsZrDtQzZA9/uvnieKLD7vFWk7l+AX3VxcWJ2pWum3wjGMd4La+sH70ukxx cO8i8Rrd87kmnlnRCIZ8bbpqUp8hbVqSX8HRlKQvLt0oHMBBwvWOxM8gPWDJtFdQ1o TcREA3sqFttitxuN+MCctN2FPX6W3GOHIP6YPKGM= Date: Mon, 23 Mar 2026 15:49:49 +0200 From: Laurent Pinchart To: Peng Fan Cc: Mark Brown , Liam Girdwood , Frieder Schrempf , Joy Zou , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type Message-ID: <20260323134949.GD1514659@killaraus.ideasonboard.com> References: <20260310-pca9450-irq-v1-0-36adf52c2c55@nxp.com> <20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com> <28dad7ac-3f09-4f0a-a9f9-cfe329f8670a@sirena.org.uk> <20260323105858.GA2185714@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Peng, On Mon, Mar 23, 2026 at 08:38:24PM +0800, Peng Fan wrote: > On Mon, Mar 23, 2026 at 12:58:58PM +0200, Laurent Pinchart wrote: > > On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote: > >> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote: > >> > From: Peng Fan > >> > > >> > Kernel warning on i.MX8MP-EVK when doing module test: > >> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000! > >> > > >> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked > >> > interrupt bit status is changed and it is released high once application > >> > processor read INT1 register. > >> > > >> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not > >> > IRQF_TRIGGER_FALLING. > >> > >> There appear to be a bunch of DTS files which specify edge triggered > >> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and > >> imx8mp-debix-model-a.dts) though more getting it right. Not an issue > >> for this patch but probably wants cleaning up. > > > > This patch creates an interrupt storm on the i.MX8MP-based Debix Model A > > board. I'm getting about 700 interrupts per second from the PMIC (and > > about 3000 interrupts per second from the I2C controller). > > > > arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the > > PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW > > does not help. > > > > Peng, I can run test to debug the issue if you tell me what to test. I'd > > like to fix the problem and avoid an annoying regression in v7.0, either > > with a follow-up patch, or with a revert if we're too short on time. > > Please help try whether below changes could help. > > I checked the schematic and iomux settings, I suspect the pad settings might > not be correct, it does not have PE set, even it has PUE. Without PE, PUE > will not work per my understanding. > > If below patch works for you, I will post this patch to list. otherwise, > we have to revert my patch or remove IRQ_TRIGGER_LOW when calling > devm_request_irq(). > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > index 9422beee30b29..df7489587e48e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > @@ -440,7 +440,7 @@ MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA 0x400001c3 > > pinctrl_pmic: pmicirqgrp { > fsl,pins = < > - MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x41 > + MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x000001c0 > >; > }; > This seems to fix the issue (I've also set the IRQ type to IRQ_TYPE_LEVEL_LOW). I have checked the schematics of the Debix board, and there's no pull-up resistor on the interrupt line, so an internal pull-up is indeed required. Will you submit a patch for v7.0 ? -- Regards, Laurent Pinchart