From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044EF3BFE31 for ; Mon, 23 Mar 2026 16:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282607; cv=none; b=jA+ZmmtIxJ1dgTL/SsF6xp4YbIVGS+iB8mcwb0tQR9BBnjmIrpA6I2xsXSNpclpM5yQLaBI0F33wyL4Xn7R2iNfYl0/748ptfaVSVSMBxPDLt8HsfNp+ED4oXtq/zhZnNKBkf862ji/v5fwNkp2VMHMuC5f4m9snUtXudJJrcq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282607; c=relaxed/simple; bh=iXK6wvRyFqYcb2f+HT0HHDjAo809KzTB5lgU9a6PXM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPciZt2RGerEcXvq5Z0G8es0no8TB7s6bRyRbI6Z1RZsJ/SpLOMi1UxlRxahiDvaCIFYDXXSWbab86KFy/9RC3pD2tJN2Dgg9NBm3xZs5CrUggJsVSbhUP3VUL5GD+z8WryueZx4xSlT5mOC4qQ5W9LU2svMkuScv3DhEPo5h94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+iniI/e; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+iniI/e" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso27159675e9.3 for ; Mon, 23 Mar 2026 09:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774282602; x=1774887402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gp4YODN/4k6phpMRYg5cRzJL2UKo8bXWoJWQxfk4Kow=; b=g+iniI/eDfcqqVVXzyBwiQCEzvWJoKmPSQu+Y4AWEyUguzdmeGYjes9ZALdXzAMeSa O/qhQMWUeP+M/vQVQlSVwvJJN2/NLs8Gv+77TbQVtFFlJvEc/5HiTMVU5aA/cfXhyp58 SMSDd05RBa9EK2IlpU57kUMMNMsQcXmwOntGfIcylkzITigeoSUmlMd1cDy4VdcDgKC9 i0LbYA6BDqMz9sI0vMC3HmG5SzPItuCzl3xTk9DFemgkoGm2FtenWDXzJEevcYE1I6dt Gwi+6wp7xOfecuUd0eDi7FxyJiLrdPNsuCGQHgX6Hi9ide/fxXCnmEcyAGP9pPjx9hox gCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774282602; x=1774887402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gp4YODN/4k6phpMRYg5cRzJL2UKo8bXWoJWQxfk4Kow=; b=F/+kF/EHv9ue9Euv+uUY/xM+hLdBj4wDeEXUQnqJSAvIIOh5ZeRzRMOt/NJIL4Aeul Pxujl8QZCwe98hGVmgWxypOFvI9huWaAkVYoxjvSvueFO5aH6IJg0tWDvPrRRnly9mc8 gsjRrrIJOxZJTM0aMQfwcoI9RcqBo+cb+K/Z+9/VvJjfiizhhdzXjRN5CIUTchbIjh82 zCm16su73XdkkPsozgPSlLgPAjaZF2jh0raH25fKnZ3GZW1zCT9qjFOD66wMRDS/kHqD zo8gJ23+RvD08Qg86xMtsLdCEzFcp4uRmikjwgfItppRZdAIznJk/U0f2digMrBNG2VK Xcmg== X-Forwarded-Encrypted: i=1; AJvYcCWbaO9cm84qwXoly6DjipjP0by7hrj2FIqzrvXkHSNOL6AMo0xXRuB90wHcDydTs8UepI71kxtO+M2sVtw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy12zu02GaY6MCEQo7271rF7EsKl6s4wnFpk/ofYw9pKGs5h+PW j6BQa1tTu9Pche+fxRFUQrWqnfrFQpNJfM4I/slZA/nQgRUErFlSfm2jFF2H X-Gm-Gg: ATEYQzzLjBAIEFMs2P0OC/MChWR8iLJ840+WLLL439kT7AEXGkC1rLbuyo7j1NXokWb /3N9aV2SH74W9JJJW68AfASEjZ+GvKpcgbHKjtoThCH6N2PFZA3CzvrDUwq7U4ie8eYhfAZoRuX dInxu8bAshAsaV/JFzuwe9sk6k8pRFghWNDqzOhvRYJdUwK60PHZlWATt3UP/pS3rsH5iSMlLHK qBBQ64e5KFW8qmm/PL35XaS3RbST2r0ReLKHaUFtZQR4FbkfoKz6Rn9OTIZV403irqB/jGI5jcx zPENDXTZ0i79q/fIiLcTngftA08bjZLI/Rq3pMWqmi3EQh9Y7VotTnSzQ/B5AKHe24Ku0Y1hZ3b v3IolaB7C3ZtAeof5D9kL0ssbkYItAjGx3s5gYTnwGmSY/CObkVgOWcXK6uxvkO7vBHDwUFXtM7 89VgIxpbAQSH0M3jXr2fLeEvzkvRo5oUHKSJCcrbuITA== X-Received: by 2002:a05:600c:3546:b0:486:fbdb:b718 with SMTP id 5b1f17b1804b1-486fee29536mr181005205e9.25.1774282601876; Mon, 23 Mar 2026 09:16:41 -0700 (PDT) Received: from localhost.localdomain ([78.240.51.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8aacc73sm331863395e9.0.2026.03.23.09.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:16:37 -0700 (PDT) From: Jihed Chaibi To: paul@crapouillou.net, linux-mips@vger.kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH 3/3] ASoC: jz4770: Convert to devm_clk_get_enabled() Date: Mon, 23 Mar 2026 17:15:51 +0100 Message-ID: <20260323161551.47181-4-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> References: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The clock is obtained with devm_clk_get() in the platform probe, then manually enabled in the component probe and disabled in the component remove without checking the return value of clk_prepare_enable(). Use devm_clk_get_enabled() instead, which combines the get, prepare and enable operations into one call whose lifetime is tied to the device. This removes the need for explicit enable/disable in the component probe/remove callbacks, and ensures that clock enable failures are propagated as errors rather than silently ignored. Remove the now-unused struct clk pointer from struct jz_codec and drop the empty component remove callback. Signed-off-by: Jihed Chaibi --- sound/soc/codecs/jz4770.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 6b86d47028d7..be1ecdcc737b 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -179,7 +179,6 @@ struct jz_codec { struct device *dev; struct regmap *regmap; void __iomem *base; - struct clk *clk; }; static int jz4770_codec_set_bias_level(struct snd_soc_component *codec, @@ -634,25 +633,13 @@ static void jz4770_codec_codec_init_regs(struct snd_soc_component *codec) static int jz4770_codec_codec_probe(struct snd_soc_component *codec) { - struct jz_codec *jz_codec = snd_soc_component_get_drvdata(codec); - - clk_prepare_enable(jz_codec->clk); - jz4770_codec_codec_init_regs(codec); return 0; } -static void jz4770_codec_codec_remove(struct snd_soc_component *codec) -{ - struct jz_codec *jz_codec = snd_soc_component_get_drvdata(codec); - - clk_disable_unprepare(jz_codec->clk); -} - static const struct snd_soc_component_driver jz4770_codec_soc_codec_dev = { .probe = jz4770_codec_codec_probe, - .remove = jz4770_codec_codec_remove, .set_bias_level = jz4770_codec_set_bias_level, .controls = jz4770_codec_snd_controls, .num_controls = ARRAY_SIZE(jz4770_codec_snd_controls), @@ -865,6 +852,7 @@ static int jz4770_codec_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct jz_codec *codec; + struct clk *clk; int ret; codec = devm_kzalloc(dev, sizeof(*codec), GFP_KERNEL); @@ -882,9 +870,9 @@ static int jz4770_codec_probe(struct platform_device *pdev) if (IS_ERR(codec->regmap)) return PTR_ERR(codec->regmap); - codec->clk = devm_clk_get(dev, "aic"); - if (IS_ERR(codec->clk)) - return PTR_ERR(codec->clk); + clk = devm_clk_get_enabled(dev, "aic"); + if (IS_ERR(clk)) + return PTR_ERR(clk); platform_set_drvdata(pdev, codec); -- 2.47.3