public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] dt-bindings: watchdog: Convert TS-4800 to DT schema
@ 2026-03-23  8:46 Eduard Bostina
  2026-03-23  8:46 ` [PATCH 1/2] " Eduard Bostina
  2026-03-23  8:46 ` [PATCH 2/2] ARM: dts: nxp: imx51-ts4800: Rename wdt node to watchdog Eduard Bostina
  0 siblings, 2 replies; 6+ messages in thread
From: Eduard Bostina @ 2026-03-23  8:46 UTC (permalink / raw)
  To: daniel.baluta, simona.toaca, egbostina, d-gole, m-chawdhry,
	Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Mark Brown, linux-watchdog, devicetree,
	linux-kernel, imx, linux-arm-kernel

This patch series converts the Technologic Systems TS-4800 Watchdog timer
bindings to DT schema and fixes the active hardware node in the iMX51
device tree.

Eduard Bostina (2):
  dt-bindings: watchdog: Convert TS-4800 to DT schema
  ARM: dts: nxp: imx51-ts4800: Rename wdt node to watchdog

 .../watchdog/technologic,ts4800-wdt.yaml      | 46 +++++++++++++++++++
 .../bindings/watchdog/ts4800-wdt.txt          | 25 ----------
 arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts    |  2 +-
 3 files changed, 47 insertions(+), 26 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt

-- 
2.53.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: watchdog: Convert TS-4800 to DT schema
  2026-03-23  8:46 [PATCH 0/2] dt-bindings: watchdog: Convert TS-4800 to DT schema Eduard Bostina
@ 2026-03-23  8:46 ` Eduard Bostina
  2026-03-23 13:24   ` Rob Herring (Arm)
  2026-03-23 16:59   ` Frank Li
  2026-03-23  8:46 ` [PATCH 2/2] ARM: dts: nxp: imx51-ts4800: Rename wdt node to watchdog Eduard Bostina
  1 sibling, 2 replies; 6+ messages in thread
From: Eduard Bostina @ 2026-03-23  8:46 UTC (permalink / raw)
  To: daniel.baluta, simona.toaca, egbostina, d-gole, m-chawdhry,
	Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Mark Brown, linux-watchdog, devicetree,
	linux-kernel, imx, linux-arm-kernel

Convert the Technologic Systems TS-4800 watchdog timer bindings
to DT schema.

Signed-off-by: Eduard Bostina <egbostina@gmail.com>
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 .../watchdog/technologic,ts4800-wdt.yaml      | 46 +++++++++++++++++++
 .../bindings/watchdog/ts4800-wdt.txt          | 25 ----------
 2 files changed, 46 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
new file mode 100644
index 000000000..cb2066b4b
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/technologic,ts4800-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Technologic Systems TS-4800 Watchdog
+
+maintainers:
+  - Eduard Bostina <egbostina@gmail.com>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    const: technologic,ts4800-wdt
+
+  syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    items:
+      - items:
+          - description: Phandle to the FPGA's syscon
+          - description: Offset to the watchdog register
+    description: Phandle / integers array that points to the syscon node which
+      describes the FPGA's syscon registers.
+
+required:
+  - compatible
+  - syscon
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    syscon: syscon@b0010000 {
+      compatible = "syscon", "simple-mfd";
+      reg = <0xb0010000 0x3d>;
+      reg-io-width = <2>;
+
+      watchdog {
+        compatible = "technologic,ts4800-wdt";
+        syscon = <&syscon 0xe>;
+        timeout-sec = <10>;
+      };
+    };
diff --git a/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt b/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
deleted file mode 100644
index 8f6caad42..000000000
--- a/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-Technologic Systems Watchdog
-
-Required properties:
-- compatible: must be "technologic,ts4800-wdt"
-- syscon: phandle / integer array that points to the syscon node which
-          describes the FPGA's syscon registers.
-          - phandle to FPGA's syscon
-          - offset to the watchdog register
-
-Optional property:
-- timeout-sec: contains the watchdog timeout in seconds.
-
-Example:
-
-syscon: syscon@b0010000 {
-	compatible = "syscon", "simple-mfd";
-	reg = <0xb0010000 0x3d>;
-	reg-io-width = <2>;
-
-	wdt@e {
-		compatible = "technologic,ts4800-wdt";
-		syscon = <&syscon 0xe>;
-		timeout-sec = <10>;
-	};
-}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: nxp: imx51-ts4800: Rename wdt node to watchdog
  2026-03-23  8:46 [PATCH 0/2] dt-bindings: watchdog: Convert TS-4800 to DT schema Eduard Bostina
  2026-03-23  8:46 ` [PATCH 1/2] " Eduard Bostina
@ 2026-03-23  8:46 ` Eduard Bostina
  1 sibling, 0 replies; 6+ messages in thread
From: Eduard Bostina @ 2026-03-23  8:46 UTC (permalink / raw)
  To: daniel.baluta, simona.toaca, egbostina, d-gole, m-chawdhry,
	Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Mark Brown, linux-watchdog, devicetree,
	linux-kernel, imx, linux-arm-kernel

The Technologic Systems TS-4800 watchdog node was previously named 'wdt',
which violates the core watchdog.yaml schema expecting generic node names.

Rename the node to 'watchdog' to fix the following dtbs_check warning:
'wdt' does not match '^(pmic|timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$'

Signed-off-by: Eduard Bostina <egbostina@gmail.com>
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts b/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts
index 5118a68db..3610ce395 100644
--- a/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx51-ts4800.dts
@@ -155,7 +155,7 @@ syscon: syscon@10000 {
 			reg = <0x10000 0x3d>;
 			reg-io-width = <2>;
 
-			wdt {
+			watchdog {
 				compatible = "technologic,ts4800-wdt";
 				syscon = <&syscon 0xe>;
 			};
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: Convert TS-4800 to DT schema
  2026-03-23  8:46 ` [PATCH 1/2] " Eduard Bostina
@ 2026-03-23 13:24   ` Rob Herring (Arm)
  2026-03-23 16:59   ` Frank Li
  1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2026-03-23 13:24 UTC (permalink / raw)
  To: Eduard Bostina
  Cc: Mark Brown, daniel.baluta, Krzysztof Kozlowski, Fabio Estevam,
	linux-arm-kernel, Wim Van Sebroeck, Conor Dooley, devicetree,
	Pengutronix Kernel Team, Guenter Roeck, Sascha Hauer,
	linux-kernel, imx, Frank Li, linux-watchdog, d-gole, m-chawdhry,
	simona.toaca


On Mon, 23 Mar 2026 10:46:12 +0200, Eduard Bostina wrote:
> Convert the Technologic Systems TS-4800 watchdog timer bindings
> to DT schema.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> 
>  .../watchdog/technologic,ts4800-wdt.yaml      | 46 +++++++++++++++++++
>  .../bindings/watchdog/ts4800-wdt.txt          | 25 ----------
>  2 files changed, 46 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.example.dtb: syscon@b0010000 (syscon): compatible: ['syscon', 'simple-mfd'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260323084616.10469-2-egbostina@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: Convert TS-4800 to DT schema
  2026-03-23  8:46 ` [PATCH 1/2] " Eduard Bostina
  2026-03-23 13:24   ` Rob Herring (Arm)
@ 2026-03-23 16:59   ` Frank Li
  2026-03-23 18:10     ` Rob Herring
  1 sibling, 1 reply; 6+ messages in thread
From: Frank Li @ 2026-03-23 16:59 UTC (permalink / raw)
  To: Eduard Bostina
  Cc: daniel.baluta, simona.toaca, d-gole, m-chawdhry, Wim Van Sebroeck,
	Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Mark Brown,
	linux-watchdog, devicetree, linux-kernel, imx, linux-arm-kernel

On Mon, Mar 23, 2026 at 10:46:12AM +0200, Eduard Bostina wrote:
> Convert the Technologic Systems TS-4800 watchdog timer bindings
> to DT schema.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
>  .../watchdog/technologic,ts4800-wdt.yaml      | 46 +++++++++++++++++++
>  .../bindings/watchdog/ts4800-wdt.txt          | 25 ----------
>  2 files changed, 46 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> new file mode 100644
> index 000000000..cb2066b4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/technologic,ts4800-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Technologic Systems TS-4800 Watchdog
> +
> +maintainers:
> +  - Eduard Bostina <egbostina@gmail.com>
> +
> +allOf:
> +  - $ref: watchdog.yaml#

Move allOf after required incase add if-else branch later.

> +
> +properties:
> +  compatible:
> +    const: technologic,ts4800-wdt
> +
> +  syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: Phandle to the FPGA's syscon
> +          - description: Offset to the watchdog register
> +    description: Phandle / integers array that points to the syscon node which
> +      describes the FPGA's syscon registers.
> +
> +required:
> +  - compatible
> +  - syscon
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    syscon: syscon@b0010000 {
> +      compatible = "syscon", "simple-mfd";
> +      reg = <0xb0010000 0x3d>;
> +      reg-io-width = <2>;
> +

Needn't this part. just keep below watchdog node should be enough.

Frank

> +      watchdog {
> +        compatible = "technologic,ts4800-wdt";
> +        syscon = <&syscon 0xe>;
> +        timeout-sec = <10>;
> +      };
> +    };
> diff --git a/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt b/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
> deleted file mode 100644
> index 8f6caad42..000000000
> --- a/Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Technologic Systems Watchdog
> -
> -Required properties:
> -- compatible: must be "technologic,ts4800-wdt"
> -- syscon: phandle / integer array that points to the syscon node which
> -          describes the FPGA's syscon registers.
> -          - phandle to FPGA's syscon
> -          - offset to the watchdog register
> -
> -Optional property:
> -- timeout-sec: contains the watchdog timeout in seconds.
> -
> -Example:
> -
> -syscon: syscon@b0010000 {
> -	compatible = "syscon", "simple-mfd";
> -	reg = <0xb0010000 0x3d>;
> -	reg-io-width = <2>;
> -
> -	wdt@e {
> -		compatible = "technologic,ts4800-wdt";
> -		syscon = <&syscon 0xe>;
> -		timeout-sec = <10>;
> -	};
> -}
> --
> 2.53.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: Convert TS-4800 to DT schema
  2026-03-23 16:59   ` Frank Li
@ 2026-03-23 18:10     ` Rob Herring
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2026-03-23 18:10 UTC (permalink / raw)
  To: Frank Li
  Cc: Eduard Bostina, daniel.baluta, simona.toaca, d-gole, m-chawdhry,
	Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
	Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Mark Brown, linux-watchdog, devicetree,
	linux-kernel, imx, linux-arm-kernel

On Mon, Mar 23, 2026 at 12:59:34PM -0400, Frank Li wrote:
> On Mon, Mar 23, 2026 at 10:46:12AM +0200, Eduard Bostina wrote:
> > Convert the Technologic Systems TS-4800 watchdog timer bindings
> > to DT schema.
> >
> > Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> > ---
> > Note:
> > * This patch is part of the GSoC2026 application process for device tree bindings conversions
> > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> >
> >  .../watchdog/technologic,ts4800-wdt.yaml      | 46 +++++++++++++++++++
> >  .../bindings/watchdog/ts4800-wdt.txt          | 25 ----------
> >  2 files changed, 46 insertions(+), 25 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/watchdog/ts4800-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> > new file mode 100644
> > index 000000000..cb2066b4b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/technologic,ts4800-wdt.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/technologic,ts4800-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Technologic Systems TS-4800 Watchdog
> > +
> > +maintainers:
> > +  - Eduard Bostina <egbostina@gmail.com>
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> 
> Move allOf after required incase add if-else branch later.
> 
> > +
> > +properties:
> > +  compatible:
> > +    const: technologic,ts4800-wdt
> > +
> > +  syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    items:
> > +      - items:
> > +          - description: Phandle to the FPGA's syscon
> > +          - description: Offset to the watchdog register
> > +    description: Phandle / integers array that points to the syscon node which
> > +      describes the FPGA's syscon registers.
> > +
> > +required:
> > +  - compatible
> > +  - syscon
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    syscon: syscon@b0010000 {
> > +      compatible = "syscon", "simple-mfd";
> > +      reg = <0xb0010000 0x3d>;
> > +      reg-io-width = <2>;
> > +
> 
> Needn't this part. just keep below watchdog node should be enough.

Well, the next thing to fix is going to be that this node needs a 
specific compatible. It doesn't look like there's any other child nodes, 
so probably want just one schema that defines both nodes.

Rob

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-23 18:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-23  8:46 [PATCH 0/2] dt-bindings: watchdog: Convert TS-4800 to DT schema Eduard Bostina
2026-03-23  8:46 ` [PATCH 1/2] " Eduard Bostina
2026-03-23 13:24   ` Rob Herring (Arm)
2026-03-23 16:59   ` Frank Li
2026-03-23 18:10     ` Rob Herring
2026-03-23  8:46 ` [PATCH 2/2] ARM: dts: nxp: imx51-ts4800: Rename wdt node to watchdog Eduard Bostina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox