From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BA92F8BF0 for ; Tue, 24 Mar 2026 15:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774367189; cv=none; b=mrIOblx6zPqXalIrQyePXwrLt7ZaMrnov0d6raGr1guYOVuDRaT0b8dttzS0fywW07synaBxQyFisBVcDlRbJu9vEUGbqXUwJAqJ2QVTOpC5tzGU6TSzDx67GcG4uBHRXeYfqL7NmDMu9aqcBW6UiKfsryclOFuE2WS/dGUCCcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774367189; c=relaxed/simple; bh=m3lSqCtEBPFBreamQU78QjOqMjupAixIdYCS/r5jo+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rYdSHDxG1X5p+Lv5LLUmTmkpQ0pDFNSdM2CQNRzd+NVZzYBSrsHeLaRSHioRjHmdPjzGUM9BLKcmPWFUiQi+uCy7fQZCnMxgvN6bm5m2HcoVYzua09nAWK0oOihT2KvwqK5MCLsmb/F+rORJwLHqH21Jen0UlRo/G7in1kNnW60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lxtkLSRX; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lxtkLSRX" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774367186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UnJmdsOvfQ0PdBrOg5suHiR4CCgw9Ejgl9OBfeDVN8U=; b=lxtkLSRXkwplDnNG/Ii//u3FFVZZzZycnUHhgnXCIsLGgKOjPQhYDCFZHRvzntyx3tXunp gvBepGV90qzrh0BMoKLyYu3sKPfZFmTsahyAtb0Jaj6zIuXNDvK5RpTwnPr7qcpFTw+870 8AkRksoE1Icx8IZAl2Nwc+0MNfPPHIs= From: Thorsten Blum To: David Howells , Marc Dionne Cc: Thorsten Blum , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] afs: replace goto with direct return in afs_lookup_atsys Date: Tue, 24 Mar 2026 16:45:18 +0100 Message-ID: <20260324154515.205796-6-thorsten.blum@linux.dev> In-Reply-To: <20260324154515.205796-4-thorsten.blum@linux.dev> References: <20260324154515.205796-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=899; i=thorsten.blum@linux.dev; h=from:subject; bh=m3lSqCtEBPFBreamQU78QjOqMjupAixIdYCS/r5jo+0=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJmHNk66MPPz5NB9Z6/0XuQ3/LpJ1ZrXdIp+79Hzt1/cN jj0ZcHd4x2lLAxiXAyyYoosD2b9mOFbWlO5ySRiJ8wcViaQIQxcnAIwkeBjjAxzE6e5cEzmelW6 vr7qWdrcw7oKv9+oMPs8sT4/c+HFq2WXGRnOe6zUbuB8uuNabKJn+rxMMb/ZP+99ujXH7NVTfmk 1O25OAA== X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Return ERR_PTR(-ENOMEM) directly and remove the obsolete 'out_p' label. Signed-off-by: Thorsten Blum --- fs/afs/dir.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 89d5c9c354d4..aec16ceebd94 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -919,10 +919,9 @@ static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry) _enter(""); - ret = ERR_PTR(-ENOMEM); p = buf = kmalloc(AFSNAMEMAX, GFP_KERNEL); if (!buf) - goto out_p; + return ERR_PTR(-ENOMEM); if (dentry->d_name.len > 4) { memcpy(p, dentry->d_name.name, dentry->d_name.len - 4); p += dentry->d_name.len - 4; @@ -954,7 +953,6 @@ static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry) out_s: afs_put_sysnames(subs); kfree(buf); -out_p: return ret; }