From: Josh Law <objecting@objecting.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josh Law <objecting@objecting.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] lib/base64: fix copy-pasted @padding doc in base64_decode()
Date: Tue, 24 Mar 2026 22:24:39 +0000 [thread overview]
Message-ID: <20260324222439.46028-3-objecting@objecting.org> (raw)
In-Reply-To: <20260324222439.46028-1-objecting@objecting.org>
The @padding kernel-doc for base64_decode() says "whether to append
'=' padding characters", which was copy-pasted from base64_encode().
In the decode context, it controls whether the input is expected to
include padding, not whether to append it.
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/base64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/base64.c b/lib/base64.c
index 20dacee25f65..325c7332b049 100644
--- a/lib/base64.c
+++ b/lib/base64.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL_GPL(base64_encode);
* @src: the string to decode. Doesn't need to be NUL-terminated.
* @srclen: the length of @src in bytes
* @dst: (output) the decoded binary data
- * @padding: whether to append '=' padding characters
+ * @padding: whether the input is expected to include '=' padding characters
* @variant: which base64 variant to use
*
* Decodes a string using the selected Base64 variant.
--
2.34.1
prev parent reply other threads:[~2026-03-24 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 22:24 [PATCH 0/2] lib/base64: decode fixes Josh Law
2026-03-24 22:24 ` [PATCH 1/2] lib/base64: validate before writing in decode tail path Josh Law
2026-03-24 22:24 ` Josh Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324222439.46028-3-objecting@objecting.org \
--to=objecting@objecting.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox