From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41CCF1DF261 for ; Wed, 25 Mar 2026 16:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455457; cv=none; b=hHePVUwsPd3YSPd3v3w/pos29p6Py4n3/fQ1DLz/Bck3duU/lEXjaLUCK/pL+z7rxHt2DAiOgdRhUeuo6YmXw61v3QCUNn+Pe7a8oepOdC8ipxOSlXKzxyVMme9yz84BYFX+wHug4OFF4SEPho35uqDxc27dzwHeHEO7PNZVhEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455457; c=relaxed/simple; bh=xBkaWvNs0j6T79MITUFZj8ha7X2ZKulYCS3mkun9dSk=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=nUNQ/4M7MYxfPOOlCf1wR58bdJ70vH1zZ/pzPmWRc5xPJxmLNV3L1MpjB1L+2KpyQaFnY++EjE1mGiJg41mFeT13eRaxb70aoG3MH/W9FqF2YXvlHOEKblGohpbcMVirxNjZD7klvd5/YTjmkkiD9COcbN1RhXKfokzOJcAIzd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=GWn7Nox+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GWn7Nox+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 669B0C4CEF7; Wed, 25 Mar 2026 16:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774455456; bh=xBkaWvNs0j6T79MITUFZj8ha7X2ZKulYCS3mkun9dSk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GWn7Nox+t+S1WqMXwp9Dfh5g69XALX64eXWlh+tmgox+OLOmEZcCbRvguyUb4X2Ga PNMjiwevCNt1iESAw4HlmOK1HYu42nTrdQ6Kst2mlq+LiCPBSLvCVt/PNou71NPzs8 vyGPlzw00WbnmwXvW1doNEpe9GR6nu4SSSCBsXq8= Date: Wed, 25 Mar 2026 09:17:35 -0700 From: Andrew Morton To: "David Hildenbrand (Arm)" Cc: "Lorenzo Stoakes (Oracle)" , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-Id: <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> In-Reply-To: <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> References: <20260221093918.1456187-3-vernon2gm@gmail.com> <20260224035247.r6mxsfcpiev4wnce@master> <1da56bbb-9211-42d7-9b08-3ee56d2b538d@kernel.org> <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Mar 2026 16:22:55 +0100 "David Hildenbrand (Arm)" wrote: > > > > Really larger stuff should be resent I think, esp. if there's multiple > > fixes in the series. > > > > A reply with the same-patch-but-with-fix-applied would definitely be > > useful! > > Right, for completeness, this is what we had in an off-list thread: > > " > Not sure if that's a problem for others, but I got the feeling that this > escalated a bit lately. > > I know, that we prefer fixups to sort out smaller stuff. So far so good. > In the last time there were some series where I was seriously completely > lost which state of the patches would go upstream, or what I should even > review, because there were just fixups over fixups. > > Fixups are nice, but for someone reviewing a series, too many fixups > (either as inline patch or even worse, as independent patches) just > causes a mess. > > It also gives the impression of "this is mostly done, so don't waste > your time reviewing it anymore." --- "just the finishing touches" --- > "don't jump in late and cause trouble". > " hm OK, so what to do. We're OK with teeny -fixes but anything more substantial we ask for a full resend and I do the heres-what-changed reply? I presently don't fold the -fixes until the very last moment. Could do that much earlier if it helps anything? Possibly useful to people who are looking at the series in the mm.git tree.