Re: [PATCH v3 03/14] ASoC: tegra: Add error logging in tegra210_admaif driver

Mark Brown
2026-03-25T13:06:00Z

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Wed, Mar 25, 2026 at 10:14:26AM +0000, Sheetal wrote:

> Log errors in the Tegra210 ADMAIF probe and runtime callback paths.

> @@ -966,10 +969,9 @@ static int tegra_admaif_probe(struct platform_device *pdev)
> regcache_cache_only(admaif->regmap, true);
>
> err = tegra_isomgr_adma_register(&pdev->dev);
> - if (err) {
> - dev_err(&pdev->dev, "Failed to add interconnect path\n");
> - return err;
> - }
> + if (err)
> + return dev_err_probe(&pdev->dev, err,
> + "failed to add interconnect path\n");

tegra_isomgr_adma_register() already logs failures.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]