Re: [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers

Mark Brown
2026-03-25T13:10:54Z

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Wed, Mar 25, 2026 at 10:14:32AM +0000, Sheetal wrote:
> Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using
> dev_err_probe().

> err = tegra210_peq_regmap_init(pdev);
> - if (err < 0) {
> - dev_err(dev, "PEQ init failed\n");
> - return err;
> - }
> + if (err < 0)
> + return dev_err_probe(dev, err, "PEQ init failed\n");

There's dev_err_probe() logging in the called function, the
dev_err_probe() here is redundant and overwrites the failure reason.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]