From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526A73B7B93 for ; Wed, 25 Mar 2026 10:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774434774; cv=none; b=e9uf184Uly+UlB8EbjU5usAktfUVDOwmR8qusLMd890ZhHeTeMvNMzHPmurVrh07gGvx5AkOEfAoGUolarNqabk20zvivSy3x7Koq5Wb2zYzFcJaE/Yo8P8a+mAbL1te4eTU2zdxYUKEihe+uyEgh7LkzZ1yRfAC2VM8tsD9TdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774434774; c=relaxed/simple; bh=FGGdrgKC/Z+YvdCUWQsTKr2aqUW0ST6EG9paGHCfwFU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FKQLOr5G9eeLvzfF8xQia+5LUbUHMD0w+FH52F2GB/xYq8ySobd0WLe2/CBZyGRqrTnp7WUobbFGgRnipVSKoQinZACR12hkbA/UyjkxTzI4AFo402APwdARJiU+aS4BADC5Sffuj39VEvVUtKflDOw2STwue/BspR31046iEDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ll2Nkv5O; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ll2Nkv5O" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so302644866b.2 for ; Wed, 25 Mar 2026 03:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774434772; x=1775039572; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HVOMnkbYwEL8fVDgn1ygmPBmgqD43enQpHSoLRimEuc=; b=Ll2Nkv5O8YjB6qt4aWt7Wjmh+yCSf5EpmcK3v9DoBn/6Y/Hg6Rsr26GVAKpyVpv79n qMl+RfRCUQT0U6xUYg44mjOEnm0acf0vGEpJchXYMxjW3aRrPXumAPW/4euv5PBVq36e eNDaSq/VfizlvB+REmISqu0Z5G0CgNlpiJ9pYqaTS2UyuD4wxH+X+LmVYQWQ0xRPYpWE wyMi9uyOR4e7o2wj4hJz7NY5G7eSgDSu54DoVtz3NkVDT9Eijt8IrYZiam+yW1OOjz6Z HX8swsJM9ivTnOoqWLQdVJ56dg1ejel1oLgTiNnXDjlX/NT03iOD3XiAwIemlQG4B3r9 gx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774434772; x=1775039572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HVOMnkbYwEL8fVDgn1ygmPBmgqD43enQpHSoLRimEuc=; b=mYvVw+rTOTkoKr+0AtczccK6k8mKjLCljy/TcGE4pmXwuZmY4T+q+323Wh5kdYy5pV qJq4VAtTYCaiB0ROIQJwrc3UjE9hSXBCdmxm7vx8X2h0A20A4hYrJxteAJHhyFot1VfZ cAafcnwnWp4Cq6HgJ2QXVX8odW23r2EfLqI/Ym6DicSNqLug+ouu324jUOxl1pgwc7Qk C2wvYmi1GEJv93hn0UzGRMuV2kqV9wPBXJ9bkYLTFyaUXshGczwImZxUMFq5K4Ckt4Mr C8xMkVjYYXTbYyNBA/b9mIxNHauOlQZ0FJi/yrZ9duqDCwPlQbVQvG77aoADJKQ6+Ztp Pp+A== X-Forwarded-Encrypted: i=1; AJvYcCWBusGJRG+krgrREf713njotgsiuZivO8jC0w9w8Ln4f5b2Q+CDK9ddEG80miDjOxl/LK1ir89+0bxDdpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzGlSWvyiqTq1lEyF6oOtbceJVdFQcLGVFRzrQQ8t23Pvya4qCT fjKDQdFqpspO600ncx3VedsiEDoxpH7Xrb8QMgUW4u69BsJBt6Se0uit X-Gm-Gg: ATEYQzwSbUWyjmzWg6VNE3bji0ym9TfVQj4t5N2+RM51tDAteuEUpHltw6o6eMq5gKM JbD8nagbIGtu0fZTkwMFA10DSfgfcKGD/GdvkKASPDxAC4etcqWr93e7Xqchp3Xk0UNRnsVNtss HfkoeJJWoGnmAzxC6XiwTzXoDNNUr6UrTthdwYPerTKjNq97QbpFuIIXNwKzCuD+as+Xy3KS/WY YEjAl6YjURKj9tPXEwCG23KFwWkMN6NhJPZPX90Nh+uxJnY77rd/H0XOsw+c328F62bLM25vX7h BS/UQZc9doft1kpTkc113jHvcqbWlTjjB+Y9eiKh8w29sRrMqwiDVtn0ai1rS4IKfKjWTJ/D+ws wCkohGWK/Nya8fjPN+CGdIi9Xj4YQHm43mcBX3l6DWHEAvJg3wAEG4HeMgTEhCJiPK6/4ccGPlz YFQE4n8lWw+BH3G+sQn3v1vMTq5Jz/BJOr9gc= X-Received: by 2002:a17:907:9605:b0:b9b:1b9f:8397 with SMTP id a640c23a62f3a-b9b1b9f89d3mr21027366b.31.1774434771237; Wed, 25 Mar 2026 03:32:51 -0700 (PDT) Received: from foxbook (bfk214.neoplus.adsl.tpnet.pl. [83.28.48.214]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335de16csm782729666b.41.2026.03.25.03.32.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 25 Mar 2026 03:32:50 -0700 (PDT) Date: Wed, 25 Mar 2026 11:32:46 +0100 From: Michal Pecio To: Mathias Nyman Cc: Mathias Nyman , Greg Kroah-Hartman , Xu Rao , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: xhci: Fix debugfs bandwidth reporting Message-ID: <20260325113246.07681667.michal.pecio@gmail.com> In-Reply-To: References: <20260304114928.110be4c4.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 19 Mar 2026 23:04:38 +0200, Mathias Nyman wrote: > On 3/4/26 12:49, Michal Pecio wrote: > > Replace kernel USB speed numbers with xHCI protocol IDs expected by HW. > > They are numerically equal up to high speed, but instead of SuperSpeed > > we were querying SuperSpeed+. > > > > Gen1 hardware rejects such commands with TRB Error, which resulted in > > zero available bandwidth being shown. > > > > While at that, report command failure as IO error, not zero bandwidth. > > > > Signed-off-by: Michal Pecio > > Added to queue Hi, Thanks for taking the patch, but can we have a last minute swap for a v2 or optionally v3? Problem is that returning -EIO is common (the command is optional) and it upsets userspace: "grep -r" spams the console with errors, "zip -R" terminates and doesn't include remaining files, etc. So I would prefer to print an error string in this case. "Real" errors will still be returned ordinarily. The optional v3 also renames the new directory for consistency. Technically it's a breaking change, but I believe it's permissible in debugfs, particularly for an interface only added recently. Regards, Michal