From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C78893537C3 for ; Wed, 25 Mar 2026 19:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466150; cv=none; b=qbUmHkkdSfywDEEhQeODXo2bD7Nhhq9jZC24ntTbEDdwSCCGZLO9BaPCaZSJmxkigPpMjqsYvRCfYbgBVyXIOcfFYu80176g95Kefbcys2tNWAIK+n3foZfyzga1HRFEPvlUviXSOPE9Z3rt3SWgE8xRicCsPjyLWrpyO1ewE50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466150; c=relaxed/simple; bh=WgV5itUbMScFnVYRiBUqTFqjA/vAu0irE/RDNqR82bw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=l47B6wRx2bh5/zoBMzEneGR+bhVJs6oQmO80dvgTWDSumTNuZw0WdGh02nUpszfahe3oik9T42PeeLBFphVyAaM2+uW0XHyfSRI8t8g7Jo8iNwHaAzmjBYdgdMGnqYnBkwBwL9t1hwm3pFof2N5CR4tnnrjKEJoi4+x5bpAEAw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=mXG8lv54; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="mXG8lv54" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5F5C2BC9E; Wed, 25 Mar 2026 19:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774466150; bh=WgV5itUbMScFnVYRiBUqTFqjA/vAu0irE/RDNqR82bw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mXG8lv54J8Q6XmPk3LXTPOG3VI8V/rho1NeKuZ9CpnskLZfdfF3PkLgkwR/c/zRWM OeZqaFvcDAdLdyS6DPoSj8K8NSUQLJUvO4K4Bt4IVnUA3smAiqk1ayfS8BgU2kYEJ0 7FQ6ORJNyyrzP1LlZuxCfnNCgh2rbVvZNFmhbWXQ= Date: Wed, 25 Mar 2026 12:15:49 -0700 From: Andrew Morton To: "Lorenzo Stoakes (Oracle)" Cc: "David Hildenbrand (Arm)" , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-Id: <20260325121549.2b887a8a8c154d5bf8529ea9@linux-foundation.org> In-Reply-To: References: <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> <06c83e1b-d7ee-48d5-a5c4-faad39db2f53@lucifer.local> <20260325113650.fc6997e07a0a4ad0e46278d5@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Mar 2026 18:53:40 +0000 "Lorenzo Stoakes (Oracle)" wrote: > > [akpm@linux-foundation.org: fix spello, add comment] > > Link: https://lkml.kernel.org/r/20260220151500.13585-1-rioo.tsukatsukii@gmail.com > > Signed-off-by: Rio > > Cc: Joel Granados > > Cc: Petr Mladek > > Cc: Wang Jinchao > > Signed-off-by: Andrew Morton > > > > But these things are usually quite minor and the precipitating > > discussion can be found by reading the main Link:. > > > > > Maybe just directly squash the commits? > > > > Not understanding this proposal? > > I mean instead of having a separate commit for the fix, put that fix into the > patch before it and denote it with a footer as you put above. > > I guess that translates to what you do when you rebase and fold the fixes into > commits as you do now anyway. > > I don't see any reason not to do that right away, as really it's good to see the > combined change in one go for all practical purposes (if I resend, I'll be > combining work, if I can grab it from the tree and avoid a git rebase -i all the > better). OK. So what have we concluded here? Is it: if I get a -fix, I add that in the usual way, then temporarily fold it into the base patch and mail the result out for fyi. Then after I permanently fold the fix into the base and add the footer? If so, what's ?