From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA4D93CC9FE for ; Wed, 25 Mar 2026 12:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774443097; cv=none; b=TpapVrV0gIJe4F0p7qVkzhxBJSNiOKkv9TjeKN72UQdSDwGxVKx3/CsfkuiaG4eE/BaC/Nb1cfms8fLLtS1WILeNUHr3VbtF+EQt9t5CBbMh+884vHCst0ytrzCIBPh725qUUXltvKMpAAUfOB3tjVgS00d/g69XONs/PGJtDvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774443097; c=relaxed/simple; bh=t+Mmq97q0+Y4r7U9kkN220HidCPG3ilvBfQAl/C7/c0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZryyE/InzfG8gJqqinzlDW4iC0KAGPVUujiYTNgGhuoXw8waMVRf6zrpCXmEZEyymPFDhju8U2kmv2bnCyW3H+CCd8fwjAlJ6CDEB3lt/fahw0c0ikjYk7DQxwWR9o99uTeKY2knekrLf3Z+Eloa+jfQ619zGWpd/VzYSK5NNCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PfPuW1QA; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PfPuW1QA" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso5319859f8f.1 for ; Wed, 25 Mar 2026 05:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774443094; x=1775047894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1+00FPqAZdZFOBnToh7PSc/BbUeRaxTEXoOHmtGunL0=; b=PfPuW1QAkcf5+sYEU+pMiIaSaKKode9mgkyiKMlXM5bw/Vb++Wquc8YBAwBf6+kA/y NjKjJsZ6TkN25FXWE3920/Sf8is18aSEJTD7zE8yux+I/t7zRI5v3TtIH1WFBV0Pb6y9 7RCEacegcECAvlpGaXXRcnh7/NJBTZ9vrS8oVrgaVPHEqq39wUFzTFcYFcyPXC/ZW5c0 pHNn9jPkRT07UJiv0zpKrDxa7JVCmAQXAbo3H5qTfszhvhuwpN0Xeh6un38QD4ziL7/6 sEWIiTijjyHzfLOygmB6xNbkCiZbvvEsp9yfipSsoYOcLswIe+6myD2q63oakvTJdU1f k7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774443094; x=1775047894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1+00FPqAZdZFOBnToh7PSc/BbUeRaxTEXoOHmtGunL0=; b=eEJcl+5FkdyBF91pLOUbg6i/S+IO8baTn5yf7m0ROiPMzc7Pj+3z6oczXpMKZ9mL6T HFUVNrI2NYM1d4eMAqBdlyWI+Pxvcambsul4qmgFtWB80IXYBPw4jluKRW6VTCiPffnT azW2N+/U05qb+LpU4giKQvTRl3pvac4WA8KLzfOaNnKzHxZolFK6q3Tzwy9DdNOyXh+w ygJr0ixkofJ7aqRlZcvtAUEpBNFu5eoamV8yrxTv8jHyhkcDyd0UpAwuZud+zfrX0FkG t+94KW4sfiFBzha5AVldztduLQytd30cDOL25NGhY95IJXTiuHmdhNcFktqiJfXr32CN VtYg== X-Forwarded-Encrypted: i=1; AJvYcCV0Fqaa3GSK05+i2+sy8BEZcPumCR4fHPlToNP8c3iXDlLtkVBHUkRfpC8n8mJghbcgsQ3j9WAdPOskjAA=@vger.kernel.org X-Gm-Message-State: AOJu0YyfueZONauxzysPDgSosbpate/KJOfzdyT12Qv+SJBgBLFsEFrI n4a935gFURYUm5rMlagvQP3G9WysrJDmxUZ0boXJycnEgfS/GKlwM/hO X-Gm-Gg: ATEYQzxqUo7RjOSmeUIB9u7ihrFu8dCVgjugiSOsSt3MGqJHwb7s3pnNEsMsZXCi5pm Gm+xcCZlTw2c/TZ1H5VNVGTTPmJdMu/FQTL1O3QaSM6UaR/0yken26TKYwJ4wy+kMxZQgaBk+bn CaJ2mbbhvcY8TDvTeLER96tp/K5E2O+w5e1XMrY/BZkGriEXILJfPkZUQxKc03pKNXsztYvp0mP kqnUjg31b2Cffw0wJm4qQKgE/3TY+l1QoByNycZiBMS/3aqAfT4gfyFu1NVAPGtxVXhXun6px0R kQsIQtdlpDywyFH7wT/MhcOuhNW0vDF0pLzjhi/PMNZpcGIBh7TWB6u2PGKwJi1IdC5YLDC3xwP Ae9elVV7M8rduVF9RGM0gsFZoKvWH4sWl0mH3nobBaX4q5r+i04UiQthn2pwjTO5rAxRzeO84z2 ke87PoaB8BXejqDQqGFwqj4XlIJ7Up7V1vPAQa0T2cyWJcqKg96yzmWcfBMMNkbYL9MB/PDtS5P 1zfqf25f2cq X-Received: by 2002:a5d:5d07:0:b0:43b:4ec7:f924 with SMTP id ffacd0b85a97d-43b88a05423mr4922876f8f.34.1774443093930; Wed, 25 Mar 2026 05:51:33 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b90f170dfsm543125f8f.5.2026.03.25.05.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 05:51:33 -0700 (PDT) From: David Carlier To: danishanwar@ti.com, rogerq@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: m-malladi@ti.com, jacob.e.keller@intel.com, horms@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] net: ti: icssg-prueth: fix missing data copy and wrong recycle in ZC RX dispatch Date: Wed, 25 Mar 2026 12:51:30 +0000 Message-ID: <20260325125131.53399-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit emac_dispatch_skb_zc() allocates a new skb via napi_alloc_skb() but never copies the packet data from the XDP buffer into it. The skb is passed up the stack containing uninitialized heap memory instead of the actual received packet, leaking kernel heap contents to userspace. Copy the received packet data from the XDP buffer into the skb using skb_copy_to_linear_data(). Additionally, remove the skb_mark_for_recycle() call since the skb is backed by the NAPI page frag allocator, not page_pool. Marking a non-page_pool skb for recycle causes the free path to return pages to a page_pool that does not own them, corrupting page_pool state. The non-ZC path (emac_rx_packet) does not have these issues because it uses napi_build_skb() to wrap the existing page_pool page directly, requiring no copy, and correctly marks for recycle since the page comes from page_pool_dev_alloc_pages(). Fixes: 7a64bb388df3 ("net: ti: icssg-prueth: Add AF_XDP zero copy for RX") Signed-off-by: David Carlier --- drivers/net/ethernet/ti/icssg/icssg_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/icssg/icssg_common.c b/drivers/net/ethernet/ti/icssg/icssg_common.c index fd4e7622f123..a28a608f9bf4 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_common.c +++ b/drivers/net/ethernet/ti/icssg/icssg_common.c @@ -902,6 +902,7 @@ static void emac_dispatch_skb_zc(struct prueth_emac *emac, struct xdp_buff *xdp, skb_reserve(skb, headroom); skb_put(skb, pkt_len); + skb_copy_to_linear_data(skb, xdp->data, pkt_len); skb->dev = ndev; /* RX HW timestamp */ @@ -912,7 +913,6 @@ static void emac_dispatch_skb_zc(struct prueth_emac *emac, struct xdp_buff *xdp, skb->offload_fwd_mark = emac->offload_fwd_mark; skb->protocol = eth_type_trans(skb, ndev); - skb_mark_for_recycle(skb); napi_gro_receive(&emac->napi_rx, skb); ndev->stats.rx_bytes += pkt_len; ndev->stats.rx_packets++; -- 2.53.0