From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA05023BCFD for ; Wed, 25 Mar 2026 20:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774471798; cv=none; b=bQuUduzIpJBv/NjAIWHZYCr4l1BJQOUCOpjyfPKjiIkb6uHJ3oCC3w5JVn4q+iqp/6xRVes6LO9Mce4HPUvNFggbjg7+fznOoXRw3DQIstXtR+wK3CfFXjpdQE72WeaXFuqpDTtNoX35lW3/bDX08PHRgnii6GtBxCuNjA45Urs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774471798; c=relaxed/simple; bh=12gWYwz5+UXNYe/GprR8bIjp7XZsuOCyWF6dzqhGQgs=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=YdmtQRRNelF/zUvgvOwv1/UKy8pxH0HhhZPIqu7prIcyWLVPwhrNkT9NrOkAt8lwK2wLYedZjyWxJHitSTtfy8k58Iro5P5gaFcrlfcSaiOiG6qAa+ewOO7KYLSaS6nZ01eez8bMtjgBMSEZk5PWC2Jt0TIaDemuY8FkoxNL78M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gppLDZ0v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gppLDZ0v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CE30C4CEF7; Wed, 25 Mar 2026 20:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774471797; bh=12gWYwz5+UXNYe/GprR8bIjp7XZsuOCyWF6dzqhGQgs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gppLDZ0vI9UUtn6MhYJMTujUQ4p8ZgNZMcHSfqeyZlJAB2FxSUKXGOCdge0xcuU4w QBHBp6LX4BHGdYiYk6pRJ/E9xIbk24RAnwIDsyNtcSpiKpQcUIURogQ5qxGFPxurSl 8y9/PUMDxd6fcoKABFgWXVaIxQZQLG3VLEfi+4DQ= Date: Wed, 25 Mar 2026 13:49:56 -0700 From: Andrew Morton To: "David Hildenbrand (Arm)" Cc: "Lorenzo Stoakes (Oracle)" , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-Id: <20260325134956.0ceceb29a77fb367d657815b@linux-foundation.org> In-Reply-To: <93f3be43-0883-4fde-86c2-a35f8a9c999c@kernel.org> References: <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> <20260325091735.bf440358cf83c5d0369e0674@linux-foundation.org> <06c83e1b-d7ee-48d5-a5c4-faad39db2f53@lucifer.local> <20260325113650.fc6997e07a0a4ad0e46278d5@linux-foundation.org> <20260325121549.2b887a8a8c154d5bf8529ea9@linux-foundation.org> <9930979b-7bab-430b-ad29-fb35f36712b6@lucifer.local> <93f3be43-0883-4fde-86c2-a35f8a9c999c@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Mar 2026 21:16:11 +0100 "David Hildenbrand (Arm)" wrote: > On 3/25/26 21:03, Lorenzo Stoakes (Oracle) wrote: > > On Wed, Mar 25, 2026 at 12:15:49PM -0700, Andrew Morton wrote: > >> On Wed, 25 Mar 2026 18:53:40 +0000 "Lorenzo Stoakes (Oracle)" wrote: > >> > >>> > >>> I mean instead of having a separate commit for the fix, put that fix into the > >>> patch before it and denote it with a footer as you put above. > >>> > >>> I guess that translates to what you do when you rebase and fold the fixes into > >>> commits as you do now anyway. > >>> > >>> I don't see any reason not to do that right away, as really it's good to see the > >>> combined change in one go for all practical purposes (if I resend, I'll be > >>> combining work, if I can grab it from the tree and avoid a git rebase -i all the > >>> better). > >> > >> OK. So what have we concluded here? > >> > >> Is it: if I get a -fix, I add that in the usual way, then temporarily > >> fold it into the base patch and mail the result out for fyi. Then > >> after I permanently fold the fix into the base and add the > >> footer? > >> > >> If so, what's ? > > > > To me it feels like that should be 0, just squash it in right away, OK... > since the trees are being rebased constantly right? yup, the mm-*_unstable branches and mm-new are blown away and rebuilt from quilt each time. And the quilt patches are rediffed and refreshed during this. > > And that means the tree contains exactly what it would if the series were > > re-sent. > > > > David, what do you think? > > How often was it helpful that a fixup patch would stay separate? I would > assume "not often". :) Not often. Sometimes a -fix is messed up and we grow a -fix-fix. The record is something like -fix-fix-fix-fix-fix. I suppose there's slight value in tracking this for a while. Not much though.