From: Andrew Morton <akpm@linux-foundation.org>
To: Yury Norov <ynorov@nvidia.com>
Cc: Thomas Gleixner <tglx@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Alice Ryhl <aliceryhl@google.com>,
Viktor Malik <vmalik@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
David Laight <david.laight.linux@gmail.com>,
linux-kernel@vger.kernel.org,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection
Date: Wed, 25 Mar 2026 16:31:38 -0700 [thread overview]
Message-ID: <20260325163138.d3e2c41dd3ed8a96c4801507@linux-foundation.org> (raw)
In-Reply-To: <20260325163313.749336-1-ynorov@nvidia.com>
On Wed, 25 Mar 2026 12:33:10 -0400 Yury Norov <ynorov@nvidia.com> wrote:
> Christophe has pointed in [1] that one my patch incorrectly defines
> rust_helper__copy_to_user() wrapper based on INLINE_COPY_FROM_USER.
>
> Having separate controls for 'from' and 'to' versions is pretty useless,
> and has proven to be error prone. So, instead of fixing the rust portion,
> simply switch the kernel to a single knob.
>
> [1] https://lore.kernel.org/all/746c9c50-20c4-4dc9-a539-bf1310ff9414@kernel.org/
Some changelog whining:
As this series is aimed at mainline inclusion, I don't see much value
in changelogging which refers to previous development versions of the
patchset. That's useful material to include below the ^---$ separator,
but it isn't of interest to our target audience: people who are reading
this patchset three years hence.
So can we please have a clean description of what this patchset does and
why it does it?
Also, [1/2] says
Fixes: 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST")
but I'm not actually seeing a description of what was wrong with
1f9a8286bc0c. Can we please have a description of the motivation in
here somewhere?
prev parent reply other threads:[~2026-03-25 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:33 [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-03-25 16:33 ` [PATCH 1/2] " Yury Norov
2026-03-26 13:44 ` Christophe Leroy (CS GROUP)
2026-03-26 17:29 ` Yury Norov
2026-03-26 17:49 ` Christophe Leroy (CS GROUP)
2026-03-25 16:33 ` [PATCH 2/2] uaccess: minimize INLINE_COPY_USER-related ifdefery Yury Norov
2026-03-26 8:00 ` Alice Ryhl
2026-03-26 14:15 ` Christophe Leroy (CS GROUP)
2026-03-25 23:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325163138.d3e2c41dd3ed8a96c4801507@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=chleroy@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@kernel.org \
--cc=vmalik@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox