From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B375B21A for ; Wed, 25 Mar 2026 18:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464734; cv=none; b=F2rKOZBZ42Ei4zrvk+YgUQFKK3/6t5VWBMs0Ms3UyzAC79t162CoJjXEEDKnGp3bUOmLmji4aOFwPRKAWnYIQJWH/bOx1YptczKEv4BhCAIZ/hr/zjPPtsWuCyAktvVFM5dE2TBenj/dmtiDOm5vkKnS7EjuTkeCFvPCr5odL64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464734; c=relaxed/simple; bh=k005s4T+Hn5vg1I4gy6UbS05z8cGKyZ423JY5oOj5eg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jviuJLQ1otVkBQagoUufpOcrGphkg3gZWoSjtJOSmCrgXrQNBtxhAqtjAaRZrrj/S2lnQJ3nIkZJd7/xgYMJUebDd3vP4ZiIP8XhIqhmsk0IJ09t6Z5BzhUN6+GryqDkHvDczu5+pmWsL1YLRSrhLGn8C64CrzpRllwWRnEGqtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=UxrmZbsM; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="UxrmZbsM" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2b4520f6b32so256997eec.0 for ; Wed, 25 Mar 2026 11:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1774464732; x=1775069532; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cCd8yAMvqrPDCDQ4w2+qNCSQcd/tOcYNFgI75BEKc2c=; b=UxrmZbsMnSjRs7R9tztgUVh9OGZYu19RrZebxaqxGk9wHTdAs1Rvc971Rf/riEAiuW pXqHvoU1myXuXipT0OJPL72A4recIhHR8tThEuu/grg2jgGkhFO5Spy7eETgQNNb7R+Y Nm94OQdBfNLnzbX/oYO7ao7xJLs/rFDnjgOwmBvfYvH+cIJEoFx0akEFQVtJbo4kzBvE Vf39hao3DPg8Ry4Tqo6iSYu93JV9PK/7QVfMIJs82RnUP6Tc/YCjAqapx9FRt1wmpMZM lBn3Q0+c7LNmyptGMGxT/1VIhepH8b2kTsGXfDLgRxZztWaKTiXtUkzlwrUnKXQG12zP cPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774464732; x=1775069532; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cCd8yAMvqrPDCDQ4w2+qNCSQcd/tOcYNFgI75BEKc2c=; b=je4ypYRLMZbXauocE6tWqCiD9ib/pVRls4pgDsGuqUZTrMs9vTMhx03LCxIJF83AYD g8Y0044B4xNOdUOGR0Updg0eIWN2/6uRNpCNNZVtfWZV9xjnGkYdYfGkqfjo1pkaHY7c oVEn31Xd39q2q6ixk3K2Dv7/pfCZ7So1yrOI//v44FECfDZljaWPJZpjc5wGEibz1y6I wc+Uhw18e3e9oogHaS6eNYJkE7T455jYSs0Co0Z3dIHslhOlxkAo5azLn0Ze9Rjl5SXn urHV5E4M8fytDHMAh5RnC9v5PKnd3Fb+/9WLxGc3STsCda+4S+5j4cmkTooe6HErAR6b dhjQ== X-Forwarded-Encrypted: i=1; AJvYcCUeSgF52G0qT0ZGRdHAsbp10KEsqtLIVxy4K5bkHHlOFAapl2cNSO1S88rvZzYzXlJN1avMJo+JcrL7+uY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzz0GzbVknZ9AY15zwc0IRexdZRVolgGi8+y4X+J5blMzxC2Pl q/2NRCGhYypvxzsezn4xcv5IPGBCjC2HfDOLhIMCJNZ36id3Xp1VqIfz7WE4DTUUPYs= X-Gm-Gg: ATEYQzyB79cwaxcvR1VneqQD7y5z6ankJcxHr04uB1Q07/G+MgST9s1GfYNKHq8xVU8 wAbwP2EgsU5/MzyslCCEpPFX4ejr15QSfTiPgpiEgt8iUGyeVXk9MHHCsbLoQSlnvP97BJBOzdU FIZM1g2ChMD3do2fl5z1M0nU6ZhX9ihFiAwTBo8iEQ+t4P551iGyjjEC+ZsAhChiFjK0+3EByxI uvIzAnMq0E8M9Ut6y5zlesrgtC+N7qB+SSUUXZCmP7XmOVk7l7qT0sg+TgvkCxrnfe5GaDUm0i7 LVXdx+CgJnHFdvqOgceRke9yNJSATTFxw5DjxGXNofOUwPB9HW0adK+yPFelvEDsiz3xkzbFlO1 ih3Nxo1DYERVvUchFEmuMH/88kf3PWc4M+2o3fncnAXVeB776U9XMklqMCQkB0m/Bg90pez0n+U fLPRpHQFSoEXX3b3cnkc7qcQukqSSH X-Received: by 2002:a05:7300:b505:b0:2ba:a60a:15e6 with SMTP id 5a478bee46e88-2c15d3db165mr2427284eec.16.1774464732357; Wed, 25 Mar 2026 11:52:12 -0700 (PDT) Received: from medusa.lab.kspace.sh ([2601:640:8202:6fb0::9c63]) by smtp.googlemail.com with UTF8SMTPSA id 5a478bee46e88-2c16ec277edsm761001eec.3.2026.03.25.11.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 11:52:11 -0700 (PDT) Date: Wed, 25 Mar 2026 11:52:10 -0700 From: Mohamed Khalfella To: Maurizio Lombardi Cc: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/21] nvmet: Implement CCR nvme command Message-ID: <20260325185210.GC145093-mkhalfella@purestorage.com> References: <20260214042753.4073668-1-mkhalfella@purestorage.com> <20260214042753.4073668-4-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 2026-02-27 17:30:29 +0100, Maurizio Lombardi wrote: > On Sat Feb 14, 2026 at 5:25 AM CET, Mohamed Khalfella wrote: > > Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller > > Reset) command is an nvme command issued to source controller by > > initiator to reset impacted controller. Implement CCR command for linux > > nvme target. > > > > + > > + new_ccr = kmalloc(sizeof(*new_ccr), GFP_KERNEL); > > + if (!new_ccr) { > > + status = NVME_SC_INTERNAL; > > + goto out_unlock; > > + } > > Nit: kmalloc_obj is now the preferred function for this kind of memory > allocations, see commit 69050f8d6d075dc01a and 189f164e573e18d > > scripts/checkpatch.pl is supposed to print a warning > but there must be a problem with the regex and doesn't catch it > Got it. Switched the allocation to use kmalloc_obj().