The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Inseob Kim <inseob@google.com>
Cc: linux-kernel@vger.kernel.org, changbin.du@gmail.com,
	jbaron@akamai.com, joe@perches.com,
	Josh Law <objecting@objecting.org>
Subject: Re: [PATCH v2] lib: parser: Fix match_wildcard to correctly handle trailing stars
Date: Wed, 25 Mar 2026 19:25:34 -0700	[thread overview]
Message-ID: <20260325192534.151e86e439e7e4080a630d4c@linux-foundation.org> (raw)
In-Reply-To: <20260326020630.4139520-1-inseob@google.com>

On Thu, 26 Mar 2026 11:06:04 +0900 Inseob Kim <inseob@google.com> wrote:

> This fixes a bug of match_wildcard that incorrectly handles trailing
> asterisks. For example, `match_wildcard("abc**", "abc")` must return
> true, but it returns false.
> 
> Signed-off-by: Inseob Kim <inseob@google.com>
> ---
> v2:
>   - Added Cc. No changes to the code.
> ---
>  lib/parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/parser.c b/lib/parser.c
> index 73e8f8e5be73..62da0ac0d438 100644
> --- a/lib/parser.c
> +++ b/lib/parser.c
> @@ -315,7 +315,7 @@ bool match_wildcard(const char *pattern, const char *str)
>  		}
>  	}
>  
> -	if (*p == '*')
> +	while (*p == '*')
>  		++p;
>  	return !*p;
>  }

Thanks, looks right.

We don't appear to have any selftesting for this code.

Should all of parser.c actually exist?  Some of it is a subset of
lib/glob.c?

  reply	other threads:[~2026-03-26  2:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  2:06 [PATCH v2] lib: parser: Fix match_wildcard to correctly handle trailing stars Inseob Kim
2026-03-26  2:25 ` Andrew Morton [this message]
2026-03-26  4:12   ` Inseob Kim
2026-03-26  4:45     ` Andrew Morton
2026-03-26  4:51       ` Inseob Kim
2026-03-27 10:11         ` Takaya Saeki
2026-03-27 15:17           ` Andrew Morton
2026-03-26  7:10   ` Josh Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325192534.151e86e439e7e4080a630d4c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=changbin.du@gmail.com \
    --cc=inseob@google.com \
    --cc=jbaron@akamai.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=objecting@objecting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox