From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: gaohan@iscas.ac.cn, alex@ghiti.fr, aou@eecs.berkeley.edu,
conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
pjw@kernel.org, rabenda.cn@gmail.com, robh@kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v2 4/4] riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2
Date: Thu, 26 Mar 2026 15:06:47 +0800 [thread overview]
Message-ID: <20260326070647-GKD777612@kernel.org> (raw)
In-Reply-To: <20260314080003.2573296-1-amadeus@jmu.edu.cn>
Hi Chukun, Han
I've merely checked the schematics..
On 16:00 Sat 14 Mar , Chukun Pan wrote:
> Hi,
>
> > + regulator-usb3-vbus-5v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "USB30_VBUS";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio K1_GPIO(97) GPIO_ACTIVE_HIGH>;
>
> Is this true?
GPIO97 should be DVL1 which labeled as CAMERA1_RST..
>
> > + enable-active-high;
> > + };
> > +
> > + usb3_hub_5v: regulator-usb3-hub-5v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "USB30_HUB";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
>
> Although GPIO123 is labeled as USB_HUB_EN, it actually
> supplies for USB3 vbus.
>
I agree
> > + enable-active-high;
> > + };
>
> > ...
> > + peer-hub = <&hub_3_0>;
> > + reset-gpios = <&gpio K1_GPIO(124) GPIO_ACTIVE_LOW>;
>
> Really? GPIO124 is floating.
>
Right, GPIO123 doesn't connect to any device
check the reset pin of GL3523, it connect to VCC_5V0 which is pulled high
unconditionally..
> > + };
>
> I still insist that the regulator name of DT should be the same
> as on the schematic. This will force us to review the schematic.
>
> Thanks,
> Chukun
Also, it seems the VCC5V0_USB20 is missing too, which controlled by
pin USB0_OTG_EN -> GPIO126
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-03-26 7:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 16:18 [PATCH v2 0/4] riscv: dts: spacemit: Add PMIC regulators usb pcie Han Gao
2026-03-10 16:18 ` [PATCH v2 1/4] riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2 Han Gao
2026-03-10 16:18 ` [PATCH v2 2/4] riscv: dts: spacemit: Define fixed regulators " Han Gao
2026-03-13 0:06 ` Yixun Lan
2026-03-13 0:30 ` Yixun Lan
2026-03-10 16:18 ` [PATCH v2 3/4] riscv: dts: spacemit: Define the P1 PMIC " Han Gao
2026-03-10 16:18 ` [PATCH v2 4/4] riscv: dts: spacemit: Enable USB3.0/PCIe on " Han Gao
2026-03-14 8:00 ` Chukun Pan
2026-03-26 7:06 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326070647-GKD777612@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox