From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52EB03B6C12 for ; Thu, 26 Mar 2026 08:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513118; cv=none; b=DzDD9NmDjgJRJhYijQu8/v4d7ssW0abl74K18nn5KNRSLEIbiy4xjLvV7CJLRlGhaRi38xPeKAyTOrGFzzOAlJr3h0DXtfLGPOEUWsY7IoImwr3V7KrlccvhIgm5CY1TwVi4/SE3usGaaNO0HRpmDbKBJq6lPZ/MZiKZ3SA7V00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513118; c=relaxed/simple; bh=MxPsp8s+hkkaqO9oaOaJywPlY2kic8FP8cMpRg6+G3c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SiKfmwLvkPkSjVfr+SM0WCGN18mlUs3a9deyIvRDYu0YyB9CGpNgukvXvjCvjEqT5eMMh44cQU6V7nS643WHrTLmI7mZHhu9Nmg+Zc3LQSD1nYTK2GcWE+PC6eL0/UdmBgefkHWjjtz/8tMtgs+4TsOy73r9IrnXsOfb+f5M8nE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KGuKQriU; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KGuKQriU" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so5649875e9.1 for ; Thu, 26 Mar 2026 01:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513116; x=1775117916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oAbYppiZpmge0WeV6Gd5Zu+YQlF0WZiCB4L+XT8hXWQ=; b=KGuKQriUIE7o4WNJDf/NFtSyj7bExPYGlwEMsHHe7Uuq+6lHUaRolFy6BFS0O7DFPh XR1KPLBDwNpF4Y3JE/nFI8c3w0VhCYcDjdrHjbooZt820Kqf0Nh98NFtQgqpj2BGATWK Jd/eJA67kfzJ+reToI/pYxeqiecCaaRSgpNoBBB2sI8CVcj4jLwbUotswm5PVe5mxW1n VviUm1mldgfn/XRsB2mrnIhCqCppZvgRQdo06LgW2WAF8KVPlCW0mEd3G2wTnpnTlggz dDEzrnG6+SojIPqKb8NWkGPU2udiPh3RX7S4PojGvXsn2pYSYrSfLIe0TmeGmi4dpIrd yTZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513116; x=1775117916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oAbYppiZpmge0WeV6Gd5Zu+YQlF0WZiCB4L+XT8hXWQ=; b=m/7ZBZNYeVJq8Pw9Ji+WZHSykJd2relkCvB3NWcGZJYSmFXYyHmTqaeKkeh+r/oZdN dPzrI5WkTreWT8oSd9k0YIIw23uZzucAlvO2RueosOm1nyKV6wI8T12Oj5X3/WhcA2H4 KCIZxqpe2EF4w9o0AqgTWFXUAs5/OwQ9bzuMV1oWOkSEUkTFlcl8Lz0tKfjHtHLY65V3 SEG7XFpO5tqw1rQ44AXlDbI/31Re6xupHYox61O4co5zhaPq6Sjk6oFaIgF/SVLenx33 dkHO3uhf+oi3ylq0rjG+LTINBCN0gbSSq1GzOoVr/1Ct0zOy6tC2Va28cxnp+lbRbKHO WMHQ== X-Forwarded-Encrypted: i=1; AJvYcCWmWniQ42uGO9zlbO1z1BzPRc0uPbJ6m1pUoK81mxVWxQoM8wesFxF8eYgC357JY08y0iAlf+mlZ+MibVM=@vger.kernel.org X-Gm-Message-State: AOJu0YwK+fZ+1g6ZGEshEMhfEl/BFVpm1F65nt/wPo3n0V4vqUYkYQ4B i5LVd3dgNPE+hwE1rQ2R/K+WKRocPrNYfXiHK6V+zWWxq9+2zfI2ary1 X-Gm-Gg: ATEYQzxgia2waptEXxKMf+zZl0KoRQAig2YKmfTOhs+tX3PyBQBRYsOBYC/B5cn7DAA 8NarKsRsW6t9cO5gW+Z2lvaJ+oaVC3Bvqm3avSgmbpP2gr35QV1KWTK5Ag1q5ctKjE/cYrvLXXR Ze2lOOs6ghC/WXfb2uIEQmsKBH1VDc1gmQ6ICJZPNozAVcnpwRGz+TbHX47jdQ09ILY0tKW8D3t cYAiCouNpc6r9s6URlnFd+w27cIw+hh3e4+zl9bm6Er6WdI2GANXTkWhBdAah6yBHddrCn5BTZJ z+NdN+NpctH9nDObjoqqnCMHGidLfFWalEOXn+tkheSs3rZetVAv4RwaXzo68vVK1brblWNUyz5 +i2s2iFqSXTvN0su7bs6v0cvGX9/1tQopddBkWVGeHTWddiwh4zjJxTXQ/VUjKYiK/FfQJPZhH+ zGd1A6+cL6ZUwKJbof086d41Y= X-Received: by 2002:a05:600c:19d3:b0:486:fbc4:8fdb with SMTP id 5b1f17b1804b1-48722be4732mr12013465e9.11.1774513115608; Thu, 26 Mar 2026 01:18:35 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:35 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 0/4] clean up error handling Date: Thu, 26 Mar 2026 09:18:24 +0100 Message-ID: <20260326081828.6314-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260324220453.47406-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series lets sdio_init() propagate standard kernel error codes instead of returning _SUCCESS/_FAIL. There are two callers for this function. rtw_resume_process_normal() already returns negative values but the caller doesn't check for errors so changing this doesn't affect anything. sdio_dvobj_init() returns NULL on error so leave that as-is. Signed-off-by: Omer El Idrissi --- v3: - Add one commit that lets sdio_dvobj_init() use more readable error handling - Add v3 and v2 tags v2: - Add one commit that lets rtw_resume_process_normal cleanly check errors and return errno instead of using vendor-defined slop v1: - Use direct returns in sdio_dvobj_init() - Cleanup return in sdio_init() Omer El Idrissi (4): staging: rtl8723bs: use direct returns in sdio_dvobj_init() staging: rtl8723bs: cleanup return in sdio_init() staging: rtl8723bs: clean up callees for sdio_init function staging: rtl8723bs: Choose slightly more readable error check drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++---- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 25 ++++++++------------ 2 files changed, 14 insertions(+), 19 deletions(-) -- 2.51.0