From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884993FF8B1; Thu, 26 Mar 2026 15:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774539884; cv=none; b=CdH0RU/5ghrGn5U//UFzg1koCGgtNn0M3RfSoiIqp1EyyU+zJ/qN6Bxw3aJgcg8eFTQOASR5p/RIo3XnBK3+hFVfqELNFFKGl0GqtjRZOoYa5UN87aXh3KzMFYYKQZAAQ6/VQLJ0Ptfc6xOtOFeL3Dboq5Avw1X/tV4VK39T1j8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774539884; c=relaxed/simple; bh=fegKwxX/JUwCF2Lx6tujwh9Zba20d9CylFdb5bDXNpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I9gSdQ+rkI0iEllqhH134dbFu75ReuVykSAe5b4hMSEpfdnkYxPGD1msLJvT9Kj8yyMTh8hbTw7qRLsk1PGVDSG3mnoRMdycy/rrS09du8l1JNB2yVgwaNDDJkkPP7QOkJpsyX67EH6udV4uuP70fN/xDa+7LrBIyKoWLowP+bQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=FJppiSpM; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FJppiSpM" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id A7AD7C56687; Thu, 26 Mar 2026 15:45:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 59680601FA; Thu, 26 Mar 2026 15:44:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D012C10450519; Thu, 26 Mar 2026 16:44:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774539877; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=LkNoR3D4UbafRdhgG19imB15t8UnwV/2QMs/xxLmVyU=; b=FJppiSpMFzTcwEj8BcylcxckqdLi3AAFThxTsgjf1VxD813E3aBkMGWgw/R8+eBpwILq49 SIqEMogdAM0hHIpYOqpvRet+87Z47SIG9H9zRGzztKEagjZGSc4jC99LV/pEPGmnmE2hFR j0aicGJlzLGjkOyveHO/MPNtvWTEuOVTmXN354hbJc3sOB2XwIbuNT8VMVJ7XwtFWFcCiX WpySGxQl2dLbAeHYterMB/py0EmGIPFEY/G0Dr2QHaPgWHusv9ZuoJeS5EFUE01picFt2j WdKopCMVh7tFY8NZVxQFvXnJXyafnRHn+K9a5syQrIxj5hxsj0ZHxN/KF4wAqg== Date: Thu, 26 Mar 2026 16:44:31 +0100 From: Alexandre Belloni To: Rob Herring Cc: Conor Dooley , Akhil R , Frank Li , Krzysztof Kozlowski , Conor Dooley , "Rafael J . Wysocki" , Robert Moore , Len Brown , Guenter Roeck , Philipp Zabel , Eric Biggers , Fredrik Markstrom , Miquel Raynal , Thierry Reding , Jon Hunter , Suresh Mangipudi , linux-tegra@vger.kernel.org, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-hwmon@vger.kernel.org Subject: Re: [PATCH 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA Message-ID: <202603261544313f63018c@mail.local> References: <20260318172820.13771-1-akhilrajeev@nvidia.com> <20260318172820.13771-2-akhilrajeev@nvidia.com> <20260318-tweed-herbicide-eb924ef056b8@spud> <20260326150503.GA2360967-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326150503.GA2360967-robh@kernel.org> X-Last-TLS-Session-Version: TLSv1.3 On 26/03/2026 10:05:03-0500, Rob Herring wrote: > On Wed, Mar 18, 2026 at 05:31:50PM +0000, Conor Dooley wrote: > > On Wed, Mar 18, 2026 at 10:57:14PM +0530, Akhil R wrote: > > > Add the 'mipi-i3c-static-method' property mentioned in the MIPI I3C > > > Discovery and Configuration Specification [1] to specify which discovery > > > method an I3C device supports during bus initialization. The property is > > > a bitmap, where a bit value of 1 indicates support for that method, and 0 > > > indicates lack of support. > > > Bit 0: SETDASA CCC (Direct) > > > Bit 1: SETAASA CCC (Broadcast) > > > Bit 2: Other CCC (vendor / standards extension) > > > All other bits are reserved. > > > > > > It is specifically needed when an I3C device requires SETAASA for the > > > address assignment. SETDASA will be supported by default if this property > > > is absent - which means for now the property just serves as a flag to > > > enable SETAASA, but keep the property as a bitmap to align with the > > > specifications. > > > > > > [1] https://www.mipi.org/specifications/disco > > > > > > Signed-off-by: Akhil R > > > --- > > > .../devicetree/bindings/i3c/i3c.yaml | 30 ++++++++++++++++--- > > > 1 file changed, 26 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml > > > index e25fa72fd785..1705d90d4d79 100644 > > > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml > > > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml > > > @@ -31,10 +31,12 @@ properties: > > > described in the device tree, which in turn means we have to describe > > > I3C devices. > > > > > > - Another use case for describing an I3C device in the device tree is when > > > - this I3C device has a static I2C address and we want to assign it a > > > - specific I3C dynamic address before the DAA takes place (so that other > > > - devices on the bus can't take this dynamic address). > > > + Other use-cases for describing an I3C device in the device tree are: > > > + - When the I3C device has a static I2C address and we want to assign > > > + it a specific I3C dynamic address before the DAA takes place (so > > > + that other devices on the bus can't take this dynamic address). > > > + - When the I3C device requires SETAASA for its discovery and uses a > > > + pre-defined static address. > > > > > > "#size-cells": > > > const: 0 > > > @@ -147,6 +149,26 @@ patternProperties: > > > through SETDASA. If static address is not present, this address is assigned > > > through SETNEWDA after assigning a temporary address via ENTDAA. > > > > > > + mipi-i3c-static-method: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + minimum: 0x1 > > > + maximum: 0xff > > > + default: 1 > > > + description: | > > > + Bitmap describing which methods of Dynamic Address Assignment from a > > > + static address are supported by this I3C Target. A bit value of 1 > > > + indicates support for that method, and 0 indicates lack of support. > > > > I really am not keen on properties that are bitmaps, why can't we just > > use the strings "setdasa", "setaasa" etc? > > If this comes from a specification, then I'd tend to just copy it rather > than invent our own thing. Obviously if is something structured > fundamentally different from how DT is designed, then we wouldn't. But > this is just a simple property. > The issue being that the specification is not public so it is difficult to take any decision. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com