* [PATCH next] tracing: Remove spurious default precision from show_event_trigger/filter formats
@ 2026-03-26 20:18 david.laight.linux
2026-03-27 0:37 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: david.laight.linux @ 2026-03-26 20:18 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel, Aaron Tomlin
Cc: David Laight, Petr Mladek, Rasmus Villemoes, Andy Shevchenko,
Sergey Senozhatsky, Andrew Morton
From: David Laight <david.laight.linux@gmail.com>
Change 2d8b7f9bf8e6e ("tracing: Have show_event_trigger/filter format a bit more in columns")
added space padding to align the output.
However it used ("%*.s", len, "") which requests the default precision.
It doesn't matter here whether the userspace default (0) or kernel
default (no precision) is used, but the format should be "%*s".
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
kernel/trace/trace_events.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 249d1cba72c0..6b54c10f9ba4 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1718,7 +1718,7 @@ static int t_show_filters(struct seq_file *m, void *v)
len = get_call_len(call);
- seq_printf(m, "%s:%s%*.s%s\n", call->class->system,
+ seq_printf(m, "%s:%s%*s%s\n", call->class->system,
trace_event_name(call), len, "", filter->filter_string);
return 0;
@@ -1750,7 +1750,7 @@ static int t_show_triggers(struct seq_file *m, void *v)
len = get_call_len(call);
list_for_each_entry_rcu(data, &file->triggers, list) {
- seq_printf(m, "%s:%s%*.s", call->class->system,
+ seq_printf(m, "%s:%s%*s", call->class->system,
trace_event_name(call), len, "");
data->cmd_ops->print(m, data);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] tracing: Remove spurious default precision from show_event_trigger/filter formats
2026-03-26 20:18 [PATCH next] tracing: Remove spurious default precision from show_event_trigger/filter formats david.laight.linux
@ 2026-03-27 0:37 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2026-03-27 0:37 UTC (permalink / raw)
To: david.laight.linux
Cc: Steven Rostedt, Mathieu Desnoyers, linux-kernel,
linux-trace-kernel, Aaron Tomlin, Petr Mladek, Rasmus Villemoes,
Andy Shevchenko, Sergey Senozhatsky, Andrew Morton
On Thu, 26 Mar 2026 20:18:24 +0000
david.laight.linux@gmail.com wrote:
> From: David Laight <david.laight.linux@gmail.com>
>
> Change 2d8b7f9bf8e6e ("tracing: Have show_event_trigger/filter format a bit more in columns")
> added space padding to align the output.
> However it used ("%*.s", len, "") which requests the default precision.
> It doesn't matter here whether the userspace default (0) or kernel
> default (no precision) is used, but the format should be "%*s".
>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
> Signed-off-by: David Laight <david.laight.linux@gmail.com>
> ---
> kernel/trace/trace_events.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 249d1cba72c0..6b54c10f9ba4 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -1718,7 +1718,7 @@ static int t_show_filters(struct seq_file *m, void *v)
>
> len = get_call_len(call);
>
> - seq_printf(m, "%s:%s%*.s%s\n", call->class->system,
> + seq_printf(m, "%s:%s%*s%s\n", call->class->system,
> trace_event_name(call), len, "", filter->filter_string);
>
> return 0;
> @@ -1750,7 +1750,7 @@ static int t_show_triggers(struct seq_file *m, void *v)
> len = get_call_len(call);
>
> list_for_each_entry_rcu(data, &file->triggers, list) {
> - seq_printf(m, "%s:%s%*.s", call->class->system,
> + seq_printf(m, "%s:%s%*s", call->class->system,
> trace_event_name(call), len, "");
>
> data->cmd_ops->print(m, data);
> --
> 2.39.5
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-27 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-26 20:18 [PATCH next] tracing: Remove spurious default precision from show_event_trigger/filter formats david.laight.linux
2026-03-27 0:37 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox