From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B68A8302767; Thu, 26 Mar 2026 20:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774556655; cv=none; b=hnkN3a9IATXT+BeLINNQeS/gx6tsOkUhdFFbAIcnjOsNyVsMsfxf0j/qNVwc3h1HPzzUfm2bkeMwKd35DZKQn4ZQb5a236o2KFALmMx695jlZ/mmFdBiFkXKEYG7ldpHSxbbYkumIu7+Z8W00utNUxa1HhZbaobf3CxMRCup/RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774556655; c=relaxed/simple; bh=NVhX/uMxZkpkB/iqDu5JZGx9lhZ9UdPlPo1XBRq95bg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=miN1kzYxX2o2PJ7kas91U7eJ+ooojyOoOAalSX4meBhxvZPw2ZEVV6W1QYXBAFuMLnvcxgJYDjBo76VNbbsW/RMhHMdjqkogxTiYVhMOeKTg/dPQnLMACXUNNEX1j7kRjcbKSGQhC/ASPwaFRyrrs+U9NyruSNosQR/otVxh+XU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=mNeN+YLD; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mNeN+YLD" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ECF6EC59; Thu, 26 Mar 2026 21:22:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774556572; bh=NVhX/uMxZkpkB/iqDu5JZGx9lhZ9UdPlPo1XBRq95bg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mNeN+YLDfw3MuX2TA+viY+TKCOWX3G9bMqKE64cCBilShGkf6X2SAvRqbSZ2O4tRD q5UjEYFaWlqDio3pkykZVhoVjQbxTeo3RWBFlcO4jIRyCOK/tMt15o9jTEoHODLBCw 6gTsI4IWQgepC2mxAcjm/5zuryn6gDno7q/hl6uY= Date: Thu, 26 Mar 2026 22:24:09 +0200 From: Laurent Pinchart To: Amin GATTOUT Cc: Tomi Valkeinen , Kieran Bingham , Maarten Lankhorst , Maxime Ripard , Luca Ceresoli , Thomas Zimmermann , David Airlie , Simona Vetter , Geert Uytterhoeven , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rcar-du: Convert to of_drm_find_and_get_bridge() Message-ID: <20260326202409.GE2770072@killaraus.ideasonboard.com> References: <20260326-bridge-v1-1-c0c44b53f7b6@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260326-bridge-v1-1-c0c44b53f7b6@gmail.com> Hello Amin, On Thu, Mar 26, 2026 at 09:10:15PM +0100, Amin GATTOUT wrote: > of_drm_find_bridge() is deprecated. > Replace it with of_drm_find_and_get_bridge() which increments > the bridge refcount as required. > > Signed-off-by: Amin GATTOUT > --- > drivers/gpu/drm/renesas/rcar-du/rcar_du_encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_encoder.c > index 7ecec7b04a8d..42253c1251b5 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_encoder.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_encoder.c > @@ -72,7 +72,7 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, > if (IS_ERR(bridge)) > return PTR_ERR(bridge); > } else { > - bridge = of_drm_find_bridge(enc_node); > + bridge = of_drm_find_and_get_bridge(enc_node); How did you test this ? > if (!bridge) > return -EPROBE_DEFER; > > > --- > base-commit: d813f421930c5b01b9f61043932de02602dd6ae3 > change-id: 20260326-bridge-43ecbef9d39f -- Regards, Laurent Pinchart