From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE14631A55B for ; Thu, 26 Mar 2026 21:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774562271; cv=none; b=oMb4cUdlgG/zLoUGkvmg7exTAzWIHQD5EahpFGyVc7ri7IYezJ0tKBy+mUDHBN39wKHvrsi/omk5vq5ykA7BCnnsrlLuoUHzRtWJeswfpr5Sl9eHxrThg/CQDaW0meDDzxOSeaks4/4lilrGFskjHX7cUm2PpYVxkwtzFcLUvzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774562271; c=relaxed/simple; bh=EPxxE5Mv61boUTJMKax1c06Cb4xghD5L9clr44dtIyQ=; h=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=h/DIrFVvnWEGbK+6N6ZEPg8AuF5BfdIHBwmROxe/rZmiNCXSGfv6OD51ZXRu4GQzD6sb/9BH5v5oxR8bc5F5T5UCdFafZneM+QgeZlVOToFiVuRT3lodrnC54iusBHjXN56j9Wf4QIQtmmrZqu7oCaNujhHI5uy/V8AikZk7lOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aYGhRF8G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aYGhRF8G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A64C116C6; Thu, 26 Mar 2026 21:57:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774562271; bh=EPxxE5Mv61boUTJMKax1c06Cb4xghD5L9clr44dtIyQ=; h=Date:From:To:Cc:Subject:References:From; b=aYGhRF8G8i+cO29ADq16SiM3mFoKFAzb7ueE14DolfgjmL9ro7/mk0vCtTnidtuKB OtwjpkOAYBlicbsdAMlQx167rd7ZuiYkISLZZpYt/EXUPkUIrjwVoMz4G96gbni3ow 5pDAEXv+7xeCaj3AqOG19thlaqQLk+S4FDqc3ucKfgo1bbXpd4iG0PrhTV4sX6KZXK iY6Ikpex1DtFLmK9Jv/DLRsM9kCeK1KGYZejnDzkSPgxGy/h6VAb3/GdU1ZERRlkJt 55gGyWkr+HMvc8Q0wwSL9CTBVBSa0f+MyhfN1zzM341oyD2iySu8i9EX3ABqeUhBqf e10tAGKeGmNDQ== Date: Thu, 26 Mar 2026 22:57:46 +0100 Message-ID: <20260326215036.986597404@kernel.org> User-Agent: quilt/0.68 From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Michael Kelley , Dmitry Ilvokhin , Radu Rendec , Jan Kiszka , Kieran Bingham , Florian Fainelli Subject: [patch V3 11/14] genirq: Add rcuref count to struct irq_desc References: <20260326214345.019130211@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Prepare for a smarter iterator for /proc/interrupts so that the next interrupt descriptor can be cached after lookup. Signed-off-by: Thomas Gleixner Reviewed-by: Dmitry Ilvokhin --- include/linux/irqdesc.h | 2 ++ kernel/irq/internals.h | 17 ++++++++++++++++- kernel/irq/irqdesc.c | 21 +++++++++++++-------- 3 files changed, 31 insertions(+), 9 deletions(-) --- a/include/linux/irqdesc.h +++ b/include/linux/irqdesc.h @@ -70,6 +70,7 @@ struct irq_redirect { * IRQF_NO_SUSPEND set * @force_resume_depth: number of irqactions on a irq descriptor with * IRQF_FORCE_RESUME set + * @refcnt: Reference count mainly for /proc/interrupts * @rcu: rcu head for delayed free * @kobj: kobject used to represent this struct in sysfs * @request_mutex: mutex to protect request/free before locking desc->lock @@ -119,6 +120,7 @@ struct irq_desc { struct dentry *debugfs_file; const char *dev_name; #endif + rcuref_t refcnt; #ifdef CONFIG_SPARSE_IRQ struct rcu_head rcu; struct kobject kobj; --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #ifdef CONFIG_SPARSE_IRQ @@ -101,9 +102,23 @@ extern void unmask_irq(struct irq_desc * extern void unmask_threaded_irq(struct irq_desc *desc); #ifdef CONFIG_SPARSE_IRQ -static inline void irq_mark_irq(unsigned int irq) { } +static __always_inline void irq_mark_irq(unsigned int irq) { } +void irq_desc_free_rcu(struct irq_desc *desc); + +static __always_inline bool irq_desc_get_ref(struct irq_desc *desc) +{ + return rcuref_get(&desc->refcnt); +} + +static __always_inline void irq_desc_put_ref(struct irq_desc *desc) +{ + if (rcuref_put(&desc->refcnt)) + irq_desc_free_rcu(desc); +} #else extern void irq_mark_irq(unsigned int irq); +static __always_inline bool irq_desc_get_ref(struct irq_desc *desc) { return true; } +static __always_inline void irq_desc_put_ref(struct irq_desc *desc) { } #endif irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc); --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -137,6 +137,7 @@ static void desc_set_defaults(unsigned i desc->tot_count = 0; desc->name = NULL; desc->owner = owner; + rcuref_init(&desc->refcnt, 1); desc_smp_init(desc, node, affinity); } @@ -465,6 +466,17 @@ static void delayed_free_desc(struct rcu kobject_put(&desc->kobj); } +void irq_desc_free_rcu(struct irq_desc *desc) +{ + /* + * We free the descriptor, masks and stat fields via RCU. That + * allows demultiplex interrupts to do rcu based management of + * the child interrupts. + * This also allows us to use rcu in kstat_irqs_usr(). + */ + call_rcu(&desc->rcu, delayed_free_desc); +} + static void free_desc(unsigned int irq) { struct irq_desc *desc = irq_to_desc(irq); @@ -483,14 +495,7 @@ static void free_desc(unsigned int irq) */ irq_sysfs_del(desc); delete_irq_desc(irq); - - /* - * We free the descriptor, masks and stat fields via RCU. That - * allows demultiplex interrupts to do rcu based management of - * the child interrupts. - * This also allows us to use rcu in kstat_irqs_usr(). - */ - call_rcu(&desc->rcu, delayed_free_desc); + irq_desc_put_ref(desc); } static int alloc_descs(unsigned int start, unsigned int cnt, int node,