From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: Frank.Li@nxp.com, acpica-devel@lists.linux.dev,
conor+dt@kernel.org, conor@kernel.org,
devicetree@vger.kernel.org, ebiggers@kernel.org,
fredrik.markstrom@est.tech, jonathanh@nvidia.com,
krzk+dt@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux@roeck-us.net, miquel.raynal@bootlin.com,
p.zabel@pengutronix.de, rafael@kernel.org,
robert.moore@intel.com, robh@kernel.org, smangipudi@nvidia.com,
thierry.reding@kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA
Date: Fri, 27 Mar 2026 09:27:21 +0100 [thread overview]
Message-ID: <20260327082721f7e69e6a@mail.local> (raw)
In-Reply-To: <20260327081858.32354-1-akhilrajeev@nvidia.com>
On 27/03/2026 13:48:58+0530, Akhil R wrote:
> On Thu, 26 Mar 2026 16:44:31 +0100, Alexandre Belloni wrote:
> > On 26/03/2026 10:05:03-0500, Rob Herring wrote:
> >> On Wed, Mar 18, 2026 at 05:31:50PM +0000, Conor Dooley wrote:
> >> > On Wed, Mar 18, 2026 at 10:57:14PM +0530, Akhil R wrote:
> >> > > Add the 'mipi-i3c-static-method' property mentioned in the MIPI I3C
> >> > > Discovery and Configuration Specification [1] to specify which discovery
> >> > > method an I3C device supports during bus initialization. The property is
> >> > > a bitmap, where a bit value of 1 indicates support for that method, and 0
> >> > > indicates lack of support.
> >> > > Bit 0: SETDASA CCC (Direct)
> >> > > Bit 1: SETAASA CCC (Broadcast)
> >> > > Bit 2: Other CCC (vendor / standards extension)
> >> > > All other bits are reserved.
> >> > >
> >> > > It is specifically needed when an I3C device requires SETAASA for the
> >> > > address assignment. SETDASA will be supported by default if this property
> >> > > is absent - which means for now the property just serves as a flag to
> >> > > enable SETAASA, but keep the property as a bitmap to align with the
> >> > > specifications.
> >> > >
> >> > > [1] https://www.mipi.org/specifications/disco
> >> > >
> >> > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> >> > > ---
> >> > > .../devicetree/bindings/i3c/i3c.yaml | 30 ++++++++++++++++---
> >> > > 1 file changed, 26 insertions(+), 4 deletions(-)
> >> > >
> >> > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml
> >> > > index e25fa72fd785..1705d90d4d79 100644
> >> > > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml
> >> > > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml
> >> > > @@ -31,10 +31,12 @@ properties:
> >> > > described in the device tree, which in turn means we have to describe
> >> > > I3C devices.
> >> > >
> >> > > - Another use case for describing an I3C device in the device tree is when
> >> > > - this I3C device has a static I2C address and we want to assign it a
> >> > > - specific I3C dynamic address before the DAA takes place (so that other
> >> > > - devices on the bus can't take this dynamic address).
> >> > > + Other use-cases for describing an I3C device in the device tree are:
> >> > > + - When the I3C device has a static I2C address and we want to assign
> >> > > + it a specific I3C dynamic address before the DAA takes place (so
> >> > > + that other devices on the bus can't take this dynamic address).
> >> > > + - When the I3C device requires SETAASA for its discovery and uses a
> >> > > + pre-defined static address.
> >> > >
> >> > > "#size-cells":
> >> > > const: 0
> >> > > @@ -147,6 +149,26 @@ patternProperties:
> >> > > through SETDASA. If static address is not present, this address is assigned
> >> > > through SETNEWDA after assigning a temporary address via ENTDAA.
> >> > >
> >> > > + mipi-i3c-static-method:
> >> > > + $ref: /schemas/types.yaml#/definitions/uint32
> >> > > + minimum: 0x1
> >> > > + maximum: 0xff
> >> > > + default: 1
> >> > > + description: |
> >> > > + Bitmap describing which methods of Dynamic Address Assignment from a
> >> > > + static address are supported by this I3C Target. A bit value of 1
> >> > > + indicates support for that method, and 0 indicates lack of support.
> >> >
> >> > I really am not keen on properties that are bitmaps, why can't we just
> >> > use the strings "setdasa", "setaasa" etc?
> >>
> >> If this comes from a specification, then I'd tend to just copy it rather
> >> than invent our own thing. Obviously if is something structured
> >> fundamentally different from how DT is designed, then we wouldn't. But
> >> this is just a simple property.
> >>
> >
> > The issue being that the specification is not public so it is difficult
> > to take any decision.
>
> There is a public version available in the same link, but you would still
> have to provide them a name and an email ID. The document will be sent to
> the mail ID.
>
The public version only contains one property:
mipi-disco-interface-revision
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-27 8:27 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 17:27 [PATCH 00/12] i3c: Support ACPI and SETAASA device discovery Akhil R
2026-03-18 17:27 ` [PATCH 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA Akhil R
2026-03-18 17:31 ` Conor Dooley
2026-03-19 8:46 ` Akhil R
2026-03-19 9:39 ` Krzysztof Kozlowski
2026-03-19 17:01 ` Akhil R
2026-03-19 17:14 ` Krzysztof Kozlowski
2026-03-19 18:13 ` Akhil R
2026-03-26 15:05 ` Rob Herring
2026-03-26 15:44 ` Alexandre Belloni
2026-03-27 8:18 ` Akhil R
2026-03-27 8:27 ` Alexandre Belloni [this message]
2026-03-27 11:42 ` Akhil R
2026-03-18 17:27 ` [PATCH 02/12] ACPICA: Read LVR from the I2C resource descriptor Akhil R
2026-03-18 17:27 ` [PATCH 03/12] i3c: master: Use unified device property interface Akhil R
2026-03-19 14:22 ` Frank Li
2026-03-26 15:18 ` Rob Herring
2026-03-18 17:27 ` [PATCH 04/12] i3c: master: Support ACPI enumeration Akhil R
2026-03-19 14:29 ` Frank Li
2026-03-19 17:45 ` Akhil R
2026-03-22 16:55 ` kernel test robot
2026-03-22 17:47 ` kernel test robot
2026-03-23 18:42 ` Akhil R
2026-03-23 18:54 ` Guenter Roeck
2026-03-24 8:43 ` Alexandre Belloni
2026-03-24 17:22 ` Akhil R
2026-03-25 10:59 ` Thierry Reding
2026-03-18 17:27 ` [PATCH 05/12] i3c: master: Add support for devices using SETAASA Akhil R
2026-03-18 17:27 ` [PATCH 06/12] i3c: master: Add support for devices without PID Akhil R
2026-03-18 17:27 ` [PATCH 07/12] i3c: master: match I3C device through DT and ACPI Akhil R
2026-03-18 17:27 ` [PATCH 08/12] i3c: dw-i3c-master: Add SETAASA as supported CCC Akhil R
2026-03-18 17:27 ` [PATCH 09/12] i3c: dw-i3c-master: Add a quirk to skip clock and reset Akhil R
2026-03-18 17:27 ` [PATCH 10/12] i3c: dw-i3c-master: Add ACPI ID for Tegra410 Akhil R
2026-03-18 17:27 ` [PATCH 11/12] hwmon: spd5118: Add I3C support Akhil R
2026-03-18 18:19 ` Alexandre Belloni
2026-03-18 18:53 ` Guenter Roeck
2026-03-19 4:35 ` Akhil R
2026-03-19 14:34 ` Guenter Roeck
2026-03-19 17:55 ` Akhil R
2026-03-19 18:18 ` Guenter Roeck
2026-03-18 17:27 ` [PATCH 12/12] arm64: defconfig: Enable I3C and SPD5118 hwmon Akhil R
2026-03-19 9:40 ` Krzysztof Kozlowski
2026-03-19 17:09 ` Akhil R
2026-03-19 17:15 ` Krzysztof Kozlowski
2026-03-19 18:17 ` Akhil R
2026-03-25 10:31 ` Thierry Reding
2026-03-25 10:59 ` Krzysztof Kozlowski
2026-03-25 11:03 ` Krzysztof Kozlowski
2026-03-25 12:58 ` Thierry Reding
2026-03-25 13:10 ` Krzysztof Kozlowski
2026-03-25 12:41 ` Thierry Reding
2026-03-25 12:47 ` Krzysztof Kozlowski
2026-03-25 13:05 ` Thierry Reding
2026-03-25 13:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327082721f7e69e6a@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=acpica-devel@lists.linux.dev \
--cc=akhilrajeev@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=fredrik.markstrom@est.tech \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox