From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183023D667C for ; Fri, 27 Mar 2026 09:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604713; cv=none; b=TuKRreI9DhOXoCefDMUTaQem4hAklDEkeEybWqNbTGjzXehFSbVdnv8pygnaJW+3iMR0udifBJEaf0Qz1S2vt81fnGHUbUgotjulBxrYl8ZFKKPxmiV4O9svxnyCAH3vSleZAxLSiQ1TIIGgX78TOrBYXtg7tfEZYT7aDrXx8eY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604713; c=relaxed/simple; bh=7uR5ZfLw9g5I/+7SbxvKw/jw1IUzAD9quAniYX3R718=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sXp5bVTt134gaV0QOUyzYO+d0to28b1xFDCcCd/jZO/6ly2fxNjkUMc8ORkU/+PK/EykeKHmdganPjcMjtFsEiE8zMZY4iBwL0JW4ejX0IjFkyOV0wQyMlPPv7/v67XY/rC+Sco+8sCyOSbQqAc+/lEobkeaWFzT+F+mHmFxzHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=USqeTMin; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="USqeTMin" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48541edecf9so23593895e9.1 for ; Fri, 27 Mar 2026 02:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774604710; x=1775209510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Kj+hauZNh7iMjr443ejLDbgySbpC+BhPH2ZS5nH/CB0=; b=USqeTMinJJlOwltPL1D0bgruDBnQRsM4a8Q5iCwjzPSFu8Rfm9jhLFt6PhJtTQ0H89 kzYShApMMo4ujmA8ORnChPlE1ruXc+ETIaxQ3VmHmwE9VNwMYsQHhAAl2FFeQ4KAFkcM P73ASPPK9S7Cwxrtb15wrvHll1bW3EPTmNAR/rgB1hO3PBNhsfk8jUrpRSPs0tD89/Zy L1OnoWQAF8epQepdhQpU9KdUT801hri6p6QWLs4n6bmuB0hW/dNUwr3FY+JBvoDr8GTW yoFTCIA4rF0gKWlBm9G+gPQqoqrc5JaSK/Q7URcDBMeW62WIjv0TegCb/651WO3SswVt mUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774604710; x=1775209510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Kj+hauZNh7iMjr443ejLDbgySbpC+BhPH2ZS5nH/CB0=; b=cebtLQSavnlYaeCsnlooIhxcrtJtG1lHuVicfCCnPXM6F6868LL+3gdBB5p2ot36Bm +Ec8TjKBeAvgbYHtom2dW6505j/H2wkFDDCBoLfA3skvF4hy4BATtOKYjS/tu74RjMB+ YkySWKj338l1pmsb21QU1abX2iHizYkFTidyAtBzpL69Ah0zDSMEa6hgoNRuEVnVjyz4 kZVXSfBOvGWs/1Kv3rMtrrluk3H8wItfmFg2yiXTwB0I5yHJMqZKvc04cWoOwlp28I1j fvFAWLfe4mDg6j+Z1gft9ABX72c1THY0VUSGKfRSCdXE8Ww5ZkNZcl2zjuNCHJgX0KRf I/mA== X-Forwarded-Encrypted: i=1; AJvYcCVQp4WlnQ/So/G36Lai4Du6QQMAaxFi+yfKKloGa7LVSW2m4RWaS0NBk3YsrsfnLKT/dHfJXuvlv0P0i0A=@vger.kernel.org X-Gm-Message-State: AOJu0YwLkOHOO43gJBfpbq+7P9o9ynuk3o4GDyX9jfcc3G/bzZEWlGlP Mf5GRGE2PmyvbsVsXoDZJg5QvZwEzXPuBzoBxaUIcOxI9WX2NpnAbr27 X-Gm-Gg: ATEYQzyv2aDNgPpvl1trZwNbg7e3Vc65YPh8eI7hmvPpAKntmzAuwzlINv/CBAMysbJ XomZ1UNuR/rXmJZj9GDLJ5EZQtUeiyLaWmd0jNaEzr/G7u07nouQRv7PE/U1pZjxX/tvRJniVqQ Rt2jRv/Wbt4c5s988p4vooEGl6urtxt1RnxmXJzo0hOBl7KO2e2oGZK4dNJaIrvImDvTqIg8vbe cvsn7RGvGKrmNzULvUdGlpy2ZTV8vmL+nrjI3PhDc2UaUXVjC9lpdezl57bnf7la1Ig4dFawZOt WtOsL+LRg2GW9asBYlynM8kjhnffYKasAGxKyGY1CL4Wj02cAXr6lB9sSk8NSxEmzIh93BP9i6c aaPjzgQbE5CF0UUSa17UQQ58/TIRG4VXrFIUpz6cpNZ7A8y8vPXwkAuc2T2ArucBUv03Pd8apQa w/UDWt8/YUPQsEyxIiXFn90BfWqkDSh7YRp3vZZ97sBC74KNDfVoASpOzb9YEumLjQNVYi09sOr hw= X-Received: by 2002:a05:600c:6819:b0:485:40fd:8390 with SMTP id 5b1f17b1804b1-48727f238d9mr31232695e9.26.1774604710226; Fri, 27 Mar 2026 02:45:10 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4872718dfdfsm12370055e9.30.2026.03.27.02.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 02:45:09 -0700 (PDT) Date: Fri, 27 Mar 2026 09:45:08 +0000 From: David Laight To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Robert Moore , Len Brown , linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Masami Hiramatsu , Petr Mladek , Rasmus Villemoes , Steven Rostedt , Sergey Senozhatsky , Andrew Morton Subject: Re: [PATCH next] ACPICA: AML Parser: Remove spurious precision from format used to dump parse trees Message-ID: <20260327094508.1801bdf3@pumpkin> In-Reply-To: References: <20260326201830.3938-1-david.laight.linux@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 11:28:26 +0200 Andy Shevchenko wrote: > On Thu, Mar 26, 2026 at 08:18:30PM +0000, david.laight.linux@gmail.com wrote: > > > The debug code in acpi_ps_delete_parse_tree() uses ("%*.s", level * 4, " ") > > to indent traces. > > POSIX requires the empty precision be treated as zero, but the kernel treats > > is as 'no precision specified'. > > Change to ("%*s", level * 4, "") since there is additional whitespace and no > > reason to indent by one space when level is zero. > > This is cross-platform code. Does the same applies to MS VC compiler, for > example? > Everything except the linux kernel will treat "%*.s" as "%*.0s". Regardless of anything else specifying a 'precision' when printing a constant string is entirely pointless - it limits the number of characters copied from the string. Basically "%*.s" is always a typo, either for "%.*s" or "%*s". David