From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9361A0BD0 for ; Fri, 27 Mar 2026 09:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774605050; cv=none; b=dZ3lKiyi3pB/zuda1zeTEkvhKNa7wLXJCxPsl2voafeQdmSx289JOOIDI2EMmZ73lceuywLnma2sRv1vOiEVWzeh+BtvuJ5TPjAWRFcoEa8vNjmjNeC1syz4SKBo1gV0pfCFygx8DJ1iZyBao+nHtFWGuONG18SQsUBiKQK6Suo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774605050; c=relaxed/simple; bh=tdRc77ROmXgoYgRDzc7jVbA3L70HWFKbwUyjbwyzPj8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FCDkgqFK7ZiTLiMceuC2ObyV7O0gAKXiBzQaWhA4m2GQb1fRwcTrnAIduRuDjJaQxW332AtUhS412pFuenop3eBBt5EDBnPfHV9ssN5uLofWBYUqSDD2056Zt82/bPz93G2xZSBuLmqoqRsLoNScf9KhWyMFf2+rcmlLR4d/4xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=1IA1BUY9; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=CIhnRXoG; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=1IA1BUY9; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=CIhnRXoG; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="1IA1BUY9"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="CIhnRXoG"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="1IA1BUY9"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="CIhnRXoG" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 11AD54D2DA; Fri, 27 Mar 2026 09:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774605048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdRc77ROmXgoYgRDzc7jVbA3L70HWFKbwUyjbwyzPj8=; b=1IA1BUY9o1iqR3gq2WDgEAukvveDvSEMPiHEPDVQVrtgRvmTd9X5AOcgY2qLXf2RTd9RkM jCvXOxYjx0do2SKTRCmDl7aLgoTn27ZasY5TbzIoRgykCyGE+At7Sq7vHrFI/PacLfIN+/ 8+SSVrOvihPjFYrTLXA7AcMceLm/jms= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774605048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdRc77ROmXgoYgRDzc7jVbA3L70HWFKbwUyjbwyzPj8=; b=CIhnRXoGZJziek22HhNNs60jaQr0S4DASkFGu2koxrIRaDNHdz6jo4bBmHord9lj0sM5c0 jdkGiSZ6kipX7EDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774605048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdRc77ROmXgoYgRDzc7jVbA3L70HWFKbwUyjbwyzPj8=; b=1IA1BUY9o1iqR3gq2WDgEAukvveDvSEMPiHEPDVQVrtgRvmTd9X5AOcgY2qLXf2RTd9RkM jCvXOxYjx0do2SKTRCmDl7aLgoTn27ZasY5TbzIoRgykCyGE+At7Sq7vHrFI/PacLfIN+/ 8+SSVrOvihPjFYrTLXA7AcMceLm/jms= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774605048; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tdRc77ROmXgoYgRDzc7jVbA3L70HWFKbwUyjbwyzPj8=; b=CIhnRXoGZJziek22HhNNs60jaQr0S4DASkFGu2koxrIRaDNHdz6jo4bBmHord9lj0sM5c0 jdkGiSZ6kipX7EDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C9E424A0A2; Fri, 27 Mar 2026 09:50:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jtDCL/ZSxmlzNQAAD6G6ig (envelope-from ); Fri, 27 Mar 2026 09:50:46 +0000 Date: Fri, 27 Mar 2026 10:50:41 +0100 From: Petr Vorel To: Joe Perches Cc: Simon Glass , linux-kernel@vger.kernel.org, Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Kory Maincent , Tom Rini , Simon Glass , Kuan-Wei Chiu Subject: Re: [PATCH v2] checkpatch: Allow to pass config directory Message-ID: <20260327095041.GC40147@pevik> Reply-To: Petr Vorel References: <20260224181623.89904-1-pvorel@suse.cz> <20260326205020.GA23245@pevik> <65fe50aded2d9184bdb3198d0649e3eeb9bb3d18.camel@perches.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65fe50aded2d9184bdb3198d0649e3eeb9bb3d18.camel@perches.com> X-Spam-Score: -2.00 X-Spam-Level: X-Spamd-Result: default: False [-2.00 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[chromium.org,vger.kernel.org,canonical.com,gmail.com,bootlin.com,konsulko.com]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Flag: NO > On Thu, 2026-03-26 at 21:50 +0100, Petr Vorel wrote: > > > my $paths = $def_configuration_dirs; > > > $paths = "$ENV{$env_config_dir}:$paths" if exists($ENV{$env_config_dir}); > > +1, sure, thanks! > Why have two uses of $ENV{$env_config_dir}? Your suggestion in v1 :). > Seems typo error prone and somewhat difficult to read. In v3 I'll just prepend it without checking, because we do the check later on if (-e "$path/$conf"). And add a note that one can add more dirs (like in PATH or LD_LIBRARY_PATH). But again, it looks to me more better to point just a single file. Check would be done only on the directory to which variable points, that's what would user probably want (not silently fallbacking into the default directories). But that would require slightly more code changes. Kind regards, Petr