From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42821231832; Fri, 27 Mar 2026 17:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631218; cv=none; b=jLNnr5d6wVBRd4o1eXLCao/9LfIr0Vg/hiYehbUYv4O/TTh22xtG48n6NEBsUSGsyjN4AOLCb5NlqM1WRq5JKMl1j5TbBlFV0CLCGRUjbW9bQiQ9D8f2CJrJtPIbPDRe1jt+/ths9bPxqUdRjEi4ycamUJSGHMXH9e6Sf5T9u/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631218; c=relaxed/simple; bh=vLL4v8VAXKNthR6L1PD+8yULdWXnKJctvDyolGaUXzQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JMGjpBzNhEQENxes+jhAjmv4gV/rxbvB3freSZGs8CSHEJxLscgrFullQkZtV8hg4YSrlljjhk2mBU9eA0D/d8lqn5rZlUAPAhzN0EZhpwagzgSJ70A3UV7Y+WT9oJZ8/wPZFYMHLZ1NLfMyaF706aieIG03EdcQhjiDrkkZlxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=tkjXcO/2; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="tkjXcO/2" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 207484E4282C; Fri, 27 Mar 2026 17:06:50 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id CF91D60268; Fri, 27 Mar 2026 17:06:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4EF2D10451ABF; Fri, 27 Mar 2026 18:06:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774631208; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=Jzs16/Hci7BrDK5k2/QRaN0P7w7nkSMj+Uv+0x67DEo=; b=tkjXcO/2wsgAXL+NYyrzec0vnbi4rC8qkOwkf3LFSG5nJzKMKu2dyWKUPUctv0Pb4OxNiC cXy8c4N/K7xsgsa1wTdmgQSiWIZ8IcflMD5TBzJVrEghDCPi00eMy0NcbcarvwDxd6KZOx x7655TfMh4huEAqwKTYEwnAXgEqbHbjZ1zGwqOaWbhSBMKuH7W4ATUl8Ard9ZmZMcdXur2 RCf3YxyK9eIGCIvdKOIfHI4K0SyfgeLYWCtfOxkw+i+AgK1ZGoB8yH9oO9/MoaWnEuTb2L lAILrenKgQCwCx9gEIDL72yUUw/VRdK4GGK1M/cT1od0jD7AhG9M+nIk7juhag== Date: Fri, 27 Mar 2026 18:06:42 +0100 From: Alexandre Belloni To: Akhil R Cc: Frank.Li@nxp.com, acpica-devel@lists.linux.dev, conor+dt@kernel.org, conor@kernel.org, devicetree@vger.kernel.org, ebiggers@kernel.org, fredrik.markstrom@est.tech, jonathanh@nvidia.com, krzk+dt@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux@roeck-us.net, miquel.raynal@bootlin.com, p.zabel@pengutronix.de, rafael@kernel.org, robert.moore@intel.com, robh@kernel.org, smangipudi@nvidia.com, thierry.reding@kernel.org Subject: Re: [PATCH 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA Message-ID: <2026032717064247cc495e@mail.local> References: <20260327082721f7e69e6a@mail.local> <20260327114204.46556-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260327114204.46556-1-akhilrajeev@nvidia.com> X-Last-TLS-Session-Version: TLSv1.3 On 27/03/2026 17:12:04+0530, Akhil R wrote: > On Fri, 27 Mar 2026 09:27:21 +0100, Alexandre Belloni wrote: > > On 27/03/2026 13:48:58+0530, Akhil R wrote: > >> On Thu, 26 Mar 2026 16:44:31 +0100, Alexandre Belloni wrote: > >> > On 26/03/2026 10:05:03-0500, Rob Herring wrote: > >> >> On Wed, Mar 18, 2026 at 05:31:50PM +0000, Conor Dooley wrote: > >> >> > On Wed, Mar 18, 2026 at 10:57:14PM +0530, Akhil R wrote: > >> >> > > Add the 'mipi-i3c-static-method' property mentioned in the MIPI I3C > >> >> > > Discovery and Configuration Specification [1] to specify which discovery > >> >> > > method an I3C device supports during bus initialization. The property is > >> >> > > a bitmap, where a bit value of 1 indicates support for that method, and 0 > >> >> > > indicates lack of support. > >> >> > > Bit 0: SETDASA CCC (Direct) > >> >> > > Bit 1: SETAASA CCC (Broadcast) > >> >> > > Bit 2: Other CCC (vendor / standards extension) > >> >> > > All other bits are reserved. > >> >> > > > >> >> > > It is specifically needed when an I3C device requires SETAASA for the > >> >> > > address assignment. SETDASA will be supported by default if this property > >> >> > > is absent - which means for now the property just serves as a flag to > >> >> > > enable SETAASA, but keep the property as a bitmap to align with the > >> >> > > specifications. > >> >> > > > >> >> > > [1] https://www.mipi.org/specifications/disco > >> >> > > > >> >> > > Signed-off-by: Akhil R > >> >> > > --- > >> >> > > .../devicetree/bindings/i3c/i3c.yaml | 30 ++++++++++++++++--- > >> >> > > 1 file changed, 26 insertions(+), 4 deletions(-) > >> >> > > > >> >> > > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml > >> >> > > index e25fa72fd785..1705d90d4d79 100644 > >> >> > > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml > >> >> > > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml > >> >> > > @@ -31,10 +31,12 @@ properties: > >> >> > > described in the device tree, which in turn means we have to describe > >> >> > > I3C devices. > >> >> > > > >> >> > > - Another use case for describing an I3C device in the device tree is when > >> >> > > - this I3C device has a static I2C address and we want to assign it a > >> >> > > - specific I3C dynamic address before the DAA takes place (so that other > >> >> > > - devices on the bus can't take this dynamic address). > >> >> > > + Other use-cases for describing an I3C device in the device tree are: > >> >> > > + - When the I3C device has a static I2C address and we want to assign > >> >> > > + it a specific I3C dynamic address before the DAA takes place (so > >> >> > > + that other devices on the bus can't take this dynamic address). > >> >> > > + - When the I3C device requires SETAASA for its discovery and uses a > >> >> > > + pre-defined static address. > >> >> > > > >> >> > > "#size-cells": > >> >> > > const: 0 > >> >> > > @@ -147,6 +149,26 @@ patternProperties: > >> >> > > through SETDASA. If static address is not present, this address is assigned > >> >> > > through SETNEWDA after assigning a temporary address via ENTDAA. > >> >> > > > >> >> > > + mipi-i3c-static-method: > >> >> > > + $ref: /schemas/types.yaml#/definitions/uint32 > >> >> > > + minimum: 0x1 > >> >> > > + maximum: 0xff > >> >> > > + default: 1 > >> >> > > + description: | > >> >> > > + Bitmap describing which methods of Dynamic Address Assignment from a > >> >> > > + static address are supported by this I3C Target. A bit value of 1 > >> >> > > + indicates support for that method, and 0 indicates lack of support. > >> >> > > >> >> > I really am not keen on properties that are bitmaps, why can't we just > >> >> > use the strings "setdasa", "setaasa" etc? > >> >> > >> >> If this comes from a specification, then I'd tend to just copy it rather > >> >> than invent our own thing. Obviously if is something structured > >> >> fundamentally different from how DT is designed, then we wouldn't. But > >> >> this is just a simple property. > >> >> > >> > > >> > The issue being that the specification is not public so it is difficult > >> > to take any decision. > >> > >> There is a public version available in the same link, but you would still > >> have to provide them a name and an email ID. The document will be sent to > >> the mail ID. > >> > > > > The public version only contains one property: > > mipi-disco-interface-revision > > Could you check once if the below link works? > https://www.mipi.org/mipi-disco-for-i3c-download It works, thanks. The bitfield is fine then. > > Best Regards, > Akhil -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com