Re: [PATCH v3] crypto: cryptomgr - Select algorithm types only when CRYPTO_SELFTESTS

[Eric Biggers <ebiggers@kernel.org>]

On Tue, Mar 24, 2026 at 04:02:20PM -0700, Eric Biggers wrote:
> Enabling any template selects CRYPTO_MANAGER, which causes
> CRYPTO_MANAGER2 to enable itself, which selects every algorithm type
> option.  However, pulling in all algorithm types is needed only when the
> self-tests are enabled.  So condition the selections accordingly.
> 
> To make this possible, also add the missing selections to various
> symbols that were relying on transitive selections via CRYPTO_MANAGER.
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> 
> This patch is targeting cryptodev/master
> 
> v3: addressed more transitive selections
> v2: add selections to options that were relying on transitive selection

Looks like CRYPTO_USER needs 'select CRYPTO_RNG' too, since otherwise
CRYPTO_RNG=m && CRYPTO_USER=y && CRYPTO_SELFTESTS=n breaks the build.

Though oddly enough crypto_del_default_rng() has an unused stub, which
implies that it may have been intended to be optional.

- Eric