From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE1A270ED7 for ; Sun, 29 Mar 2026 05:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774762876; cv=none; b=oxm0IHWqHvi/7n4K57pfrUNt+xDl0r1TSuWDZylKwj/+glbLmG0htsa3P0YfLzaYJdHeYsvDIDZva8Ew/jQXnW2bf7bPA7xVvyMNwAynruAe4wdY/3gPVCDwrnqINu6xwHU58xSbxlHaye3pBNiXPbAYFJL5c6IurhKEjz9eoOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774762876; c=relaxed/simple; bh=mghBULNVYcPQDCfOhOVjq2FEvuBPQ/lJcinugvcTByU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ViYL4xri1gdkEIdHpaJRm01ox9mAwjfdxpzf3JZ9bczpVycW1PQL6q8uaNpDg3BY1yNMPqvaTSnDHZh2bChiFTErCudcKzwFdzmoJ50WGOK9QBhX7vEWDyDZ9vKhvIQjGGpy8XnsdBDetseOWlHIRcMV6TbesyXfkCi18MD6bVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R6ZZRhYu; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R6ZZRhYu" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ad9a9be502so21222625ad.0 for ; Sat, 28 Mar 2026 22:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774762874; x=1775367674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g+lckgw6UmGvJZEicF/O4AgCi9bwg1ZzjiyXQ1bC0BU=; b=R6ZZRhYu6M/X4nfeJepv/kSJ6Mzs0KqxEfmlp8vKM19/1OktTiXbUQ/R8abLd5bdy5 v0ejq8mq+TOhrOepvbPP6oMGbpc6Yrb6FeCRKYUvNAnldOprGaA8cg142aJd4rYnIfg2 nxOGsyrdW9hukWXW+BuOMaObfL4vONmSelcKh7A9PPJ/lxw0/TdubMtpzAqQ+ZHLU4/F hSLvzr31tNSs+y65xxIZr/ADWAFxXC5DAe+fAGuKDO6fEF9LIql5I/Z2ok+/XqhJL+zE CDEpxUE5vVcpd71cexCG7j8J1BcBmwmPk9KlmywixU+W/0DIq5DNE6/aA2yoqH5wfaBV S/fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774762874; x=1775367674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g+lckgw6UmGvJZEicF/O4AgCi9bwg1ZzjiyXQ1bC0BU=; b=NFiBYv/c5gov0mf4McnzjVOJuIYfB/p0xJI0d6wHGftoCbxittPCRc1rJMSZyTZ7xy +WF04WP02k4Kr3jXeT4nPgzRHdXpQ5GwBssLpFMaPxIrVoU9peN7xTJXCNa/BaZOWSBt XetrzUtXsu47wTACxpln7o8AZstJ6iyo3nMlqmAOZrqHeLPiWaw5Q8dxFJJ1AP3dZFJL Pni7Vh96DVPKZIY+Zt45EMf6VVfY6yk1XnmV6r7dBuBVcgVQs2QfqqshiIzhoYjWUs3U jKvfekPgqqHh+mS4l6yQtfNqVPUGCymYouncgryPZMtmcOQqwnqZazklxL7MYvf7QauL 0VAg== X-Forwarded-Encrypted: i=1; AJvYcCViWDjUXmJtghMY33JV9vRLEa045iwrGOMgbByJeCnHkWG8ouGLmX6k++0KFRFco87r52vYdf0hPR6v1NA=@vger.kernel.org X-Gm-Message-State: AOJu0YxMb2EROEYigTN9BsM+xDK/clalMBaWvv91EYXi3V5DjWlqKq6P SDUnIkBKDVrE30fk0o55OaLKMuL11t8SR9Y4g9j7S5H+J7AaSMCMe56c X-Gm-Gg: ATEYQzzPohcQOdeFygvw5VD7osw7LaKiuz25RFhZN64UU0nM5v0r+uZ12fva43gC6kB xBbHNcENhqFltlfxzPMCPWmwV5NQtq/wwFJS/8bGTI9nzQIH6fQtHx45KZECqsP7/VmVwiNJeoK gE1fjKVF7rYEehoWLA5axoJb5JwBZpWqA0qboJ+YoMDwIR8Qz2Sd/2ZXUeUed1Dm3+U+h2FAS+K 4DN9SJ4nk5Q5tZUjZt9rQWQYU1ajXdCAvzCy+y10apHp5DJ3kiRP7Blbi128MQhoxnQ3zts7Wv/ Jkkv137/Sk7K934nMBs8yCqJkPfTSXSIIHbfv+rPvDmClp4+Rh22beeNssjWcHoctpU+eGGd3Uw qh/5Ek+T/lgDnroWPUkHs1qxhz+BGRz8KMBuMpPIkBT397Vb9ABYmANtXfn8iYGZQWKJ+xGz49C DKHkky4jzWqMC9O8upSm6M6sE8vDk3RyNP7aXVEq9PIBWZoHsmr5HHcL23RP9KrALAc14Mhu21L 1s1c6Xr X-Received: by 2002:a17:902:f542:b0:2b2:42da:25cd with SMTP id d9443c01a7336-2b242da32fcmr44367275ad.45.1774762873978; Sat, 28 Mar 2026 22:41:13 -0700 (PDT) Received: from cachyos-x8664.iitd.ac.in ([2001:df4:e000:3fd2:59eb:b75c:7ede:19e7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242670302sm39144395ad.26.2026.03.28.22.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 22:41:13 -0700 (PDT) From: Bani Brata To: platform-driver-x86@vger.kernel.org Cc: Bani Brata , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] platform/x86: hp-wmi: Add ACPI PWM fan control for HP ENVY 13-bd0xxx Date: Sun, 29 Mar 2026 11:10:51 +0530 Message-ID: <20260329054052.32023-2-banibrata2007@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260329054052.32023-1-banibrata2007@gmail.com> References: <20260329054052.32023-1-banibrata2007@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On the HP ENVY x360 Convertible 13-bd0xxx (board 8824), standard WMI methods for fan speed control and RPM reporting do not function. However, the DSDT exposes ACPI methods (\_SB.PC00.LPCB.EC0.FANG and FANW) that allow reading and writing an 8-bit PWM level (0-255) to the EC. This patch maps these ACPI methods to standard hwmon `pwm1` and `pwm1_enable` nodes, allowing userspace tools to successfully control the fan speed. Signed-off-by: Bani Brata --- drivers/platform/x86/hp/hp-wmi.c | 155 ++++++++++++++++++++++++++++++- 1 file changed, 155 insertions(+) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -48,6 +48,14 @@ #define HP_FAN_SPEED_AUTOMATIC 0x00 #define HP_POWER_LIMIT_DEFAULT 0x00 #define HP_POWER_LIMIT_NO_CHANGE 0xFF +#define HP_ENVY_8824_ACPI_FANG "\\_SB.PC00.LPCB.EC0.FANG" +#define HP_ENVY_8824_ACPI_FANW "\\_SB.PC00.LPCB.EC0.FANW" +#define HP_ENVY_8824_FAN_VALUE_ARG 33026ULL +#define HP_ENVY_8824_FAN_PRIME_ARG 33030ULL +#define HP_ENVY_8824_FAN_PRIME_MANUAL 0xFFULL +#define HP_ENVY_8824_FAN_PRIME_AUTO 0x8ULL +#define HP_ENVY_8824_PWM_MODE_MANUAL 1 +#define HP_ENVY_8824_PWM_MODE_AUTO 2 #define ACPI_AC_CLASS "ac_adapter" @@ -193,6 +201,8 @@ static const struct dmi_system_id hp_wmi_rfkill_dmi_table[] __initconst = { static bool is_victus_s_board; static bool is_envy_x360_8824_board; +static DEFINE_MUTEX(hp_envy_x360_8824_fan_lock); +static int hp_envy_x360_8824_pwm_mode = HP_ENVY_8824_PWM_MODE_AUTO; static const struct dmi_system_id hp_envy_x360_8824_boards[] __initconst = { { @@ -518,6 +528,120 @@ static int hp_wmi_get_fan_speed_victus_s(int fan) return ret; } +static int hp_envy_x360_8824_acpi_eval(const char *path, + const unsigned long long *args, + size_t arg_count, + unsigned long long *value) +{ + struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; + union acpi_object params[2] = { }; + struct acpi_object_list input = { .count = arg_count, .pointer = params }; + union acpi_object *obj; + acpi_status status; + size_t i; + + for (i = 0; i < arg_count; i++) { + params[i].type = ACPI_TYPE_INTEGER; + params[i].integer.value = args[i]; + } + + status = acpi_evaluate_object(NULL, (acpi_string)path, + arg_count ? &input : NULL, &output); + if (ACPI_FAILURE(status)) + return -EIO; + + obj = output.pointer; + if (!obj) + return -ENODATA; + + if (obj->type != ACPI_TYPE_INTEGER) { + kfree(obj); + return -EINVAL; + } + + *value = obj->integer.value; + kfree(obj); + + return 0; +} + +static int hp_envy_x360_8824_get_pwm_locked(void) +{ + unsigned long long args[] = { HP_ENVY_8824_FAN_VALUE_ARG }; + unsigned long long value; + int ret; + + ret = hp_envy_x360_8824_acpi_eval(HP_ENVY_8824_ACPI_FANG, args, + ARRAY_SIZE(args), &value); + if (ret) + return ret; + if (value > U8_MAX) + return -EINVAL; + + return value; +} + +static int hp_envy_x360_8824_set_pwm_locked(u8 pwm) +{ + unsigned long long args[] = { + HP_ENVY_8824_FAN_PRIME_ARG, + HP_ENVY_8824_FAN_PRIME_MANUAL, + }; + unsigned long long value; + int ret; + + ret = hp_envy_x360_8824_acpi_eval(HP_ENVY_8824_ACPI_FANW, args, + ARRAY_SIZE(args), &value); + if (ret) + return ret; + + args[0] = HP_ENVY_8824_FAN_VALUE_ARG; + args[1] = pwm; + ret = hp_envy_x360_8824_acpi_eval(HP_ENVY_8824_ACPI_FANW, args, + ARRAY_SIZE(args), &value); + if (ret) + return ret; + + hp_envy_x360_8824_pwm_mode = HP_ENVY_8824_PWM_MODE_MANUAL; + return 0; +} + +static int hp_envy_x360_8824_set_auto_locked(void) +{ + unsigned long long args[] = { + HP_ENVY_8824_FAN_PRIME_ARG, + HP_ENVY_8824_FAN_PRIME_AUTO, + }; + unsigned long long value; + int ret; + + ret = hp_envy_x360_8824_acpi_eval(HP_ENVY_8824_ACPI_FANW, args, + ARRAY_SIZE(args), &value); + if (ret) + return ret; + + args[0] = HP_ENVY_8824_FAN_VALUE_ARG; + args[1] = HP_ENVY_8824_FAN_PRIME_MANUAL; + ret = hp_envy_x360_8824_acpi_eval(HP_ENVY_8824_ACPI_FANW, args, + ARRAY_SIZE(args), &value); + if (ret) + return ret; + + hp_envy_x360_8824_pwm_mode = HP_ENVY_8824_PWM_MODE_AUTO; + return 0; +} + +static int hp_envy_x360_8824_set_manual_locked(void) +{ + int pwm; + + pwm = hp_envy_x360_8824_get_pwm_locked(); + if (pwm < 0) + return pwm; + + return hp_envy_x360_8824_set_pwm_locked(pwm); +} + /* * Calling this hp_wmi_get_fan_count_userdefine_trigger function also enables * and/or maintains the laptop in user defined thermal and fan states, instead @@ -2103,6 +2227,12 @@ static void hp_wmi_rfkill_setup(struct platform_device *device) rfkill_unregister(wifi_rfkill); rfkill_destroy(wifi_rfkill); } + + if (is_envy_x360_8824_board) { + mutex_lock(&hp_envy_x360_8824_fan_lock); + hp_envy_x360_8824_set_auto_locked(); + mutex_unlock(&hp_envy_x360_8824_fan_lock); + } if (bluetooth_rfkill) { rfkill_unregister(bluetooth_rfkill); rfkill_destroy(bluetooth_rfkill); @@ -2176,6 +2306,10 @@ static umode_t hp_wmi_hwmon_is_visible(const void *data, { switch (type) { case hwmon_pwm: + if (attr == hwmon_pwm_input) + return is_envy_x360_8824_board ? 0644 : 0; + if (attr == hwmon_pwm_enable) + return is_envy_x360_8824_board ? 0644 : 0; return 0644; case hwmon_fan: if (is_envy_x360_8824_board) @@ -2213,6 +2347,25 @@ static int hp_wmi_hwmon_read(struct device *dev, enum hwmon_sensor_types type, *val = ret; return 0; case hwmon_pwm: + if (is_envy_x360_8824_board) { + mutex_lock(&hp_envy_x360_8824_fan_lock); + if (attr == hwmon_pwm_input) { + ret = hp_envy_x360_8824_get_pwm_locked(); + if (!ret) + *val = ret; + else if (ret > 0) + *val = ret; + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return ret < 0 ? ret : 0; + } + if (attr == hwmon_pwm_enable) { + *val = hp_envy_x360_8824_pwm_mode; + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return 0; + } + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return -EOPNOTSUPP; + } switch (hp_wmi_fan_speed_max_get()) { case 0: /* 0 is automatic fan, which is 2 for hwmon */ @@ -2236,8 +2389,40 @@ static int hp_wmi_hwmon_read(struct device *dev, enum hwmon_sensor_types type, static int hp_wmi_hwmon_write(struct device *dev, enum hwmon_sensor_types type, u32 attr, int channel, long val) { + int ret; + switch (type) { case hwmon_pwm: + if (is_envy_x360_8824_board) { + mutex_lock(&hp_envy_x360_8824_fan_lock); + switch (attr) { + case hwmon_pwm_input: + if (val < 0 || val > U8_MAX) { + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return -EINVAL; + } + ret = hp_envy_x360_8824_set_pwm_locked(val); + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return ret; + case hwmon_pwm_enable: + switch (val) { + case HP_ENVY_8824_PWM_MODE_MANUAL: + ret = hp_envy_x360_8824_set_manual_locked(); + break; + case HP_ENVY_8824_PWM_MODE_AUTO: + ret = hp_envy_x360_8824_set_auto_locked(); + break; + default: + ret = -EINVAL; + break; + } + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return ret; + default: + mutex_unlock(&hp_envy_x360_8824_fan_lock); + return -EOPNOTSUPP; + } + } switch (val) { case 0: if (is_victus_s_thermal_profile()) @@ -2262,7 +2447,7 @@ static int hp_wmi_hwmon_write(struct device *dev, enum hwmon_sensor_types type, static const struct hwmon_channel_info * const info[] = { HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT, HWMON_F_INPUT), - HWMON_CHANNEL_INFO(pwm, HWMON_PWM_ENABLE), + HWMON_CHANNEL_INFO(pwm, HWMON_PWM_INPUT | HWMON_PWM_ENABLE), NULL }; -- 2.48.1