From: "Bera Yüzlü" <b9788213@gmail.com>
To: david@cardinalsystem.net
Cc: andriy.shevchenko@linux.intel.com, dan.carpenter@linaro.org,
ethantidmore06@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: rename variables to snake_case
Date: Sun, 29 Mar 2026 09:43:34 +0300 [thread overview]
Message-ID: <20260329064334.13617-1-b9788213@gmail.com> (raw)
In-Reply-To: <20260327203636.24891-1-david@cardinalsystem.net>
on Fri, 27 Mar 2026 16:36:36 -0400, David Holland wrote:
> From: David Holland <david@cardinalsystem.net>
You don't need that.
> The Linux kernel coding style guidelines prohibit the use of CamelCase
> variable names. All variables should be snakecase.
>
> Rename the 'ChipVersion' parameter to 'chip_version' and the
> 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to
> the standard snakecase naming convention.
>
> Signed-off-by: David Holland <david@cardinalsystem.net>
> ---
>
> Hey everyone,
>
> This is my first attempt at submitting a patch into the Linux kernel. I always wanted to try to get my own patch submitted into the kernel so I was scrolling through the codebase and found some incorrect naming styles. I corrected the variables name that were using camelCase to use the traditional snakecase.
>
> Thanks for reviewing,
> David
Wrap your lines, please.
Thanks,
Bera
next prev parent reply other threads:[~2026-03-29 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 20:36 [PATCH] staging: rtl8723bs: rename variables to snake_case david
2026-03-29 6:43 ` Bera Yüzlü [this message]
2026-03-29 7:32 ` Greg KH
2026-03-29 23:51 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260329064334.13617-1-b9788213@gmail.com \
--to=b9788213@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=david@cardinalsystem.net \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox