From: David Disseldorp <ddiss@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Disseldorp <ddiss@suse.de>, Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v4 6/6] kstrtox: Drop extern keyword in the simple_strtox() declarations
Date: Sun, 29 Mar 2026 21:30:28 +1100 [thread overview]
Message-ID: <20260329105307.2876-7-ddiss@suse.de> (raw)
In-Reply-To: <20260329105307.2876-1-ddiss@suse.de>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
There is legacy 'extern' keyword for the exported simple_strtox()
function which are the artefact that can be removed. So drop it.
While at it, tweak the declaration to provide parameter names.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
---
include/linux/kstrtox.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/kstrtox.h b/include/linux/kstrtox.h
index 7fcf29a4e0de4..6c92828667704 100644
--- a/include/linux/kstrtox.h
+++ b/include/linux/kstrtox.h
@@ -142,9 +142,9 @@ static inline int __must_check kstrtos32_from_user(const char __user *s, size_t
* Keep in mind above caveat.
*/
-extern unsigned long simple_strtoul(const char *,char **,unsigned int);
-extern long simple_strtol(const char *,char **,unsigned int);
-extern unsigned long long simple_strtoull(const char *,char **,unsigned int);
-extern long long simple_strtoll(const char *,char **,unsigned int);
+unsigned long simple_strtoul(const char *cp, char **endp, unsigned int base);
+long simple_strtol(const char *cp, char **endp, unsigned int base);
+unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
+long long simple_strtoll(const char *cp, char **endp, unsigned int base);
#endif /* _LINUX_KSTRTOX_H */
--
2.51.0
prev parent reply other threads:[~2026-03-29 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 10:30 [PATCH v4 0/6] initramfs: test and improve cpio hex header validation David Disseldorp
2026-03-29 10:30 ` [PATCH v4 1/6] initramfs_test: add fill_cpio() inject_ox parameter David Disseldorp
2026-03-30 9:49 ` Andy Shevchenko
2026-03-29 10:30 ` [PATCH v4 2/6] initramfs_test: test header fields with 0x hex prefix David Disseldorp
2026-03-30 9:52 ` Andy Shevchenko
2026-03-29 10:30 ` [PATCH v4 3/6] initramfs: Sort headers alphabetically David Disseldorp
2026-03-29 10:30 ` [PATCH v4 4/6] initramfs: Refactor to use hex2bin() instead of custom approach David Disseldorp
2026-03-30 9:50 ` Andy Shevchenko
2026-03-30 9:55 ` Andy Shevchenko
2026-03-30 10:39 ` David Disseldorp
2026-04-01 12:41 ` Petr Mladek
2026-03-29 10:30 ` [PATCH v4 5/6] vsprintf: Revert "add simple_strntoul" David Disseldorp
2026-03-29 10:30 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260329105307.2876-7-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox