From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AA1628371;
	Sun, 29 Mar 2026 22:22:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774822958; cv=none; b=HfPH0zCSjEVAxxQhkarrFRokvm+yfgy5grQpOQmoVRZMmiBKpGGKC/Cbt5mXZmTfR119+t6tbm7chQU6RcUql6x/kKuVD4RKHh9q3L1ch84ozH8xI4GaYwa6V3o2AYipOb/jDLLNtahoQyMAJjMzps2rh7roojw81QKpOW8IjYU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774822958; c=relaxed/simple;
	bh=W/lQbU4TcrMiqCciGbdlDKp78ihMXAxzfH5vgaNPrfQ=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=Wn/amnjHhDU2h5h1MBBfbO2ZfPBtXF6IevBI0xuoABtuL5EBhGvM6bSjq2+O0HWxHZ47++LcSpnooxYQ2Xr3VTVTJL9RuxNOYGV058dTS1JqAunoXUjDwWPzFOBN5c2+g88Qg6SQJ8mukPkp4kiM8LZ3ACmV3TaKDlcQC38JA9E=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bw99ntM3; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bw99ntM3"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D49FDC116C6;
	Sun, 29 Mar 2026 22:22:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1774822958;
	bh=W/lQbU4TcrMiqCciGbdlDKp78ihMXAxzfH5vgaNPrfQ=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Bw99ntM319iiihiH/xvIW0cHd9LiL8IXqGgOPV9c2OH/VgEuzvwPg5ubYXTLcRSwW
	 R5Q1Wwuu2pb8hU5hRYor2GrNjtV1CDqgV5mHSaPtvLlJykB4qns+jk/wUHF5Lb9lHc
	 IrSvvKfHEpm6Z4YpZLMtVxid6htRWJj8kAbhwo/b+4ypt4ThGuqr7utWls1fjCKjbE
	 U/zlJfDKtq+xQyFBmw1fLqxBM/xFhjr6dE3Prrk2Svwqisc3MLxHSe7I82JvGQ7w84
	 OkDYE9oEZtJlQubE63CBvskPig58Rco1goth0eWHcLd+/Q5qSKqAVaIWN6Zzw5k/3o
	 fEzMduFXJY3HA==
Date: Sun, 29 Mar 2026 15:22:36 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <joe@dama.to>
Cc: netdev@vger.kernel.org, Michael Chan <michael.chan@broadcom.com>, "David
 S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, andrew+netdev@lunn.ch, horms@kernel.org,
 pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org
Subject: Re: [net-next v6 09/12] net: bnxt: Add SW GSO completion and
 teardown support
Message-ID: <20260329152236.6ad729e6@kernel.org>
In-Reply-To: <20260326235238.2940471-10-joe@dama.to>
References: <20260326235238.2940471-1-joe@dama.to>
	<20260326235238.2940471-10-joe@dama.to>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 26 Mar 2026 16:52:28 -0700 Joe Damato wrote:
> +			if (head_buf->is_sw_gso == BNXT_SW_GSO_LAST) {
> +				if (dma_use_iova(&head_buf->iova_state))
> +					dma_iova_destroy(&pdev->dev,
> +							 &head_buf->iova_state,
> +							 head_buf->iova_total_len,
> +							 DMA_TO_DEVICE, 0);

Do we have to expose the dma_use_iova() stuff to the driver at all?
Could we have a function the driver is supposed to call to clean up,
always, and what the function does is up to the TSO lib?