From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>, Rong Xu <xur@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alice Ryhl <aliceryhl@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Rafael Aquini <aquini@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Stafford Horne <shorne@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Piotr Gorski <piotrgorski@cachyos.org>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Teresa Johnson <tejohnson@google.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v7 3/3] kbuild: distributed build support for Clang ThinLTO
Date: Mon, 30 Mar 2026 12:01:19 +0200 [thread overview]
Message-ID: <20260330100119.GA1953970@ax162> (raw)
In-Reply-To: <acmF7nvIh2nX5hjK@levanger>
On Sun, Mar 29, 2026 at 10:05:02PM +0200, Nicolas Schier wrote:
> On Sat, Mar 28, 2026 at 01:19:27AM +0000, xur@google.com wrote:
> > diff --git a/Makefile b/Makefile
> > index 69ccf9b8507d..d474b6f0f212 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1047,11 +1047,11 @@ export CC_FLAGS_SCS
> > endif
> >
> > ifdef CONFIG_LTO_CLANG
> > -ifdef CONFIG_LTO_CLANG_THIN
> > +ifdef CONFIG_LTO_CLANG_FULL
> > +CC_FLAGS_LTO := -flto
> > +else
> > CC_FLAGS_LTO := -flto=thin -fsplit-lto-unit
> > KBUILD_LDFLAGS += $(call ld-option,--lto-whole-program-visibility -mllvm -always-rename-promoted-locals=false)
> > -else
> > -CC_FLAGS_LTO := -flto
> > endif
> > CC_FLAGS_LTO += -fvisibility=hidden
> >
>
> This hunk is just reordering but does not change any functionality,
> right?
It does, as CONFIG_LTO_CLANG_THIN and CONFIG_LTO_CLANG_THIN_DIST are two
distinct options. That said, this hunk still does not look right based
on Yonghong's comment?
https://lore.kernel.org/044bebc0-d996-4be3-9330-a64195c19a84@linux.dev/
Rong, have you tested this with a recent version of LLVM? Or has support
for this flag been added to the distributed mode since Yonghong's
comment?
> Nathan, Piotr: your tags got dropped from v6 to v7. Do you want to
> renew them?
Yes, once the above is sorted out.
Cheers,
Nathan
prev parent reply other threads:[~2026-03-30 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 1:19 [PATCH v7 0/3] kbuild: distributed build support for Clang ThinLTO xur
2026-03-28 1:19 ` [PATCH v7 1/3] kbuild: move vmlinux.a build rule to scripts/Makefile.vmlinux_a xur
2026-03-28 1:19 ` [PATCH v7 2/3] kbuild: change --thin back to 'T' in $(AR) xur
2026-03-28 1:19 ` [PATCH v7 3/3] kbuild: distributed build support for Clang ThinLTO xur
2026-03-29 20:05 ` Nicolas Schier
2026-03-30 10:01 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330100119.GA1953970@ax162 \
--to=nathan@kernel.org \
--cc=aliceryhl@google.com \
--cc=aquini@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=piotrgorski@cachyos.org \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=shorne@gmail.com \
--cc=tejohnson@google.com \
--cc=tglx@linutronix.de \
--cc=venkat88@linux.ibm.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox