From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tanjim Kamal <tanjimkamal1@gmail.com>
Cc: Oskar Ray-Frayssinet <rayfraytech@gmail.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
Date: Mon, 30 Mar 2026 17:59:23 +0200 [thread overview]
Message-ID: <2026033014-mousy-counting-11fb@gregkh> (raw)
In-Reply-To: <20260329112352.31917-1-tanjimkamal1@gmail.com>
On Sun, Mar 29, 2026 at 05:23:52PM +0600, Tanjim Kamal wrote:
> The line was misaligned. Align the arguments with the parenthesis above
> and wrap the line to prevent crossing the 100-character limit.
>
> Fix a CHECK issued by scripts/checkpatch.pl.
>
> Signed-off-by: Tanjim Kamal <tanjimkamal1@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870..1c34de020 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> + words_to_write);
> if (ret)
> goto end_unlock;
> }
> --
> 2.47.3
>
No, the original code is fine here.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-30 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 11:23 [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible() Tanjim Kamal
2026-03-30 15:59 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026033014-mousy-counting-11fb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ethantidmore06@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rayfraytech@gmail.com \
--cc=tanjimkamal1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox