public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yiyang Chen <cyyzero16@gmail.com>
To: wang.yaxin@zte.com.cn
Cc: akpm@linux-foundation.org, bsingharora@gmail.com,
	cyyzero16@gmail.com, linux-kernel@vger.kernel.org,
	oleg@redhat.com, thomas.orgis@uni-hamburg.de,
	yang.yang29@zte.com.cn
Subject: Re: [PATCH] taskstats: retain dead thread stats in TGID queries
Date: Tue, 31 Mar 2026 02:15:34 +0800	[thread overview]
Message-ID: <20260330181536.31134-1-cyyzero16@gmail.com> (raw)
In-Reply-To: <20260330205752003Xgw7LWOZDJvdiHCwa5If0@zte.com.cn>

Hi Yaxin,

Thanks for the review.

> 1. Capturing the final delay-accounting update before task exit is necessary;
> otherwise, cumulative task delay will be underestimated over time.

Yes, exactly. My patch preserves this behavior — delay accounting was already
being accumulated in fill_tgid_exit() via delayacct_add_tsk(). What I'm doing
is extending this same pattern to other fields (ac_etime, ac_utime, ac_stime,
nvcsw, nivcsw) that were only accumulated for live threads but not for exited
threads, causing data loss in TGID queries.

> 2. For fixes of this kind, it is best to include the issue/bug ID that is being fixed,
> so the change remains clearly traceable.

Thanks. There is no formal issue/bug ID for this problem at the moment.
If needed, I can try to report one and update the patch accordingly.

Thanks,
Yiyang Chen

      reply	other threads:[~2026-03-30 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 19:12 [PATCH] taskstats: retain dead thread stats in TGID queries Yiyang Chen
2026-03-29 14:58 ` Dr. Thomas Orgis
2026-03-30 17:55   ` Yiyang Chen
2026-03-30 12:57 ` wang.yaxin
2026-03-30 18:15   ` Yiyang Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260330181536.31134-1-cyyzero16@gmail.com \
    --to=cyyzero16@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=thomas.orgis@uni-hamburg.de \
    --cc=wang.yaxin@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox