From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8673336D4E1 for ; Tue, 31 Mar 2026 05:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774936574; cv=none; b=m1RRFxq6ukI9CH/t9t2sn09p256+Ei75qmBdZ5J/bG7vVigFsMGwAMPaGyku554B8mQzbtcMTaJQxmxDL7YJGRJvWlmC7OX29JOAocyzxDFwfBLpziG0gwdRzNOBcrmMA60AgECJ0z/CTOyYM8voZ5KBs74EWmhEi9VjC+lAQMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774936574; c=relaxed/simple; bh=pV72EqT5bcVKWItDa+vXTFHlll9HnMWHUwlsRmZ5PWY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OV/qTZPE17F0ObQi9ANN/70sP+nv4lw2A7/0/mMVJIS+Ig19YhsNYz5qwQNrIYjIX+ld4GiiPw/DNFbTHc72AqH1h6taPPjzqoO0fM+GeKF+WY4qHjIOw+VB1v55IXIQ/VPR0J0bhCvpLDnFZothobUwTJk77sehESVffvqvQoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UltW0E5K; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UltW0E5K" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b980785a0bfso739160766b.3 for ; Mon, 30 Mar 2026 22:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774936571; x=1775541371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xgRGMIbUJ3AhTjO+w1QNBWgEKsQRuVAdG0Urvbs71LI=; b=UltW0E5KdexKAUmJBC6roWmSHoruS9qLPRdX+iyq/G8v/g3+j32BBPK/yIRnV6dobF 0KpipBzbtoJ+/cu2vsvBeQrCJLaoDm8QONdyaORlFg2IlOOglLDOorIBy1inUNh5s/wH aX5z0Z7G757px4LSJXhvjbHbxwWKK8SSBTWSn6qCD2Ha220NGYZQGZ8WL+0C+gldy2uR jOMjA6odnFPiTKEzOmqCdZrHY2Vmi2tRi8Dck05SGBDWtQCaRDZexJOae7IF2MZqyigp Dz9ohDu+B4EHBeOpC3iAdRSy3udGgulQ8/7vvQKyQCNkqS63y9o/Vi3zbJ3IxhsydHd0 CxpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774936571; x=1775541371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xgRGMIbUJ3AhTjO+w1QNBWgEKsQRuVAdG0Urvbs71LI=; b=EEB02UEj+rWdDQJbqg2jTQne2gJgKIXBz4Lgy6EgljJrNwVD435+4tJ05xm42tHbgS 7IOqOgGdXvGnHMPHP3UL38fT1AUSeJdYQFTf9E7MnEutbWS3sT+wTQi6MtnvpMIkLWs+ Zp+T7VvWuvh7NxJ842A7+Kn3f08TtMPdGrU710y36wu2MLtOhA/RbJrnwGdZj127ONuE ScSPqjQGW0fSValvYITfvvsYlSqcZai2ToHchp3oq3D+sDQHj+56BYbaxWgXjZAC4ipe HsHpL5TgjZLXZHmCRrb7dbLj9alQfnMpYL5ef4QJtUsAWQwDmV5+pM66TNXGfdhXMPF8 mtcQ== X-Forwarded-Encrypted: i=1; AJvYcCVJww+gbujOyEcRfJ3iwNTRFuebh7GL1A3gH7KlVQYoKG5/qnBFeVaHuJlKwE6PPaK4NlOgK5SUzYKYKBk=@vger.kernel.org X-Gm-Message-State: AOJu0YwXXNGDc3R6UFi/C8EiWcrihfgLNy8DAkwK+hS1g3tUDnMhqlMO gC8WCTzcFNwes75O8J9bUbaSFmTvCdAVMFUR7qALTx6dxhP5OtF63xFy X-Gm-Gg: ATEYQzzELzZ0nazLdPgiDJBGZZOHdqTRBWH4qvk/bzSsDuCmdvMB7PR0RdIhVGKF/wU GOgHQn9AQovMYwFCuVgr4NdiPlnhJ7/zut/55ERAY31ZGf/YznnqfVfQVyAC5yOPpofn6yw5itm qjklzdq1eFNcyNkfw3IWXVsi0CDD/9u1LJl22Pvw2d9GkdEXEsIGkULfqK6e0hpLvvVYS56HhAo JZmuy5C4biPvU0bT3ghqUQmO40HZ/Il8qjV3jO3VVsu3hfpOuAnvYp1jVLKjsp4EOQcR1Q/Fdwt hAuu0aDLH5luGpjFZWfi5/DfMV2T+U1M/rLQw/Mle1YnDsE5cQgaVp4uB9828oc0nVXWJIVu+sW jBTLibprJRjsInD6qtxba231kRx93lj24wvZ/xjcIIWR9ReGnS69MJYFTKT+er8YGSfA74xJs30 F84xI= X-Received: by 2002:a17:907:9816:b0:b9b:1cad:fea4 with SMTP id a640c23a62f3a-b9b503520b9mr979230166b.18.1774936570576; Mon, 30 Mar 2026 22:56:10 -0700 (PDT) Received: from gmail.com ([2a09:bac5:4e22:2719::3e5:12]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae50e8asm358016066b.14.2026.03.30.22.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 22:56:10 -0700 (PDT) From: Qingfang Deng To: Julian Braha Cc: andrew+netdev@lunn.ch, pabeni@redhat.com, davem@davemloft.net, kuba@kernel.org, ebiggers@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ppp: dead code cleanup in Kconfig Date: Tue, 31 Mar 2026 13:55:58 +0800 Message-ID: <20260331055602.35880-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330213258.13982-1-julianbraha@gmail.com> References: <20260330213258.13982-1-julianbraha@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 30 Mar 2026 22:32:58 +0100, Julian Braha wrote: > There is already an 'if PPP' condition wrapping several config options > e.g. PPP_MPPE and PPPOE, making the 'depends on PPP' statement for each of > these a duplicate dependency (dead code). > > I propose leaving the outer 'if PPP...endif' and removing the individual > 'depends on PPP' statement from each option. > > This dead code was found by kconfirm, a static analysis tool for Kconfig. > > Signed-off-by: Julian Braha Reviewed-by: Qingfang Deng