Re: [PATCH v8 2/3] vfio/ism: Implement vfio_pci driver for ISM devices

Julian Ruess
2026-04-02T07:06:52Z

On Thu Apr 2, 2026 at 12:04 AM CEST, Alex Williamson wrote:
> On Wed, 25 Mar 2026 14:31:24 +0100
> Julian Ruess <julianr@linux.ibm.com> wrote:
>> diff --git a/drivers/vfio/pci/ism/main.c b/drivers/vfio/pci/ism/main.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..00bc81f7225f806eac1b99c4520ab5a68137885e
>> --- /dev/null
>> +++ b/drivers/vfio/pci/ism/main.c
>> @@ -0,0 +1,408 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * vfio-ISM driver for s390
>> + *
>> + * Copyright IBM Corp.
>> + */
>> +
>> +#include "../vfio_pci_priv.h"
>> +#include "linux/slab.h"
>
> Convention says this should be:
>
> +#include <linux/slab.h>
> #include "../vfio_pci_priv.h"
> -#include "linux/slab.h"
>
> Without objection, I'll make the change and push this to next tomorrow.
> Thanks,
>
> Alex

Thank you very much!!

Julian