From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2AD43EF0A2 for ; Tue, 31 Mar 2026 16:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975475; cv=none; b=rZbIy4KUUoV8f5e6Sn4JQd1eQSNJ5n3KHkxR1DR8YzNBbWVrrLjk3Ssdq7sxgXhzbht3fV2u7AVBOAhlsYfpf4fx+pxelO3iqj3kvYmBC6ftEehoBZzdBuUUYF3mmGlVjbC6ZLUvDCxLNqyeWT2DPy/t1J/jR4arFc4fy8J1xpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774975475; c=relaxed/simple; bh=FQBwFO0MgxFGzUc/YQnZzztfDYDuCdD+FD2YOYudnD8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GO5wZz9XNX8ga29Z70iuSiSyIj1HWKof1PcxKR/rQzmDecw6V1V+ZnkzZoiAAOHWNOlVUfNyyaOQyWYNt0oou7CXajRvbiuRjAFruyVizOVjb4rf+SpYEN+Rg6BgHPD/R0Ckcj+PC4wMt7H9YeyrmEdMeDMjYA20CG5EtSYHGTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sAEztdau; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sAEztdau" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486b96760easo65495015e9.2 for ; Tue, 31 Mar 2026 09:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774975472; x=1775580272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JraACsWoveWjT2/Q+aQPIDXu+oIysQlLH7Z9AJtH7Ow=; b=sAEztdauv2hYAqKewESlnglpqn7YUYvMbI4+6ViBL8iMq4YX3i9je/bXjWqUW1jygu Kx5zOLJGjqW4QPHIhghx7sSMoPE35YSDotwXZeF5uuHhugOrd7cn3MWupyOY34nw4e0t UD8iZIAlbm++WpOUb1Yco13cC0wKu1aNOuGL60OZRlfCeg/Dpj/1E71WNxKDMD65A30h KsHXk5B7rERm4zoUKsVOOUOuzjjPsvMyLKcr5pg8OXiz9K4FRDlR67wIXTfHMHSA8xUH tpa6XK2aJin9Vy/evA/sXJLNFi7gj1/77S4PPnJP/f9C7BqehUj27VnP6vBAO7ArtfBF nHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774975472; x=1775580272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JraACsWoveWjT2/Q+aQPIDXu+oIysQlLH7Z9AJtH7Ow=; b=Sf69u3ycu747omQnm2R08dhPlAOMmh6S6CclvVShhERnwrrtlXUdkTAxD/SuoDU1/V oFXjCxuftvV/3q8LUlyrbcrkxIBo4EafwEwlzFbGz6Vo26UKZ1xxEOaNEu5x+oDKbjR8 e7e/QX32Zs3SCj+9teKu8zvho+soFXGcXXwOtvuqSJTW9fvHgvuAbQgNkZO+RVZrEMsz PFZE0id8TQdvK4T1GHrGcdwe7NZrrm2EPLUZxtdHwBNDR1I2adSxpJUROILtaKh+R+Ea +7AR5Qsat8yrQgcgE0qBMqQYT1tqnGGaQcb+X1n8+VJ4wIQeWoDwqFdYtLp7IdILGsON Hw/A== X-Forwarded-Encrypted: i=1; AJvYcCWIjg8uXZvM9huMcLZ8OqosL49W2sXG34WaajdgxMVOfw0RxFplVN6GROTRmW8k+pK428maHDuelvrgyss=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb2gMix8+bZsQUH3MvYfqi/RajCkuPKjAhXVioldxvJqHpmtMC sDZPQDDh8vXEhVwD1LUtg9HhGWWOM2S64FKzQQNOUFr5KiPcN+5WeFZB X-Gm-Gg: ATEYQzyFzbLZVDpTwNCG2GgEYRzE+O5+UnUjsoZ2ifrrzXOtqja/xsF/VueWmmaiqGP 7W9iq++bfpB/5eELSkDClTuoD0JBt+O+HvEM/sak/M0/1DfzXxBClHUrdVOvsMuDUrB3tw+Eqk+ 4OigulNp5gb814LvOVi5oaslqW1qfH7va7C0zjylcK7FUj7Ws8ttuQfk0khOdl6OT7ToLNAlbYg Tu1yzIb8c+/Xd0KTbibRsOs21+PfQaR6YB/05lISccWanrEEaqfOw5iYD6JXBUIFkDNin5qqjOl cygSK4DMuAwdjWcN1zD08EzjyueHzhsue2OYGZOBqEUftxQJ3L5sZc6Fc6KadyV39158wCYYNfE 7AaEoMJzGwvSXDLzb1gFq0JhUxXJYBnuvi0t2ApS5+Do7ph9qm4CWqNehs5DVzR/TN5LFd/mPVE EQVxdfIeonTSMWogkVZ7YF71rcT3hHqv9Z19ARYvc9MTgMrrA+OrC1 X-Received: by 2002:a05:600c:3b1f:b0:488:7c98:e9df with SMTP id 5b1f17b1804b1-48883306d7emr2300745e9.0.1774975471864; Tue, 31 Mar 2026 09:44:31 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:7962:f026:60f9:dfb3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e81a2cesm51173135e9.8.2026.03.31.09.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:44:31 -0700 (PDT) From: grondon@gmail.com To: error27@gmail.com Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Date: Tue, 31 Mar 2026 17:44:29 +0100 Message-Id: <20260331164429.47314-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gabriel Rondon On Tue, 31 Mar 2026 13:55:43 +0300, Dan Carpenter wrote: > hdm_ch can't be NULL. It's a pointer to the middle of a struct plus > an offset. You're right, the NULL check is unnecessary here. Will send a fix removing the !hdm_ch check and keeping only !hdm_ch->is_initialized. Thanks, Gabriel