Re: [PATCH 1/8] regulator: pbias: Add pbias SIM regulator for OMAP4

Thomas Richard
2026-03-27T13:19:01Z

Hello Andreas,

Thanks for the review.

On 3/27/26 1:36 PM, Andreas Kemnade wrote:
> On Mon, 23 Mar 2026 16:02:42 +0100
> Thomas Richard <thomas.richard@bootlin.com> wrote:
>
>> Add support for the pbias SIM regulator found on OMAP4 (for USB I/O cell).
>>
>> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
>> ---
>> drivers/regulator/pbias-regulator.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-regulator.c
>> index cd5a0d7e44555f04d1e44470036c6e3d9feb7be6..10c4940e73635293bebd26bf99a9067eb6e39107 100644
>> --- a/drivers/regulator/pbias-regulator.c
>> +++ b/drivers/regulator/pbias-regulator.c
>> @@ -81,6 +81,16 @@ static const struct pbias_reg_info pbias_sim_omap3 = {
>> .name = "pbias_sim_omap3"
>> };
>>
>> +static const struct pbias_reg_info pbias_sim_omap4 = {
>> + .enable = BIT(28) | BIT(20),
>> + .enable_mask = BIT(31) | BIT(28) | BIT(20),
>> + .vmode = BIT(31),
>
> BIT(27)? or am I mixing something up?
No you're right, I did a mistake.
I'll send a v2 in the next few days to address this, Mark's and Conor's
feedback, as well as few other issues I identified.

Best Regards,
Thomas