From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B173F4418F0 for ; Tue, 31 Mar 2026 18:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980338; cv=none; b=vBqdFC3GrQk+ljVd68Fyd2j2ahb7Xg+1a8t9GQFxN9ZYfAMQyvBkSqwSDGQif57NogsFebjLQ+LJNIfd1Z1rF7a+TG/vISB+lWc17byf/WpjUgVdPwJ5NPgvgO9WfEHOdGDo7hDvVreQrJKCqMsjlO+H7rXdmo8qjo3YewSiES8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774980338; c=relaxed/simple; bh=WCKaWsZnuOH3ILXwiQ59qJOVOeDEUiGlBDXxWQbq38Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eIBzU910nVsVtxanpZ38orWsPOcvFZfb2aQWJcUeE6Zs6lmvQ0JMGIDkurOW8RwPhU2CkedbGu+dn1a6gDS3z5yWGr7EUiytroDiGT2x2lLcDCrQ1rArpU3OChrNXinIOXZYATKHo8xLM6Ttd/6tZHhFAZ/iLSLpQ9JUWd2zLAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NpvwoTg/; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NpvwoTg/" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fb439299so56288355e9.0 for ; Tue, 31 Mar 2026 11:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774980334; x=1775585134; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WCKaWsZnuOH3ILXwiQ59qJOVOeDEUiGlBDXxWQbq38Q=; b=NpvwoTg/26KxeMfyiq9FqYNsPy+gS9R1CmARvP3f1wEwDPvmtu1uXEicQcwTNTRYv9 GKly7/1/5ybMiSktVA37ZTJc4JTSy+4/Exf/3T7KSZiALrF9zCfejbWzssMAwNRBGU2n vyY/wxAL0uboiLag4HleZMJhGVxEsCOSa3CXnfy3QJ92dsE8xkXmkXAwdccZBR/EKP6H NGt/l198XDRBBADJSeia4Lx+kYfJIiitNPvQEAsbXK84qXKAJW4bOUjzPMRHfeachseY 3DcfSMvQLnigRqxl3jHFAg9ij0LxTp94J+MsBswKrHUZD5eO6GYIuoz0lXWyjN3WZB1g 05Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774980334; x=1775585134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WCKaWsZnuOH3ILXwiQ59qJOVOeDEUiGlBDXxWQbq38Q=; b=e4gAcvaeP0vzfbEYsjPMz09tgVlRZHA7FXMECp5hoZo0gLj4KXj1Wa4Wej5HoOha03 D1xdBgMxpZ8AWwZxmpuiygpnCiBvh0vfIW6r6nAD8ukf30ocN6MHgvh6Ze+qojHKDsND kvVMbPx+dk8nyFWjVvDZnoE3AeGp4HzOW9uB7r1IatNw9iD5zBVZfJ8zVqRnBHA4dJXD V83rR0qrL8Q+oIQlCfCv1BS2Fhx/9eIlwx8cR2/HJ0+fnItQh0FlxlaQEZZyyoKyggp4 nJLZ/LfJOWNakVZuqSjieNCFTBZcirNZfKJB1panoTzRwnJIFuj/saNlCuo861ZcHoZz hUfg== X-Forwarded-Encrypted: i=1; AJvYcCXqADubfsvW/p8dJYPX2I+Jz8QsqfumA3n/hRnhuclJoTH0yNJM6akjJLRHHPnHR4p4OSQBlqQjjemLYW0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd7iI+ojjJRzVsnc/ycEvtjik6MyS/r9eOSTeiDf0kgJo1eSKX QERaT2nWHxcuPdHR0BVLpa+EqNc1ZGhFd8xIeeR/KhWLmdijMSACmAgK X-Gm-Gg: ATEYQzzBVCsc5bI2e7dLtXTcp3oyJsQOngfww+5AugAOfNiso00f2fLLmG6MhdobUdq 95tt4PtdKNoyTt2uF8D1PzCRKBHR7gC0Il/+HCmZPUmk3rN3ftyO2lc5GatHgg5NhyeGS5f0mQh h2j2vPiALhYuWvzk1nu/3+nGjRYZpuo6WrX58KAbSD+xlAobaPIUHUPPZt/eGKwWrJKvNK//fxf 25uY87+JtR9y4v7dik4oCd6CebWwCcrcg06ZGcMC4m1SAm58LxEeilFbL2CWVtX4GKJ+nLMuxtf w14QmFz0yzyJjDMbNYmbZVJp5QrqLNMCIOA+hytb3zQNK0onv7ldbAR+PTctvN23M2Nf4g1+rF3 lqehBN/qR8hK50XuNOTHGpzisaQxYhnDxO0QZOS0iMTVR8E+YiXj9scqWC8C/eN+A4H8B4JY0P2 LpoOtaAFFFMyakeTRSVQe+FdYSgvLic+do+KY5xLovNMx6W1oJY+WGehZn10kLEOjen/QyNTPKI t4TCuUTrAye5IRyCxyr8Hh8kpe37K1N0TBQG28XmvVmGshvsBRVf01TvUA= X-Received: by 2002:a05:600c:4e88:b0:485:3f72:323f with SMTP id 5b1f17b1804b1-4888358809emr5951695e9.11.1774980333592; Tue, 31 Mar 2026 11:05:33 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48880946cc5sm34109715e9.13.2026.03.31.11.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 11:05:32 -0700 (PDT) From: Prathamesh Deshpande To: leon@kernel.org Cc: dledford@redhat.com, haggaie@mellanox.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, prathameshdeshpande7@gmail.com Subject: Re: [PATCH] IB/mlx5: Fix memory leak in GSI QP destroy error path Date: Tue, 31 Mar 2026 19:04:02 +0100 Message-ID: <20260331180531.16845-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260331134508.GD814676@unreal> References: <20260331134508.GD814676@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, Mar 31, 2026 at 04:45:08PM +0300, Leon Romanovsky wrote: > GSI QP are different from other "best-effort" failures. It MUST to fail. > We are intentionally leaking resources here. Hi Leon, Thank you for the explanation. I understand now that for GSI QPs, the hardware constraints make a memory leak preferable to the risk of an inconsistency in this failure path. I'll keep this in mind for future mlx5 cleanup patches. Thanks, Prathamesh