From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52883175A79;
	Wed,  1 Apr 2026 01:07:26 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775005646; cv=none; b=fsePP6wDDwAEQf+bGhxb5bPjfSJmZeV7iyEHQJqxEz5wdyvLaePU6bQzSNKDNGSnjPP13Trje9xC0Bte1+aQY2OMpmuo5BBAfNN7VuPv4UJE1tAluC8NYKl8WmHagFr81k2uvx8wBnolaxiHKCo3SxlEVH/lihKGnWl809tTIlE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775005646; c=relaxed/simple;
	bh=k8IeX6WyY0PVZ54Mm0EBbtzQpHlrBrAlvtbUybofxqM=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=Y3m2Vvfg4+U5o1uk+Oap3GDUa7gO4xPyN0vLrcF/1oqTcJvFtycIUCQU/ReloOsn/uToTLko+PSm14ZwpMAtBtR83gzzIFwFYJddIWuhPsxOUIZCyJ/R41lOheQyfMN/0hhZGMO12LoDfEaKdTLWGOXYD1OBoaKydNY7/pmJsis=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FVMkG/sT; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FVMkG/sT"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D50C2BCB3;
	Wed,  1 Apr 2026 01:07:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1775005646;
	bh=k8IeX6WyY0PVZ54Mm0EBbtzQpHlrBrAlvtbUybofxqM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=FVMkG/sTrSB5ejGqfRbgMO8zH7ZNCZ/W1Eo7XSN2ALVhvNyEXRexA+yqam3JvSfMQ
	 I4mzFe+YT1xzmxIpMwClUqFtHlYKiaTu/IZppBS3R3mBTakuNof3UWY3gnWT0jb8C/
	 5OFVkKUgY0NReJuHazdyfWYQHo+9rQLuF93MVYPTw8AY/K+UvhsE/64MsIkVE8vipW
	 ik0ackX16GxJHfOeVXmOq0AKs+6I/katlmY7a9hAoM/imVvuFDo5XGGxBL12M76Jhm
	 eg57ZGHt1yrvmi431BFhBz24WtZ48npqn39o5D6MkK9QnmRdOmA2gosNXHlRBIJ8pp
	 4XKYbAIvQYoEA==
Date: Tue, 31 Mar 2026 18:07:24 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Wang Jun <1742789905@qq.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>, "David S . Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn,
 23120469@bjtu.edu.cn
Subject: Re: [PATCH v2] net: ns83820: fix DMA mapping error handling in
 hard_start_xmit
Message-ID: <20260331180724.78f76e00@kernel.org>
In-Reply-To: <tencent_EB7280CE1394ABF5035CDA078FC60A481906@qq.com>
References: <51dfd8ae-dc4e-4837-9b00-c596c457117e@redhat.com>
	<tencent_EB7280CE1394ABF5035CDA078FC60A481906@qq.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 31 Mar 2026 20:21:41 +0800 Wang Jun wrote:
> This is v2 of the DMA mapping error handling fix for ns83820. Changes since v1:
> 
> - Added queue restart check in error path to avoid potential TX queue stall
>   (as pointed out by the AI review)
> - Adjusted variable declarations to follow reverse christmas tree order
> - Switched from dma_unmap_single to dma_unmap_page for fragments
> 
> Thanks to reviewers for the feedback.

Please do not post new patches in reply to old ones.
Please do not post new patches within 24h of previous posting.

And ask yourself if you trying and failing to post patches for this
ancient driver is a good use of maintainer's time.