From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D550013FEE; Wed, 1 Apr 2026 01:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775008229; cv=none; b=l7Q8Wsj+PPo/072Zr5/pd4wScjBD/oh2OE4vSzfo2L5G8irB6CsDATqO4wrc5tOBspryVnCNLKdgac8ZBMhFoO7cai6PdpwaClYLs4wWRjCIcvZNQNbB8Lltpguf66hyFXpHQAHvSQeXbFCuWnga3XcaCJgKRoNVFeZDinX+GGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775008229; c=relaxed/simple; bh=zF+IwgsMlWdbcS4YI7VuKc9Odl/LNhRXN+v/URS4t3Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LUsquZ15e2U2mlsdpqodROGB0SauNRag4Ml0kEeMJCysaHdjsx87/sIvGTxZPKMND4k7wj8MRuwQL6ji6zdCayFevfrvmfmBeb5+BPvyoIzVnXFjdfs231wXu23SCd/vaG+4K31chLOW9PWxT6KkfaG/Wrl12oA3DejWl1SXJKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IAZX7zUf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IAZX7zUf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE7F4C19423; Wed, 1 Apr 2026 01:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775008229; bh=zF+IwgsMlWdbcS4YI7VuKc9Odl/LNhRXN+v/URS4t3Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IAZX7zUfRFxlOSNmSSyXBbHF63z1mcbWHF68z3T03XnfRp+KMI7g/ovY53Y1Xxoi3 ads6Q9O9F7SHabqITSawwwijruJlKd0RBNBIe34Jkg6f8UkVgMAHOWUlsGQfgK8bo+ 0Dd82fNZAMXq8mGMR0W+kJiWAy1eiAzN/OrsXkRRpkM0qzZ+RuOdZ/gEj36mYmL0QL 4pq4kWqmS7N6Zyx0R7sd0NgPnZCTrkgvFXwadM8HywjxQEgf976y6x2GDEMaRP3omE om4OGm/HYbd2+6XSCfm/z5LIrRrqi2D4krqDEiZQEPl1u1veQsLisTKtKYezrcMJtB TIayPekWR3aPA== Date: Tue, 31 Mar 2026 18:50:28 -0700 From: Jakub Kicinski To: Hangbin Liu Cc: Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] tools: ynl: ethtool: use doit instead of dumpit for per-device GET Message-ID: <20260331185028.45dffe3a@kernel.org> In-Reply-To: <20260331-b4-ynl_ethtool-v1-1-dda2a9b55df8@gmail.com> References: <20260331-b4-ynl_ethtool-v1-0-dda2a9b55df8@gmail.com> <20260331-b4-ynl_ethtool-v1-1-dda2a9b55df8@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 31 Mar 2026 11:56:11 +0800 Hangbin Liu wrote: > +++ b/tools/net/ynl/pyynl/ethtool.py We have converted all the samples to selftests so this script is the last piece of random "PoC" code we still have laying around. Should we also move it to tests/ ? If there's a reason to keep it as is -- could you please add that reason at the top of the file for my future self? I'm pretty sure I already questioned this script in the past ;)