From: Jakub Kicinski <kuba@kernel.org>
To: luka.gejak@linux.dev
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, horms@kernel.org, fmaurer@redhat.com,
liuhangbin@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/4] net: hsr: address functional and concurrency bugs
Date: Tue, 31 Mar 2026 19:37:58 -0700 [thread overview]
Message-ID: <20260331193758.5dd027f6@kernel.org> (raw)
In-Reply-To: <20260329112313.17164-1-luka.gejak@linux.dev>
On Sun, 29 Mar 2026 13:23:09 +0200 luka.gejak@linux.dev wrote:
> This series addresses four logic bugs in the HSR/PRP implementation
> identified during a protocol audit.
>
> The primary change resolves a race condition in the node merging path by
> implementing address-based lock ordering. This ensures that concurrent
> mutations of sequence blocks do not lead to state corruption or
> deadlocks.
>
> Additional fixes include correcting asymmetric VLAN error unwinding,
> enforcing strict supervision frame TLV validation, and improving Netlink
> error reporting for invalid interlink attributes.
I think that patches 1 and 2 need to go to net with a Fixes tag.
They look like run of the mill bug fixes. 3 and 4 are logical
fixes and change behavior so net-next makes sense.
FWIW AI has something to say about patch 3, I did not investigate:
https://sashiko.dev/#/patchset/20260329112313.17164-2-luka.gejak@linux.dev
--
pw-bot: cr
prev parent reply other threads:[~2026-04-01 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 11:23 [PATCH net-next v3 0/4] net: hsr: address functional and concurrency bugs luka.gejak
2026-03-29 11:23 ` [PATCH net-next v3 1/4] net: hsr: serialize seq_blocks merge across nodes luka.gejak
2026-03-29 11:23 ` [PATCH net-next v3 2/4] net: hsr: fix VLAN add unwind on slave errors luka.gejak
2026-03-29 11:23 ` [PATCH net-next v3 3/4] net: hsr: require valid EOT supervision TLV luka.gejak
2026-03-29 11:23 ` [PATCH net-next v3 4/4] net: hsr: reject unresolved interlink ifindex luka.gejak
2026-04-01 2:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331193758.5dd027f6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox