From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E9A29BDBB for ; Tue, 31 Mar 2026 21:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774993572; cv=none; b=hrut/cK+mflFZK1IOjuJDHrBbjchZTFjGxIdWTwfqW9Bph3VGFFFNNCAXgbdaGesBq0nfj0D8uMGySYEEeR2K0+KU8GP5AEFVp4zBAFiY6zegeIUQbwJc2vW7O7pMQPoZsCDFtZbTrgSkwZH4rwiWqsYUxycUThXI1jhx9Ry0Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774993572; c=relaxed/simple; bh=mDXBqep36aBsFU/3thyTsIPrbSPv//RBZ/t/B3M726I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dGL7St240U7oxIcmkQGpQOCIymiRy9EL6ji4OjM4yEjDfFawCKzhYQ6iqclI0XqYQ7MBGDT0nAJvKr4gZqYa4MEeufg0d7sQLPAV9McpojXSMkUra0Yd9KnKQtwAYad0cn6F3kzj3w+9INOmxl9rp3IAj7IHjS/BMVxUaKxTisE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZwuSRht2; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZwuSRht2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774993571; x=1806529571; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mDXBqep36aBsFU/3thyTsIPrbSPv//RBZ/t/B3M726I=; b=ZwuSRht2269nkn7poIvKKgKVWdZd1cQcBqZ68mhTc6vNb3MPxI7kaupV Lx7aQxJxY6yjmsSEkrsxy7KrPjObz8C45mYqjiG1plNSmyEcEIozXvUJl ngyvrp5KmaZZmnXTBj8UJ7kqxaPYCZkXcqpC4d4klNEPYtcQms3L1kBQ9 WGWonjoQKDdIbz7J8X7Lay307PzP5833sJuOWM4xZxthLBeNLYxTIHaUM cqlJlsRS0OVmhSzlXX3cPNgrdzhwF4NJICxQrTyvI1s2tYzwHAsciH/qN CYn0ltr0pTQyD1tZ166V+DTkixUj3rTt1oZc54ZXKE0AN/5uOCqF0E1pD A==; X-CSE-ConnectionGUID: tvrUD0QSRRC5saQ1Wm6Lew== X-CSE-MsgGUID: P4Q+Y8tqT9+djvKJa+aQwg== X-IronPort-AV: E=McAfee;i="6800,10657,11745"; a="79627240" X-IronPort-AV: E=Sophos;i="6.23,152,1770624000"; d="scan'208";a="79627240" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 14:46:10 -0700 X-CSE-ConnectionGUID: gE8mKRzdSbW9NnCQ8lnGcg== X-CSE-MsgGUID: E/TagzcvRYuwGhbX8XOKxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,152,1770624000"; d="scan'208";a="249701118" Received: from dwillia2-desk.jf.intel.com ([10.88.27.145]) by fmviesa001.fm.intel.com with ESMTP; 31 Mar 2026 14:46:10 -0700 From: Dan Williams To: mcgrof@kernel.org, russ.weight@linux.dev, dakr@kernel.org Cc: linux-kernel@vger.kernel.org, Chao Gao , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH 0/3] firmware_loader: Fix shutdown ordering and reference counting Date: Tue, 31 Mar 2026 14:47:23 -0700 Message-ID: <20260331214726.903274-1-dan.j.williams@intel.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Chao Gao raised a module reference circular dependency report resulting from *correct* usage of the firmware_upload_register() API [1]. The module reference count is not necessary nor sufficient for protecting against racing unregister against in-flight requests. After that is fixed, a couple more cleanups fall out. [1]: https://sashiko.dev/#/patchset/20260326084448.29947-1-chao.gao%40intel.com?patch=10705 Dan Williams (3): firmware_loader: Stop pinning modules on registration firmware_loader: Stop pinning parent device per workqueue invocation treewide: firmware_loader: Drop the unused @module argument .../driver-api/firmware/fw_upload.rst | 2 +- include/linux/firmware.h | 15 +++--- drivers/base/firmware_loader/sysfs_upload.c | 48 ++++++++----------- drivers/cxl/core/memdev.c | 4 +- drivers/firmware/microchip/mpfs-auto-update.c | 2 +- drivers/fpga/intel-m10-bmc-sec-update.c | 4 +- drivers/greybus/gb-beagleplay.c | 2 +- drivers/media/i2c/thp7312.c | 2 +- drivers/net/pse-pd/pd692x0.c | 4 +- lib/test_firmware.c | 3 +- 10 files changed, 38 insertions(+), 48 deletions(-) base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c -- 2.53.0