From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 720244534A4 for ; Tue, 31 Mar 2026 21:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774994269; cv=none; b=AQgduxXlcWc79GkKrQWIHU4rbzn7uJE5QiDj6Bdzqo+FmOc5ozKO7Ys3hPOQYNxdOWhDpIUpPWGL8COAkMkc2RrNTarxrpfWnOhX2dwBv4Zs6CA2p7nLeIEDoLiHXxcNkntGzopxmMc8jFoQpvwVven3I12o9CtPKX0Rm4jXw7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774994269; c=relaxed/simple; bh=niV1ii6af4nDBIeDr9Af/Z4k/iahNh7hfpkRVInzAvk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U//JWzr+oR4v1ueooGEZz48tIpsu4eplcUkU1N6fZDm6qq99eSw2+rLQvCFlUZyb6R8KGN08/cxoF7JZQ1rGViZHRAtxTF39+cynX8w84iR+YDiWR1jYGxOxICLsBq2OFhaZ38ASO48x4wlwZAgax3L0vaTM1Qapv8IbQJUWVPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YTZFMRjI; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YTZFMRjI" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4887f49ec5aso15158155e9.1 for ; Tue, 31 Mar 2026 14:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774994267; x=1775599067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=niV1ii6af4nDBIeDr9Af/Z4k/iahNh7hfpkRVInzAvk=; b=YTZFMRjIfs8AgAWLMM6S834OnJRnUGeUwBQnproxXX8Icjp7o55bFnktP9Ee3zUZch WBHkK1AZGv0D5/U9f8NFBZS3azElFdFIFwmzVeoelmMI6NY+fXYE+XGhdYUrNxQkuFGQ CR9GN+6MoR8p9h7ZYy69RjIdoHcBtSjtzYNqOkH9Y/+0WkuWvc1+TRRKRYI1k+DSQNqY F3a/Q2jETWFNvF7RX5vVHQ/r0g8s5Iu9mprsZjUktDAP6XxuegL0Jz+5TtT5XYOQjrup tS/0ytME8lKPilkUuT1Um59rDdN9i3FdoVi6UKWv34epeHCZOx9IrSFXkb3B5tIXRjdd bREg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774994267; x=1775599067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=niV1ii6af4nDBIeDr9Af/Z4k/iahNh7hfpkRVInzAvk=; b=qq6WbggL7CviRrZ0PsTJoB7DzH67eTU8h8KcNNhwopdYvoSPNR7kg6xGTIlfkwNAKZ KGUg5XOWktq+sbeK9kKLgizbz5zGJ/szmcQ0QnwecGq9/1xJfUpk/pWRRv2qMozCaFwD zCQZDjmpf4gNNz+mzJwsRkENiyvNRr4jlrOgXjDa9ejSlbk9doDqL6oHOYcM2hVYJoqW CwiwWaKfsm5udv28GD1mBjkFQvuukTm9h8rsun3YPxZXm8Wzm3coZOEBzDEyyjNtGafa L6o9Qdft39/v5j7KspCQ63cwPYwVTabaCfxJSImxZDVSMqLtDZrnY34ipeazBG+ekFhD Y/EA== X-Forwarded-Encrypted: i=1; AJvYcCWLkZTZRmIbJtwrn7mzHzhTPYix6NR8a9YthLUnzEW3ZL0DXBZZcaWGATje5KbvGMAuMFS7M26bUomA/Ns=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi6uINnF8MJLfJeSOWlMPxHsmv1YddTKKLGhUxQXxVW88HkyC0 96xxfY98dtyqR+oWjDZN+kjbYPXKIz14R3e8d/zBGFwy65op/KskXd9t X-Gm-Gg: ATEYQzzvOzpkhJMS5JV4JKPF+7JvWHtMklACEhroaLsWuSnjFGdDfBJvupnst4nHVaQ H96zeLLN/W4U3QXvr6DeGGVzE8BRAiZk8/N46PT5vazsmg9xR70n8BtGwVd8ed4yV1QQT3Um3Gq IOdvAtcOswOt9e+tlSFKG1wW2AJ+DQlYa9poyNcNVOPFw+hMI3ha/RZq9c73/RY7FlQLidURw3S anHc/0RUxkjaJCU/WvIwKDDNACoaTbbcL4yj6i5kPxZj5NRroroXb719JmVjxJ1koRNgcuc4VHH Sl5DKL/FT8tfV2KZz0moh8uwf6C6X8cqU7tYDS5hO5kAPC5Yd/dFU4OTORvw/5eTjuMUFaUxW8h C+0QedNTeK+evl7hMrF+B8G3L/VlVP60L0W+rU760AwA/dukLL2oxDKdpu6HypRvv7tJX2qKeD+ Zg5863YP6fUXch7vVK6blVwmxDn9gxigxzQJ7Th60zDWqiyVwApiOasYMSzl/kXkveL93eaOguK 8VX9IhQMzoCWNHp+/5/fSUkuQUiZ9uMtJfhfoO/gzxUqIw4 X-Received: by 2002:a05:600c:828f:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-48883562a22mr18501875e9.7.1774994266592; Tue, 31 Mar 2026 14:57:46 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e843a55sm48777715e9.12.2026.03.31.14.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 14:57:46 -0700 (PDT) From: Prathamesh Deshpande To: Leon Romanovsky Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, prathameshdeshpande7@gmail.com Subject: Re: [PATCH] IB/mlx5: Fix potential NULL dereference in query_device Date: Tue, 31 Mar 2026 22:57:36 +0100 Message-ID: <20260331215744.17039-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <202603311604.GD814676@unreal> References: <202603311604.GD814676@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, Mar 31, 2026 at 10:04:00PM +0300, Leon Romanovsky wrote: > Kernel-space callers don't use uverbs path. It is solely for the > user-space access. Hi Leon, Understood. Smatch flags this as an "inconsistent NULL check" because 'uhw' is explicitly checked at line 967 (if (uhw && ...)). If 'uhw' is guaranteed to be non-NULL in this path, would you prefer a patch removing the redundant check at line 967 instead? This would align the logic and silence the static analysis warning. Thanks, Prathamesh